LBRYCommunity/spee.ch

mysql - record and check state of local files #32

Merged

bones7242 merged 10 commits from mysql into master

2017-06-17 06:21:35 +02:00

bones7242 commented

2017-06-16 21:31:25 +02:00

(Migrated from github.com)

Added mysql table to track Files stored locally. The serve routes now check the Files table before trying to perform a 'get' on the daemon. If a local match is found based on claim_id, it checks the outpoint and either serves that local file or retrieves an updated one.

Added mysql table to track Files stored locally. The serve routes now check the Files table before trying to perform a 'get' on the daemon. If a local match is found based on claim_id, it checks the outpoint and either serves that local file or retrieves an updated one.

kauffj (Migrated from github.com) reviewed 2017-06-16 23:50:45 +02:00

kauffj (Migrated from github.com) left a comment

Good stuff!

Good stuff!

config/default.json

kauffj (Migrated from github.com) commented

2017-06-16 23:50:29 +02:00

What's this?

What's this?

helpers/lbryApi.js

kauffj (Migrated from github.com) commented

2017-06-16 23:39:34 +02:00

It might be a good idea to declare an extremely simple error logging class or function that simply calls console.log internally. That way when you want to replace it later with more sophisticated logging, you can do so easily, rather than needing to track down all the log calls.

Not a blocking suggestion.

It might be a good idea to declare an extremely simple error logging class or function that simply calls `console.log` internally. That way when you want to replace it later with more sophisticated logging, you can do so easily, rather than needing to track down all the log calls. Not a blocking suggestion.

kauffj (Migrated from github.com) commented

2017-06-16 23:49:22 +02:00

Writing all paths as relative from the root project folder rather than relative from the current file will make for later easier refactoring IMO.

Writing all paths as relative from the root project folder rather than relative from the current file will make for later easier refactoring IMO.

helpers/lbryApi.js

kauffj (Migrated from github.com) commented

2017-06-16 23:42:45 +02:00

This section can be simplified by avoiding repetition of response.data.result.

This section can be simplified by avoiding repetition of `response.data.result`.

kauffj (Migrated from github.com) commented

2017-06-16 23:43:13 +02:00

(unnecessary return)

(unnecessary return)

helpers/lbryHelpers.js

kauffj (Migrated from github.com) commented

2017-06-16 23:48:03 +02:00

lbryHelpers.js sounds like and sort of looks like the kind of file that is on track to accumulate a lot of functions and become a mess. Worth looking at the typical patterns for unique or business-level modal functions in this framework.

`lbryHelpers.js` sounds like and sort of looks like the kind of file that is on track to accumulate a lot of functions and become a mess. Worth looking at the typical patterns for unique or business-level modal functions in this framework.

bones7242 (Migrated from github.com) reviewed 2017-06-17 00:36:10 +02:00

helpers/lbryApi.js

bones7242 (Migrated from github.com) commented

2017-06-17 00:36:10 +02:00

✔️

:heavy_check_mark:

bones7242 (Migrated from github.com) reviewed 2017-06-17 00:39:14 +02:00

helpers/lbryApi.js

bones7242 (Migrated from github.com) commented

2017-06-17 00:39:14 +02:00

✔️

:heavy_check_mark:

bones7242 (Migrated from github.com) reviewed 2017-06-17 04:23:42 +02:00

helpers/lbryHelpers.js

bones7242 (Migrated from github.com) commented

2017-06-17 04:23:42 +02:00

may have gone a little overboard, but I did a big reorganize to address this because I agree itt was getting disorganized. This hopefully will lay the groundwork for better organization going forward. Separated out true controller functions from helper methods.

may have gone a little overboard, but I did a big reorganize to address this because I agree itt was getting disorganized. This hopefully will lay the groundwork for better organization going forward. Separated out true controller functions from helper methods.

bones7242 (Migrated from github.com) reviewed 2017-06-17 04:24:43 +02:00

helpers/lbryApi.js

bones7242 (Migrated from github.com) commented

2017-06-17 04:24:43 +02:00

good point. will aim to address on next update.

good point. will aim to address on next update.

bones7242 (Migrated from github.com) reviewed 2017-06-17 04:25:13 +02:00

helpers/lbryApi.js

bones7242 (Migrated from github.com) commented

2017-06-17 04:25:13 +02:00

agreed. will wait and address this with the next big update which will be focused on logging.

agreed. will wait and address this with the next big update which will be focused on logging.

bones7242 (Migrated from github.com) reviewed 2017-06-17 04:29:27 +02:00

config/default.json

bones7242 (Migrated from github.com) commented

2017-06-17 04:29:27 +02:00

it's the path for the folder that the uploads will be uploaded to. I renamed it to 'PublishUploadPath'

it's the path for the folder that the uploads will be uploaded to. I renamed it to 'PublishUploadPath'

Sign in to join this conversation.

No reviewers

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/spee.ch#32

No description provided.