LBRYCommunity/spee.ch
1
0
Fork 0
Code Issues 95 Pull requests 2 Projects Releases 4 Packages Wiki Activity

Remove the hardcoded lbry API address #325

Merged
maximest-pierre merged 1 commit from feature/remove_hardcoded_api_adress into master 2018-01-23 19:13:50 +01:00
Conversation 1 Commits 1 Files changed 2 +13 -6
maximest-pierre commented 2018-01-18 20:33:08 +01:00 (Migrated from github.com)
Copy link

This fixes issue #324.
The LBRY is no longer hardcoded to localhost and is set by the config file.

I haven't tested it. I ran into some problems while trying to install spee.ch locally on my computer.

This fixes issue #324. The LBRY is no longer hardcoded to localhost and is set by the config file. I haven't tested it. I ran into some problems while trying to install spee.ch locally on my computer.
bones7242 (Migrated from github.com) requested changes 2018-01-23 17:45:31 +01:00
helpers/lbryApi.js
bones7242 (Migrated from github.com) commented 2018-01-23 17:44:13 +01:00
Copy link

Thanks for the PR!

Define the url string once at the top so the string doesn't have to be constructed repeatedly. Also, the /lbryapi can be dropped. E.g...

const lbryApiUrl = `http://${apiUri}:${apiPort}`;
...
axios.post(lbryApiUrl, ...

If you can make this change I'll merge :)

Thanks for the PR! Define the url string once at the top so the string doesn't have to be constructed repeatedly. Also, the `/lbryapi` can be dropped. E.g... ``` const lbryApiUrl = `http://${apiUri}:${apiPort}`; ... axios.post(lbryApiUrl, ... ``` If you can make this change I'll merge :)
bones7242 (Migrated from github.com) reviewed 2018-01-23 17:46:24 +01:00
helpers/lbryApi.js
bones7242 (Migrated from github.com) commented 2018-01-23 17:46:24 +01:00
Copy link

Also, let me know your discord handle so I can send you an lbc tip

Also, let me know your discord handle so I can send you an lbc tip
maximest-pierre commented 2018-01-23 18:09:39 +01:00 (Migrated from github.com)
Copy link

@billbitt I change it as requested.

@billbitt I change it as requested.
bones7242 (Migrated from github.com) approved these changes 2018-01-23 19:13:42 +01:00
bones7242 (Migrated from github.com) left a comment
Copy link

Thanks!

Thanks!
kauffj (Migrated from github.com) reviewed 2018-01-23 20:51:38 +01:00
config/speechConfig.js.example
@ -36,2 +36,4 @@
testChannelPassword: 'password', // password for the test channel
},
api: {
apiUri: 'localhost',
kauffj (Migrated from github.com) commented 2018-01-23 20:51:38 +01:00
Copy link

If I'm being pedantic, which I am wont to do, this is more like a host than a URI. All of the parts together comprise the URI.

Here's a reference (this terminology is fairly universal, not google specific): https://www.mattcutts.com/blog/seo-glossary-url-definitions/

If I'm being pedantic, which I am wont to do, this is more like a host than a URI. All of the parts together comprise the URI. Here's a reference (this terminology is fairly universal, not google specific): https://www.mattcutts.com/blog/seo-glossary-url-definitions/
bones7242 (Migrated from github.com) reviewed 2018-01-23 21:35:58 +01:00
config/speechConfig.js.example
@ -36,2 +36,4 @@
testChannelPassword: 'password', // password for the test channel
},
api: {
apiUri: 'localhost',
bones7242 (Migrated from github.com) commented 2018-01-23 21:35:58 +01:00
Copy link

I'm wont to do it correctly

I'm wont to do it correctly
Sign in to join this conversation.
Reviewers
No reviewers
bones7242
Labels
Clear labels   
area: devops

   
area: discovery

   
area: docs

   
area: livestream

   
area: proposal

Work is part of a proposal

  
consider soon

Discuss this issue at the next planning meeting, then remove this label

  
dependencies

Pull requests that update a dependency file

  
Epic

   
good first issue

   
hacktoberfest

Welcome to Hacktoberfest

  
help wanted

   
icebox

Long-term storage

  
level: 1

No knowledge of the existing code required

  
level: 2

Some knowledge of the existing code is recommended

  
level: 3

Significant knowledge of the existing code is recommended

  
level: 4

Intimate knowledge of the existing code is recommended

  
needs: exploration

Solution unclear, needs research

  
needs: grooming

Issue needs to be groomed before work can start

  
needs: priority

Priority level needs to be defined

  
needs: repro

Issue needs step-by-step instructions on how to reproduce in latest code

  
needs: tech design

Needs technical design signoff before implementation can begin

  
on hold

Temporarily paused

  
Osprey

Spee.ch special project

  
priority: blocker

Issue is blocking release, do ASAP

  
priority: high

Work needs to be moved into sprint ASAP

  
priority: low

Work should be done but can stay in the backlog for now

  
priority: medium

Work needs to be done within 2-3 sprints

  
protocol dependent

   
resilience

   
Tom's Wishlist

   
type: bug

Existing functionality is wrong or broken

  
type: discussion

A conversation. No specific changes requested

  
type: error handling

   
type: improvement

Existing (or partially existing) functionality needs to be changed

  
type: new feature

New functionality that does not exist yet

  
type: refactor

Minimal user-visible changes, but significant internal work

  
type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

  
type: testing

Solution needs additional user testing

  
unplanned

Work that was not planned into the spirnt, took priority over planned work

No labels
area: devops
area: discovery
area: docs
area: livestream
area: proposal
consider soon
dependencies
Epic
good first issue
hacktoberfest
help wanted
icebox
level: 1
level: 2
level: 3
level: 4
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
on hold
Osprey
priority: blocker
priority: high
priority: low
priority: medium
protocol dependent
resilience
Tom's Wishlist
type: bug
type: discussion
type: error handling
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/spee.ch#325
No description provided.
Delete branch "feature/remove_hardcoded_api_adress"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?