282 thumbnail selector #371

2018-03-05T02:24:45+01:00

bones7242 commented

2018-03-05 02:24:45 +01:00

(Migrated from github.com)

for publishing videos: added a slider to select a thumbnail from the video
moved the publish functionality out of the publish component and into a Redux saga
added check on the back end publish route to check for and publish the thumbnail file if present

- for publishing videos: added a slider to select a thumbnail from the video - moved the publish functionality out of the publish component and into a Redux saga - added check on the back end publish route to check for and publish the thumbnail file if present

neb-b (Migrated from github.com) requested changes 2018-03-05 20:21:01 +01:00

neb-b (Migrated from github.com) left a comment

This is awesome! Seems to work great. It might be worth breaking it out and creating an NPM module of the React component, just because it's really cool.

Notes:
Seems like you have a lot of console.logs
react/utils/browserHistory.js is empty
What are the two vendor assets you added?

Agreed with Jeremy's comments on slack about styling

This is awesome! Seems to work great. It might be worth breaking it out and creating an NPM module of the React component, just because it's really cool. Notes: Seems like you have a lot of `console.log`s react/utils/browserHistory.js is empty What are the two vendor assets you added? Agreed with Jeremy's comments on slack about styling

react/actions/publish.js

neb-b (Migrated from github.com) commented

2018-03-05 20:09:34 +01:00

Not needed

react/channels/publish.js

neb-b (Migrated from github.com) commented

2018-03-05 20:09:51 +01:00

Not needed

routes/api-routes.js

					
				@ -133,2 +132,3 @@

				    logger.debug('api/claim/publish req.files:', files);

				    // define variables

				    let  name, fileName, filePath, fileType, nsfw, license, title, description, thumbnail, channelName, channelId, channelPassword;

				    let  name, fileName, filePath, fileType, thumbnailFileName, thumbnailFilePath, thumbnailFileType, nsfw, license, title, description, thumbnail, channelName, channelId, channelPassword;

neb-b (Migrated from github.com) commented

2018-03-05 20:12:16 +01:00

Why does spee.ch need to know the thumbnailFilePath on the server?

Why does spee.ch need to know the `thumbnailFilePath` on the server?

bones7242 (Migrated from github.com) reviewed 2018-03-06 08:01:29 +01:00

routes/api-routes.js

					
				@ -133,2 +132,3 @@

				    logger.debug('api/claim/publish req.files:', files);

				    // define variables

				    let  name, fileName, filePath, fileType, nsfw, license, title, description, thumbnail, channelName, channelId, channelPassword;

				    let  name, fileName, filePath, fileType, thumbnailFileName, thumbnailFilePath, thumbnailFileType, nsfw, license, title, description, thumbnail, channelName, channelId, channelPassword;

bones7242 (Migrated from github.com) commented

2018-03-06 08:01:29 +01:00

This is because I'm having the client send the the thumbnail file along with the main video file together from the front end and creating the thumbnail data dynamically (if needed) based off of the main video file's metadata on the back end.

bones7242 commented

2018-03-06 08:03:49 +01:00

(Migrated from github.com)

removed the unneeded browserHistory.js file
cleaned up the console logs
the vendor files were left over from when I was using masonry.js; I may add this back but they are not being used currently so I removed them

- removed the unneeded `browserHistory.js` file - cleaned up the console logs - the vendor files were left over from when I was using masonry.js; I may add this back but they are not being used currently so I removed them

Sign in to join this conversation.

No reviewers

neb-b

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/spee.ch#371

Rows
Columns