refactor(google analytics): split ga timing events into multiple categories #374

Merged
bones7242 merged 4 commits from sharpen-ga-timing-events into master 2018-03-07 01:24:21 +01:00
bones7242 commented 2018-03-06 18:10:09 +01:00 (Migrated from github.com)

in order to sharpen the google analytics surrounding events, I broke the events into two categories:

  1. 'end-to-end' events which measure the time from receiving a request at the api endpoint to the time a response is issued to the client. (currently covers the publish api endpoint, with labels by file type)
  2. 'lbrynet' events which measure the time from when a request is made to the daemon the time when the response is received from the daemon. (expanded these events with a label for each daemon action)
in order to sharpen the google analytics surrounding events, I broke the events into two categories: 1. 'end-to-end' events which measure the time from receiving a request at the api endpoint to the time a response is issued to the client. (currently covers the publish api endpoint, with labels by file type) 2. 'lbrynet' events which measure the time from when a request is made to the daemon the time when the response is received from the daemon. (expanded these events with a label for each daemon action)
kauffj (Migrated from github.com) approved these changes 2018-03-06 21:17:40 +01:00
kauffj (Migrated from github.com) left a comment

LGTM, two superficial things I notice

LGTM, two superficial things I notice
kauffj (Migrated from github.com) commented 2018-03-06 21:15:37 +01:00

extra "r"

extra "r"
kauffj (Migrated from github.com) commented 2018-03-06 21:16:13 +01:00

could be a ternary

could be a ternary
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/spee.ch#374
No description provided.