LBRYCommunity/spee.ch
1
0
Fork 0
Code Issues 95 Pull requests 2 Projects Releases 4 Packages Wiki Activity

fix: updated claim name availability check to support multiple claim addresses #382

Merged
bones7242 merged 8 commits from 348-multiple-wallet-addresses into master 2018-03-12 20:05:24 +01:00
Conversation 0 Commits 8 Files changed 7 +61 -73
bones7242 commented 2018-03-08 05:08:14 +01:00 (Migrated from github.com)
Copy link
  • updated claimNameIsAvailable to check the Claim table rather than File table
  • updated claimNameIsAvailable to be able to check with multiple claim addresses
  • added a google analytics timing event for the api/claim/availability and api/channel/availability endpoints
- updated `claimNameIsAvailable` to check the Claim table rather than File table - updated `claimNameIsAvailable` to be able to check with multiple claim addresses - added a google analytics timing event for the `api/claim/availability` and `api/channel/availability` endpoints
kauffj (Migrated from github.com) reviewed 2018-03-08 23:02:08 +01:00
kauffj (Migrated from github.com) left a comment
Copy link

Some feedback, but nothing blocking. You do not need to have me review the PR again to merge.

Some feedback, but nothing blocking. You do not need to have me review the PR again to merge.
controllers/publishController.js
kauffj (Migrated from github.com) commented 2018-03-08 23:01:10 +01:00
Copy link

I'm confused by this function, though I would have been equally confused before this changeset. If we're querying our own DB, why do we have to consider just the ones with a certain address? Is that because the DB contains all claims?

Also, if the addresses are in the DB, can't this filtering be done in SQL rather than JS?

I'm confused by this function, though I would have been equally confused before this changeset. If we're querying our own DB, why do we have to consider just the ones with a certain address? Is that because the DB contains all claims? Also, if the addresses are in the DB, can't this filtering be done in SQL rather than JS?
react/containers/ChannelCreateForm/view.jsx
kauffj (Migrated from github.com) commented 2018-03-08 21:06:10 +01:00
Copy link

This seems like an odd pattern - what's this doing?

This seems like an odd pattern - what's this doing?
react/containers/ChannelCreateForm/view.jsx
kauffj (Migrated from github.com) commented 2018-03-08 22:57:14 +01:00
Copy link

Always use brackets for if statements IMO.

Also - is Prettier and/or a linter not set up for this project? It can catch and even fix ones like this.

Always use brackets for if statements IMO. Also - is Prettier and/or a linter not set up for this project? It can catch and even fix ones like this.
bones7242 (Migrated from github.com) reviewed 2018-03-12 19:48:03 +01:00
react/containers/ChannelCreateForm/view.jsx
bones7242 (Migrated from github.com) commented 2018-03-12 19:48:03 +01:00
Copy link

yes to linter, not yet to Prettier (#375)

yes to linter, not yet to Prettier (#375)
bones7242 (Migrated from github.com) reviewed 2018-03-12 20:05:19 +01:00
controllers/publishController.js
bones7242 (Migrated from github.com) commented 2018-03-12 20:05:19 +01:00
Copy link

Yes, the table that is being queried contains all claims, so we have to filter out claims belonging to this address. I wonder if there would be reason to create a separate table for claims the site owns? We avoided doing that previously because it seemed to be unnecessarily duplicative.

Yes, the table that is being queried contains all claims, so we have to filter out claims belonging to this address. I wonder if there would be reason to create a separate table for claims the site owns? We avoided doing that previously because it seemed to be unnecessarily duplicative.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
area: devops

   
area: discovery

   
area: docs

   
area: livestream

   
area: proposal

Work is part of a proposal

  
consider soon

Discuss this issue at the next planning meeting, then remove this label

  
dependencies

Pull requests that update a dependency file

  
Epic

   
good first issue

   
hacktoberfest

Welcome to Hacktoberfest

  
help wanted

   
icebox

Long-term storage

  
level: 1

No knowledge of the existing code required

  
level: 2

Some knowledge of the existing code is recommended

  
level: 3

Significant knowledge of the existing code is recommended

  
level: 4

Intimate knowledge of the existing code is recommended

  
needs: exploration

Solution unclear, needs research

  
needs: grooming

Issue needs to be groomed before work can start

  
needs: priority

Priority level needs to be defined

  
needs: repro

Issue needs step-by-step instructions on how to reproduce in latest code

  
needs: tech design

Needs technical design signoff before implementation can begin

  
on hold

Temporarily paused

  
Osprey

Spee.ch special project

  
priority: blocker

Issue is blocking release, do ASAP

  
priority: high

Work needs to be moved into sprint ASAP

  
priority: low

Work should be done but can stay in the backlog for now

  
priority: medium

Work needs to be done within 2-3 sprints

  
protocol dependent

   
resilience

   
Tom's Wishlist

   
type: bug

Existing functionality is wrong or broken

  
type: discussion

A conversation. No specific changes requested

  
type: error handling

   
type: improvement

Existing (or partially existing) functionality needs to be changed

  
type: new feature

New functionality that does not exist yet

  
type: refactor

Minimal user-visible changes, but significant internal work

  
type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

  
type: testing

Solution needs additional user testing

  
unplanned

Work that was not planned into the spirnt, took priority over planned work

No labels
area: devops
area: discovery
area: docs
area: livestream
area: proposal
consider soon
dependencies
Epic
good first issue
hacktoberfest
help wanted
icebox
level: 1
level: 2
level: 3
level: 4
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
on hold
Osprey
priority: blocker
priority: high
priority: low
priority: medium
protocol dependent
resilience
Tom's Wishlist
type: bug
type: discussion
type: error handling
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/spee.ch#382
No description provided.
Delete branch "348-multiple-wallet-addresses"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?