LBRYCommunity/spee.ch
1
0
Fork 0
Code Issues 95 Pull requests 2 Packages Projects Releases 4 Wiki Activity

Speech as a package #416

Merged
bones7242 merged 89 commits from speech-as-a-package into master 2018-04-18 21:47:34 +02:00
Conversation 0 Commits 89 Files changed 203 +1206 -5549
bones7242 commented 2018-04-17 20:58:43 +02:00 (Migrated from github.com)
Copy link

This pr converts the codebase to a package which exports a customizeable Server class that can be consumed and used by www.spee.ch and other spee.ch implementations

This pr converts the codebase to a package which exports a customizeable `Server` class that can be consumed and used by `www.spee.ch` and other spee.ch implementations
neb-b (Migrated from github.com) approved these changes 2018-04-17 22:46:43 +02:00
neb-b (Migrated from github.com) left a comment
Copy link

Looks good. A few comments but nothing major.

The main one being, do we need to expire users sessions?

Looks good. A few comments but nothing major. The main one being, do we need to expire users sessions?
README.md
neb-b (Migrated from github.com) commented 2018-04-17 22:27:10 +02:00
Copy link

ORM

ORM
config/mysqlConfig.js
neb-b (Migrated from github.com) commented 2018-04-17 22:32:37 +02:00
Copy link

This should probably be new Mysql() since it is a class function

This should probably be `new Mysql()` since it is a class function
index.js
neb-b (Migrated from github.com) commented 2018-04-17 22:33:42 +02:00
Copy link

Don't commit this

Don't commit this
index.js.map
neb-b (Migrated from github.com) commented 2018-04-17 22:33:52 +02:00
Copy link

This one too

This one too
server/index.js
neb-b (Migrated from github.com) commented 2018-04-17 22:37:07 +02:00
Copy link

For these you can just do

this.configureLogger = loggerConfig.update
For these you can just do ``` this.configureLogger = loggerConfig.update ```
neb-b (Migrated from github.com) commented 2018-04-17 22:39:55 +02:00
Copy link

Do we need to have any maxAge? It would be nice if the user was never logged out

Do we need to have any `maxAge`? It would be nice if the user was never logged out
neb-b (Migrated from github.com) commented 2018-04-17 22:40:27 +02:00
Copy link

I thought handlebars was removed?

I thought handlebars was removed?
bones7242 (Migrated from github.com) reviewed 2018-04-17 23:17:02 +02:00
index.js
bones7242 (Migrated from github.com) commented 2018-04-17 23:17:02 +02:00
Copy link

hmm, the problem is that the server uses jsx for server side rendering, so it needs to be transpiled (I think that's the only part that needs to be transpiled), so I wanted to build a bundle and export that bundle. Do you think I should just transpile with babel and not actual bundle with webpack? That's what I did for spee.ch-components

hmm, the problem is that the server uses jsx for server side rendering, so it needs to be transpiled (I think that's the only part that needs to be transpiled), so I wanted to build a bundle and export that bundle. Do you think I should just transpile with babel and not actual bundle with webpack? That's what I did for [spee.ch-components](https://github.com/lbryio/spee.ch-components)
neb-b (Migrated from github.com) reviewed 2018-04-17 23:27:56 +02:00
index.js
neb-b (Migrated from github.com) commented 2018-04-17 23:27:56 +02:00
Copy link

Oh I gotcha. I was confused.

I still don't think this needs to be committed. You can build before publishing. IMO if someone is cloning the repo, they will be building the app on their own.

Oh I gotcha. I was confused. I still don't think this needs to be committed. You can build before publishing. IMO if someone is cloning the repo, they will be building the app on their own.
bones7242 (Migrated from github.com) reviewed 2018-04-18 21:26:22 +02:00
index.js
bones7242 (Migrated from github.com) commented 2018-04-18 21:26:22 +02:00
Copy link

i updated it to only transpile the two jsx render functions that are needed for SSR, the rest does not need to be built at this level, as the implementation will build the app again.

i updated it to only transpile the two jsx render functions that are needed for SSR, the rest does not need to be built at this level, as the implementation will build the app again.
bones7242 (Migrated from github.com) reviewed 2018-04-18 21:29:39 +02:00
server/index.js
bones7242 (Migrated from github.com) commented 2018-04-18 21:29:39 +02:00
Copy link

it's still being used in one specific case: for sharing videos on twitter via cards, twitter needs an html page with a video player embedded, so I am using handlebars to generate that one page when needed.

it's still being used in one specific case: for sharing videos on twitter via cards, twitter needs an html page with a video player embedded, so I am using handlebars to generate that one page when needed.
bones7242 (Migrated from github.com) reviewed 2018-04-18 21:47:29 +02:00
server/index.js
bones7242 (Migrated from github.com) commented 2018-04-18 21:47:28 +02:00
Copy link

I guess we don't need to, and it does make a better user experience if the user doesn't need to log back in ever day. I eliminated the maxAge so sessions should last indefinitely.

I guess we don't need to, and it does make a better user experience if the user doesn't need to log back in ever day. I eliminated the maxAge so sessions should last indefinitely.
Sign in to join this conversation.
Reviewers
No reviewers
neb-b
Labels
Clear labels   
area: devops

   
area: discovery

   
area: docs

   
area: livestream

   
area: proposal

Work is part of a proposal

  
consider soon

Discuss this issue at the next planning meeting, then remove this label

  
dependencies

Pull requests that update a dependency file

  
Epic

   
good first issue

   
hacktoberfest

Welcome to Hacktoberfest

  
help wanted

   
icebox

Long-term storage

  
level: 1

No knowledge of the existing code required

  
level: 2

Some knowledge of the existing code is recommended

  
level: 3

Significant knowledge of the existing code is recommended

  
level: 4

Intimate knowledge of the existing code is recommended

  
needs: exploration

Solution unclear, needs research

  
needs: grooming

Issue needs to be groomed before work can start

  
needs: priority

Priority level needs to be defined

  
needs: repro

Issue needs step-by-step instructions on how to reproduce in latest code

  
needs: tech design

Needs technical design signoff before implementation can begin

  
on hold

Temporarily paused

  
Osprey

Spee.ch special project

  
priority: blocker

Issue is blocking release, do ASAP

  
priority: high

Work needs to be moved into sprint ASAP

  
priority: low

Work should be done but can stay in the backlog for now

  
priority: medium

Work needs to be done within 2-3 sprints

  
protocol dependent

   
resilience

   
Tom's Wishlist

   
type: bug

Existing functionality is wrong or broken

  
type: discussion

A conversation. No specific changes requested

  
type: error handling

   
type: improvement

Existing (or partially existing) functionality needs to be changed

  
type: new feature

New functionality that does not exist yet

  
type: refactor

Minimal user-visible changes, but significant internal work

  
type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

  
type: testing

Solution needs additional user testing

  
unplanned

Work that was not planned into the spirnt, took priority over planned work

No labels
area: devops
area: discovery
area: docs
area: livestream
area: proposal
consider soon
dependencies
Epic
good first issue
hacktoberfest
help wanted
icebox
level: 1
level: 2
level: 3
level: 4
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
on hold
Osprey
priority: blocker
priority: high
priority: low
priority: medium
protocol dependent
resilience
Tom's Wishlist
type: bug
type: discussion
type: error handling
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/spee.ch#416
No description provided.
Delete branch "speech-as-a-package"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?