LBRYCommunity/spee.ch
1
0
Fork 0
Code Issues 95 Pull requests 2 Projects Releases 4 Packages Wiki Activity

Startup fixes #449

Merged
bones7242 merged 3 commits from startup-fixes into master 2018-05-18 05:34:07 +02:00
Conversation 0 Commits 3 Files changed 4 +57 -10
bones7242 commented 2018-05-18 03:13:06 +02:00 (Migrated from github.com)
Copy link
  • high level error detection checks for lbrynet and retrieves wallet balance on startup
  • removed confusing test of error log
  • added a step to create the database if it was not already created
- high level error detection checks for lbrynet and retrieves wallet balance on startup - removed confusing test of error log - added a step to create the database if it was not already created
neb-b (Migrated from github.com) approved these changes 2018-05-18 03:19:31 +02:00
neb-b (Migrated from github.com) left a comment
Copy link

Looks good but a few formatting questions. I would definitely recommend adding prettier to this project.

Looks good but a few formatting questions. I would definitely recommend adding prettier to this project.
index.js
neb-b (Migrated from github.com) commented 2018-05-18 03:17:21 +02:00
Copy link

This is formatted weird

This is formatted weird
neb-b (Migrated from github.com) commented 2018-05-18 03:18:14 +02:00
Copy link

These can all live inside one .then after the getWalletBalance()

No need to break them up

These can all live inside one `.then` after the `getWalletBalance()` No need to break them up
bones7242 (Migrated from github.com) reviewed 2018-05-18 04:05:40 +02:00
index.js
bones7242 (Migrated from github.com) commented 2018-05-18 04:05:40 +02:00
Copy link

I tried updating a bit, is this what you had in mind? I'm still a little fuzzy on the best patterns for chaining and when to use .then, but I suppose db.sequelize.sync and this.server.listen can be handled asynchronously

I tried updating a bit, is this what you had in mind? I'm still a little fuzzy on the best patterns for chaining and when to use `.then`, but I suppose `db.sequelize.sync` and `this.server.listen` can be handled asynchronously
Sign in to join this conversation.
Reviewers
No reviewers
neb-b
Labels
Clear labels   
area: devops

   
area: discovery

   
area: docs

   
area: livestream

   
area: proposal

Work is part of a proposal

  
consider soon

Discuss this issue at the next planning meeting, then remove this label

  
dependencies

Pull requests that update a dependency file

  
Epic

   
good first issue

   
hacktoberfest

Welcome to Hacktoberfest

  
help wanted

   
icebox

Long-term storage

  
level: 1

No knowledge of the existing code required

  
level: 2

Some knowledge of the existing code is recommended

  
level: 3

Significant knowledge of the existing code is recommended

  
level: 4

Intimate knowledge of the existing code is recommended

  
needs: exploration

Solution unclear, needs research

  
needs: grooming

Issue needs to be groomed before work can start

  
needs: priority

Priority level needs to be defined

  
needs: repro

Issue needs step-by-step instructions on how to reproduce in latest code

  
needs: tech design

Needs technical design signoff before implementation can begin

  
on hold

Temporarily paused

  
Osprey

Spee.ch special project

  
priority: blocker

Issue is blocking release, do ASAP

  
priority: high

Work needs to be moved into sprint ASAP

  
priority: low

Work should be done but can stay in the backlog for now

  
priority: medium

Work needs to be done within 2-3 sprints

  
protocol dependent

   
resilience

   
Tom's Wishlist

   
type: bug

Existing functionality is wrong or broken

  
type: discussion

A conversation. No specific changes requested

  
type: error handling

   
type: improvement

Existing (or partially existing) functionality needs to be changed

  
type: new feature

New functionality that does not exist yet

  
type: refactor

Minimal user-visible changes, but significant internal work

  
type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

  
type: testing

Solution needs additional user testing

  
unplanned

Work that was not planned into the spirnt, took priority over planned work

No labels
area: devops
area: discovery
area: docs
area: livestream
area: proposal
consider soon
dependencies
Epic
good first issue
hacktoberfest
help wanted
icebox
level: 1
level: 2
level: 3
level: 4
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
on hold
Osprey
priority: blocker
priority: high
priority: low
priority: medium
protocol dependent
resilience
Tom's Wishlist
type: bug
type: discussion
type: error handling
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/spee.ch#449
No description provided.
Delete branch "startup-fixes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?