LBRYCommunity/spee.ch
1
0
Fork 0
Code Issues 95 Pull requests 2 Projects Releases 4 Packages Wiki Activity

added referrer to serve-event analytics #457

Merged
bones7242 merged 1 commit from 429-analytics-referrer into master 2018-05-29 19:13:58 +02:00
Conversation 2 Commits 1 Files changed 1 +24 -15
bones7242 commented 2018-05-25 18:35:58 +02:00 (Migrated from github.com)
Copy link
  • added referer to the params that are passed to google analytics for file-serve events
- added `referer` to the params that are passed to google analytics for file-serve events
finer9 commented 2018-05-25 18:36:33 +02:00 (Migrated from github.com)
Copy link

Yay!

On Fri, May 25, 2018, 12:36 PM Bill Bittner notifications@github.com
wrote:

  • added referer to the params that are passed to google analytics for
    file-serve events

You can view, comment on, or merge this pull request online at:

https://github.com/lbryio/spee.ch/pull/457
Commit Summary

  • Revert "Revert "added referrer to serve event analytics""

File Changes

Patch Links:

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/lbryio/spee.ch/pull/457, or mute the thread
https://github.com/notifications/unsubscribe-auth/APoYDAb5iWQFwfz7RheOWXlrmr_QXa3Qks5t2DLwgaJpZM4UORIN
.

Yay! On Fri, May 25, 2018, 12:36 PM Bill Bittner <notifications@github.com> wrote: > > - added referer to the params that are passed to google analytics for > file-serve events > > ------------------------------ > You can view, comment on, or merge this pull request online at: > > https://github.com/lbryio/spee.ch/pull/457 > Commit Summary > > - Revert "Revert "added referrer to serve event analytics"" > > File Changes > > - *M* server/utils/googleAnalytics.js > <https://github.com/lbryio/spee.ch/pull/457/files#diff-0> (39) > > Patch Links: > > - https://github.com/lbryio/spee.ch/pull/457.patch > - https://github.com/lbryio/spee.ch/pull/457.diff > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > <https://github.com/lbryio/spee.ch/pull/457>, or mute the thread > <https://github.com/notifications/unsubscribe-auth/APoYDAb5iWQFwfz7RheOWXlrmr_QXa3Qks5t2DLwgaJpZM4UORIN> > . >
bones7242 commented 2018-05-25 18:36:52 +02:00 (Migrated from github.com)
Copy link

lol, that was fast commenting @finer9 :)

lol, that was fast commenting @finer9 :)
skhameneh (Migrated from github.com) approved these changes 2018-05-29 07:01:15 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
skhameneh
Labels
Clear labels   
area: devops

   
area: discovery

   
area: docs

   
area: livestream

   
area: proposal

Work is part of a proposal

  
consider soon

Discuss this issue at the next planning meeting, then remove this label

  
dependencies

Pull requests that update a dependency file

  
Epic

   
good first issue

   
hacktoberfest

Welcome to Hacktoberfest

  
help wanted

   
icebox

Long-term storage

  
level: 1

No knowledge of the existing code required

  
level: 2

Some knowledge of the existing code is recommended

  
level: 3

Significant knowledge of the existing code is recommended

  
level: 4

Intimate knowledge of the existing code is recommended

  
needs: exploration

Solution unclear, needs research

  
needs: grooming

Issue needs to be groomed before work can start

  
needs: priority

Priority level needs to be defined

  
needs: repro

Issue needs step-by-step instructions on how to reproduce in latest code

  
needs: tech design

Needs technical design signoff before implementation can begin

  
on hold

Temporarily paused

  
Osprey

Spee.ch special project

  
priority: blocker

Issue is blocking release, do ASAP

  
priority: high

Work needs to be moved into sprint ASAP

  
priority: low

Work should be done but can stay in the backlog for now

  
priority: medium

Work needs to be done within 2-3 sprints

  
protocol dependent

   
resilience

   
Tom's Wishlist

   
type: bug

Existing functionality is wrong or broken

  
type: discussion

A conversation. No specific changes requested

  
type: error handling

   
type: improvement

Existing (or partially existing) functionality needs to be changed

  
type: new feature

New functionality that does not exist yet

  
type: refactor

Minimal user-visible changes, but significant internal work

  
type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

  
type: testing

Solution needs additional user testing

  
unplanned

Work that was not planned into the spirnt, took priority over planned work

No labels
area: devops
area: discovery
area: docs
area: livestream
area: proposal
consider soon
dependencies
Epic
good first issue
hacktoberfest
help wanted
icebox
level: 1
level: 2
level: 3
level: 4
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
on hold
Osprey
priority: blocker
priority: high
priority: low
priority: medium
protocol dependent
resilience
Tom's Wishlist
type: bug
type: discussion
type: error handling
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/spee.ch#457
No description provided.
Delete branch "429-analytics-referrer"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?