Fix configs loading #470

Merged
bones7242 merged 15 commits from fix-configs-loading into master 2018-06-07 19:40:01 +02:00
bones7242 commented 2018-06-07 01:01:18 +02:00 (Migrated from github.com)

updated so all configs are pulled directly where needed via module aliasing

updated so all configs are pulled directly where needed via module aliasing
neb-b (Migrated from github.com) approved these changes 2018-06-07 04:14:42 +02:00
neb-b (Migrated from github.com) left a comment

One tiny comment but looks good.

One tiny comment but looks good.
neb-b (Migrated from github.com) commented 2018-06-07 04:10:36 +02:00

Should this be inside the if statement?

Should this be inside the `if` statement?
bones7242 (Migrated from github.com) reviewed 2018-06-07 19:39:54 +02:00
bones7242 (Migrated from github.com) commented 2018-06-07 19:39:54 +02:00

Yes, good catch. I also added logic to skip the sending of the analytics if no googleId present.

Yes, good catch. I also added logic to skip the sending of the analytics if no googleId present.
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/spee.ch#470
No description provided.