upgrade dependencies #489

Merged
nikooo777 merged 4 commits from dependencies-upgrade into master 2018-08-10 22:18:05 +02:00
nikooo777 commented 2018-06-22 17:50:07 +02:00 (Migrated from github.com)

This PR brings in upgrades to the packages used in the project as github is warning about vulnerabilities.
In more detail, the following upgrades were performed:

 axios                    ^0.16.1  →  ^0.18.0 
 redux                     ^3.7.2  →   ^4.0.0 
 winston                   ^2.3.1  →   ^3.0.0 
 chai-http                 ^3.0.0  →   ^4.0.0 
 eslint                    4.18.0  →   4.19.1 
 eslint-config-standard   ^10.2.1  →  ^11.0.0 
 eslint-plugin-node        ^4.2.3  →   ^6.0.1 
 husky                    ^0.13.4  →  ^0.14.3 
 mocha                     ^4.0.1  →   ^5.2.0 
 regenerator-transform    ^0.12.4  →  ^0.13.0 
 sequelize-cli           ^3.0.0-3  →   ^4.0.0 

No tests were run, some major upgrades might not be compatible at all. I'd like the help of someone actively developing the project to take a look

This PR brings in upgrades to the packages used in the project as github is warning about vulnerabilities. In more detail, the following upgrades were performed: ``` axios ^0.16.1 → ^0.18.0 redux ^3.7.2 → ^4.0.0 winston ^2.3.1 → ^3.0.0 chai-http ^3.0.0 → ^4.0.0 eslint 4.18.0 → 4.19.1 eslint-config-standard ^10.2.1 → ^11.0.0 eslint-plugin-node ^4.2.3 → ^6.0.1 husky ^0.13.4 → ^0.14.3 mocha ^4.0.1 → ^5.2.0 regenerator-transform ^0.12.4 → ^0.13.0 sequelize-cli ^3.0.0-3 → ^4.0.0 ``` No tests were run, some major upgrades might not be compatible at all. I'd like the help of someone actively developing the project to take a look
bones7242 commented 2018-06-22 19:56:39 +02:00 (Migrated from github.com)

thanks @nikooo777 I'll test

thanks @nikooo777 I'll test
bones7242 (Migrated from github.com) reviewed 2018-07-09 05:32:49 +02:00
bones7242 (Migrated from github.com) left a comment

I tested this today. It seems to be working, except the winston logger is throwing a warning Attempt to write logs with no transports when logging. This doesn't seem to be an issue with winston, because it happens when I downgraded it back to 2.3.1 as well. I'm not sure what change created this. I'd like to merge the lbryio/www.spee.ch repo with this repo before debugging this, as it may have to do with the relative paths used in that repo to get resources from this package.

I tested this today. It seems to be working, except the winston logger is throwing a warning `Attempt to write logs with no transports` when logging. This doesn't seem to be an issue with winston, because it happens when I downgraded it back to `2.3.1` as well. I'm not sure what change created this. I'd like to merge the `lbryio/www.spee.ch` repo with this repo before debugging this, as it may have to do with the relative paths used in that repo to get resources from this package.
nikooo777 commented 2018-07-09 12:23:06 +02:00 (Migrated from github.com)

Absolutely! let me know if you want to do a session together so we can debug it with 4 eyes :)

Absolutely! let me know if you want to do a session together so we can debug it with 4 eyes :)
bones7242 commented 2018-07-27 06:01:04 +02:00 (Migrated from github.com)

@nikooo777, are you familiar with https://github.com/greenkeeperio/greenkeeper ?

@nikooo777, are you familiar with https://github.com/greenkeeperio/greenkeeper ?
nikooo777 commented 2018-07-27 21:03:45 +02:00 (Migrated from github.com)

I am not, but that looks like a nice tool we could implement! As long as it doesn't automatically merge the new dependencies though.

I am not, but that looks like a nice tool we could implement! As long as it doesn't automatically merge the new dependencies though.
skhameneh (Migrated from github.com) approved these changes 2018-08-04 22:39:33 +02:00
skhameneh (Migrated from github.com) left a comment

Looks good after the log is resolved, likely something simple

Looks good after the log is resolved, likely something simple
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/spee.ch#489
No description provided.