LBRYCommunity/spee.ch
1
0
Fork 0
Code Issues 95 Pull requests 2 Projects Releases 4 Packages Wiki Activity

465 social share with extensions #492

Merged
bones7242 merged 10 commits from 465-social-share-with-extensions into master 2018-06-27 18:51:51 +02:00
Conversation 1 Commits 10 Files changed 14 +141 -80
bones7242 commented 2018-06-26 08:48:02 +02:00 (Migrated from github.com)
Copy link

adds open graph support for image urls with the file type suffix. e.g. spee.ch/a/example.jpg

adds open graph support for image urls with the file type suffix. e.g. spee.ch/a/example.jpg
skhameneh (Migrated from github.com) reviewed 2018-06-26 08:48:02 +02:00
neb-b (Migrated from github.com) reviewed 2018-06-26 22:56:05 +02:00
neb-b (Migrated from github.com) left a comment
Copy link

Will the route changing affect previously shared URLs?

Will the route changing affect previously shared URLs?
server/controllers/assets/utils/determineRequestType.js
@ -0,0 +1,54 @@
const logger = require('winston');
const { EMBED, BROWSER, SOCIAL } = require('../constants/request_types.js');
function headersMatchesSocialBotList (headers) {
neb-b (Migrated from github.com) commented 2018-06-26 22:53:39 +02:00
Copy link

This could be simplified by using an object instead of an array

const socialBotList = {
    'facebookexternalhit': 1,
    'Twitterbot': 1,
}
​
if (socialBotList[userAgent]) {
  logger.debug();
  return true;
} else {
  return false;
}
This could be simplified by using an object instead of an array ``` const socialBotList = { 'facebookexternalhit': 1, 'Twitterbot': 1, } ​ if (socialBotList[userAgent]) { logger.debug(); return true; } else { return false; } ```
bones7242 (Migrated from github.com) reviewed 2018-06-27 18:49:35 +02:00
server/controllers/assets/utils/determineRequestType.js
@ -0,0 +1,54 @@
const logger = require('winston');
const { EMBED, BROWSER, SOCIAL } = require('../constants/request_types.js');
function headersMatchesSocialBotList (headers) {
bones7242 (Migrated from github.com) commented 2018-06-27 18:49:35 +02:00
Copy link

cool pattern. I updated to use this.

cool pattern. I updated to use this.
bones7242 commented 2018-06-27 18:51:37 +02:00 (Migrated from github.com)
Copy link

@seanyesmunt previous URLs should not be negatively affected. This adds a new route, but does not remove the existing routes. The new route will be used only for the image sources for SEO tags, so it is specifically for serving images for SEO.

@seanyesmunt previous URLs should not be negatively affected. This adds a new route, but does not remove the existing routes. The new route will be used only for the image sources for SEO tags, so it is specifically for serving images for SEO.
kauffj (Migrated from github.com) reviewed 2018-07-03 20:12:24 +02:00
server/controllers/assets/utils/determineRequestType.js
@ -0,0 +32,4 @@
return SOCIAL;
}
// if request is not from a social bot...
if (hasFileExtension) {
kauffj (Migrated from github.com) commented 2018-07-03 20:12:24 +02:00
Copy link

Multiple return statements in a function can be a contentious topic (e.g. https://stackoverflow.com/questions/36707/should-a-function-have-only-one-return-statement), but I think a function like this is better if the returns are just inlined, rather than setting a variable.

Multiple return statements in a function can be a contentious topic (e.g. https://stackoverflow.com/questions/36707/should-a-function-have-only-one-return-statement), but I think a function like this is better if the returns are just inlined, rather than setting a variable.
kauffj (Migrated from github.com) reviewed 2018-07-03 20:13:16 +02:00
server/controllers/assets/utils/determineRequestType.js
@ -0,0 +1,54 @@
const logger = require('winston');
const { EMBED, BROWSER, SOCIAL } = require('../constants/request_types.js');
function headersMatchesSocialBotList (headers) {
kauffj (Migrated from github.com) commented 2018-07-03 20:13:16 +02:00
Copy link

@seanyesmunt do you prefer that to just:

const haystack = ['a', 'b']
if (haystack.includes(needle))
{
  ...
}
@seanyesmunt do you prefer that to just: ``` const haystack = ['a', 'b'] if (haystack.includes(needle)) { ... } ```
kauffj (Migrated from github.com) reviewed 2018-07-03 20:14:31 +02:00
server/controllers/assets/utils/determineRequestType.js
@ -0,0 +1,54 @@
const logger = require('winston');
const { EMBED, BROWSER, SOCIAL } = require('../constants/request_types.js');
function headersMatchesSocialBotList (headers) {
kauffj (Migrated from github.com) commented 2018-07-03 20:14:31 +02:00
Copy link

(technically includes is presumably O(n) and a map lookup O(1), but this is such an efficient operation that this doesn't matter)

(_technically_ `includes` is presumably `O(n)` and a map lookup `O(1)`, but this is such an efficient operation that this doesn't matter)
Sign in to join this conversation.
Reviewers
No reviewers
skhameneh
Labels
Clear labels   
area: devops

   
area: discovery

   
area: docs

   
area: livestream

   
area: proposal

Work is part of a proposal

  
consider soon

Discuss this issue at the next planning meeting, then remove this label

  
dependencies

Pull requests that update a dependency file

  
Epic

   
good first issue

   
hacktoberfest

Welcome to Hacktoberfest

  
help wanted

   
icebox

Long-term storage

  
level: 1

No knowledge of the existing code required

  
level: 2

Some knowledge of the existing code is recommended

  
level: 3

Significant knowledge of the existing code is recommended

  
level: 4

Intimate knowledge of the existing code is recommended

  
needs: exploration

Solution unclear, needs research

  
needs: grooming

Issue needs to be groomed before work can start

  
needs: priority

Priority level needs to be defined

  
needs: repro

Issue needs step-by-step instructions on how to reproduce in latest code

  
needs: tech design

Needs technical design signoff before implementation can begin

  
on hold

Temporarily paused

  
Osprey

Spee.ch special project

  
priority: blocker

Issue is blocking release, do ASAP

  
priority: high

Work needs to be moved into sprint ASAP

  
priority: low

Work should be done but can stay in the backlog for now

  
priority: medium

Work needs to be done within 2-3 sprints

  
protocol dependent

   
resilience

   
Tom's Wishlist

   
type: bug

Existing functionality is wrong or broken

  
type: discussion

A conversation. No specific changes requested

  
type: error handling

   
type: improvement

Existing (or partially existing) functionality needs to be changed

  
type: new feature

New functionality that does not exist yet

  
type: refactor

Minimal user-visible changes, but significant internal work

  
type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

  
type: testing

Solution needs additional user testing

  
unplanned

Work that was not planned into the spirnt, took priority over planned work

No labels
area: devops
area: discovery
area: docs
area: livestream
area: proposal
consider soon
dependencies
Epic
good first issue
hacktoberfest
help wanted
icebox
level: 1
level: 2
level: 3
level: 4
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
on hold
Osprey
priority: blocker
priority: high
priority: low
priority: medium
protocol dependent
resilience
Tom's Wishlist
type: bug
type: discussion
type: error handling
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/spee.ch#492
No description provided.
Delete branch "465-social-share-with-extensions"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?