Tor middleware #499

Merged

bones7242 merged 16 commits from tor-middleware into master

2018-06-29 02:59:56 +02:00

bones7242 commented

2018-06-28 22:18:27 +02:00

(Migrated from github.com)

added a table to be used to store tor node ips
added a middleware function which can be used to check request against tor node list

- added a table to be used to store tor node ips - added a middleware function which can be used to check request against tor node list

neb-b (Migrated from github.com) approved these changes 2018-06-28 23:40:39 +02:00

neb-b (Migrated from github.com) left a comment

One comment, not really sure which way it should go. It's probably fine how it is.

server/middleware/torCheckMiddleware.js

neb-b (Migrated from github.com) commented

2018-06-28 23:38:26 +02:00

Maybe you should just stop the request here? Not sure, if there are other routes in that may be blocked in the future it will be simpler to add. If it's gonna be only the /publish route then this is probably fine.

bones7242 (Migrated from github.com) reviewed 2018-06-29 02:22:01 +02:00

server/middleware/torCheckMiddleware.js

bones7242 (Migrated from github.com) commented

2018-06-29 02:22:00 +02:00

Yeah, I think that would be the better way to handle it. That way the middleware can be placed on any route and response is handled from the middleware, rather than having to handle in all the routes.

No reviewers

neb-b

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/spee.ch#499

No description provided.