505 twitter share undefined #508

2018-07-03T20:03:29+02:00

bones7242 commented

2018-07-03 20:03:29 +02:00

(Migrated from github.com)

fixes bug where 'undefined' was showing up in social links rather than the claim name

neb-b (Migrated from github.com) approved these changes 2018-07-03 21:32:03 +02:00

neb-b (Migrated from github.com) left a comment

One comment, I think that should work.

client/src/components/ClickToCopy/index.jsx

					
				@ -0,0 +7,4 @@

				  }

				  copyToClipboard (event) {

				    const elementToCopy = event.target.id;

				    const element = document.getElementById(elementToCopy);

neb-b (Migrated from github.com) commented

2018-07-03 21:31:30 +02:00

could this just be const element = event.target; ?

could this just be `const element = event.target;` ?

bones7242 (Migrated from github.com) reviewed 2018-07-04 00:02:06 +02:00

client/src/components/ClickToCopy/index.jsx

					
				@ -0,0 +7,4 @@

				  }

				  copyToClipboard (event) {

				    const elementToCopy = event.target.id;

				    const element = document.getElementById(elementToCopy);

bones7242 (Migrated from github.com) commented

2018-07-04 00:02:06 +02:00

I thought no, but the answer is yes :)

Sign in to join this conversation.

No reviewers

neb-b

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/spee.ch#508