493 twitter video #531

2018-07-17T19:33:20+02:00

bones7242 commented

2018-07-17 19:33:20 +02:00

(Migrated from github.com)

patch for twitter video embed issue

removes some dead handlebars code
removes X-Frame-Option header which was blocking twitter video embed

patch for twitter video embed issue - removes some dead handlebars code - removes X-Frame-Option header which was blocking twitter video embed

skhameneh (Migrated from github.com) approved these changes 2018-07-17 19:34:45 +02:00

index.js

					
				@ -89,3 +91,4 @@

				    app.set('views', viewsPath);

				    app.set('view engine', 'handlebars');

				    // set the routes on the app

skhameneh (Migrated from github.com) commented

2018-07-17 19:34:23 +02:00

what will it take to allow async?

bones7242 (Migrated from github.com) reviewed 2018-07-17 19:37:45 +02:00

index.js

					
				@ -89,3 +91,4 @@

				    app.set('views', viewsPath);

				    app.set('view engine', 'handlebars');

				    // set the routes on the app

bones7242 (Migrated from github.com) commented

2018-07-17 19:37:45 +02:00

hmm, I actually can't remember why I set it to false other than it was probably recommended in the express-handlebars implementation examples. I'll look into that.

hmm, I actually can't remember why I set it to `false` other than it was probably recommended in the `express-handlebars` implementation examples. I'll look into that.

Sign in to join this conversation.

No reviewers

skhameneh

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/spee.ch#531