add oEmbed support #546

Merged

bones7242 merged 16 commits from 358-oEmbed into master

2018-07-31 19:38:16 +02:00

bones7242 commented

(Migrated from github.com)

- added `<link />` tags via Helmet which include oEmbed url - added `api/oembed...` route for oEmbed requests

skhameneh (Migrated from github.com) reviewed 2018-07-31 17:09:56 +02:00

skhameneh (Migrated from github.com) commented

Do you have configs for the host URL generation?
That would be ideal over hardcoding

Do you have configs for the host URL generation? That would be ideal over hardcoding

skhameneh (Migrated from github.com) reviewed 2018-07-31 17:10:34 +02:00

skhameneh (Migrated from github.com) commented

Same, use config instead of hard-coding

skhameneh (Migrated from github.com) approved these changes 2018-07-31 17:14:50 +02:00

skhameneh (Migrated from github.com) left a comment

Minor comments

skhameneh (Migrated from github.com) commented

We should probably leave XML out until it's supported.

bones7242 (Migrated from github.com) reviewed 2018-07-31 18:24:47 +02:00

bones7242 (Migrated from github.com) commented

good catch. I meant to do this after testing and forgot.

No reviewers

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/spee.ch#546

No description provided.