498 incorrect short url #552

2018-08-03T01:12:09+02:00

bones7242 commented

2018-08-03 01:12:09 +02:00

(Migrated from github.com)

added a method to the Claim model to check for max height
updated Claim record creation on new publishes to use max height rather than 0

- added a method to the Claim model to check for max height - updated Claim record creation on new publishes to use max height rather than 0

skhameneh (Migrated from github.com) approved these changes 2018-08-03 01:31:56 +02:00

skhameneh (Migrated from github.com) left a comment

Minor comments

utils/lbryUri.js

					
				@ -0,0 +12,4 @@

				      .exec(identifier)

				      .map(match => match || null);

				    // Validate and process name

skhameneh (Migrated from github.com) commented

2018-08-03 01:31:38 +02:00

Remove extra comma

utils/lbryUri.js

					
				@ -0,0 +80,4 @@

				    // return results

				    return {

				      claimName,

				      extension: modifier || null,

skhameneh (Migrated from github.com) commented

2018-08-03 01:31:25 +02:00

Remove the extra comma

bones7242 (Migrated from github.com) reviewed 2018-08-03 01:35:53 +02:00

utils/lbryUri.js

					
				@ -0,0 +80,4 @@

				    // return results

				    return {

				      claimName,

				      extension: modifier || null,

bones7242 (Migrated from github.com) commented

2018-08-03 01:35:53 +02:00

I think it is necessary in order to ignore the first value when destructuring the returned array, right? Otherwise claimName becomes the proto.. etc.
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Destructuring_assignment

I think it is necessary in order to ignore the first value when destructuring the returned array, right? Otherwise claimName becomes the proto.. etc. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Destructuring_assignment

Sign in to join this conversation.

No reviewers

skhameneh

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/spee.ch#552