remove author metadata from publish #584

New issue

Closed

opened 2018-08-21 16:35:26 +02:00 by tzarebczan · 4 comments

tzarebczan commented

2018-08-21 16:35:26 +02:00

(Migrated from github.com)

We should not be using the author field, it was effectively replaced by channels.

{
  "21534854663612": {
    "claim": {
      "address": "bFFR9aqXaamuihY8mowejqHWHgyjktx2nm",
      "amount": 0.01,
      "claim_id": "064a6d2019d537521da5058b8f45746679344964",
      "claim_sequence": 1,
      "decoded_claim": true,
      "depth": 41,
      "effective_amount": 0.01,
      "has_signature": false,
      "height": 423596,
      "hex": "080110011a710801122a080410011a0e323135333438353436363336313222002a07537065652e636832012038004a0052005a001a41080110011a30835f9c9e9e19bc54d83c5d7a8d52e1ed55d707c7754f81c1e50f55c3a9b188bf795f2a5db38544455349371454edbc4f2209696d6167652f706e67",
      "name": "21534854663612",
      "nout": 0,
      "permanent_url": "21534854663612#064a6d2019d537521da5058b8f45746679344964",
      "supports": [],
      "txid": "34335c8a51257a6bb9c5ffa755c3ed52dbf35020cf6465f39056df4165ce4046",
      "value": {
        "claimType": "streamType",
        "stream": {
          "metadata": {
            "author": "Spee.ch",
            "description": "",
            "language": "en",
            "license": " ",
            "licenseUrl": "",
            "nsfw": false,
            "preview": "",
            "thumbnail": "",
            "title": "21534854663612",
            "version": "_0_1_0"
          },
          "source": {
            "contentType": "image/png",
            "source": "835f9c9e9e19bc54d83c5d7a8d52e1ed55d707c7754f81c1e50f55c3a9b188bf795f2a5db38544455349371454edbc4f",
            "sourceType": "lbry_sd_hash",
            "version": "_0_0_1"
          },
          "version": "_0_0_1"
        },
        "version": "_0_0_1"
      }
    }
  }
}

We should not be using the author field, it was effectively replaced by channels. ``` { "21534854663612": { "claim": { "address": "bFFR9aqXaamuihY8mowejqHWHgyjktx2nm", "amount": 0.01, "claim_id": "064a6d2019d537521da5058b8f45746679344964", "claim_sequence": 1, "decoded_claim": true, "depth": 41, "effective_amount": 0.01, "has_signature": false, "height": 423596, "hex": "080110011a710801122a080410011a0e323135333438353436363336313222002a07537065652e636832012038004a0052005a001a41080110011a30835f9c9e9e19bc54d83c5d7a8d52e1ed55d707c7754f81c1e50f55c3a9b188bf795f2a5db38544455349371454edbc4f2209696d6167652f706e67", "name": "21534854663612", "nout": 0, "permanent_url": "21534854663612#064a6d2019d537521da5058b8f45746679344964", "supports": [], "txid": "34335c8a51257a6bb9c5ffa755c3ed52dbf35020cf6465f39056df4165ce4046", "value": { "claimType": "streamType", "stream": { "metadata": { "author": "Spee.ch", "description": "", "language": "en", "license": " ", "licenseUrl": "", "nsfw": false, "preview": "", "thumbnail": "", "title": "21534854663612", "version": "_0_1_0" }, "source": { "contentType": "image/png", "source": "835f9c9e9e19bc54d83c5d7a8d52e1ed55d707c7754f81c1e50f55c3a9b188bf795f2a5db38544455349371454edbc4f", "sourceType": "lbry_sd_hash", "version": "_0_0_1" }, "version": "_0_0_1" }, "version": "_0_0_1" } } } } ```

tzarebczan commented

2018-08-28 20:24:59 +02:00

(Migrated from github.com)

depending on discussion in https://github.com/lbryio/lbry/pull/1368

jessopb commented

2019-02-25 08:46:14 +01:00

(Migrated from github.com)

According to #1368 author should be an editable field rather than the site title. (It's currently the siteConfig.details.title )
Edit title? @tzarebczan

According to #1368 author should be an editable field rather than the site title. (It's currently the siteConfig.details.title ) Edit title? @tzarebczan

tzarebczan commented

2019-03-08 06:42:38 +01:00

(Migrated from github.com)

Sounds like author is staying: a6f2fd6d5f/v2/proto/claim.proto (L33)

It's just a field in the metadata...it helps easily identify publishes from spee.ch. Could be good for other instances too, to show where the content was published from.

Sounds like author is staying: https://github.com/lbryio/types/blob/a6f2fd6d5f382f0012383b9076d650c1f6791ada/v2/proto/claim.proto#L33 It's just a field in the metadata...it helps easily identify publishes from spee.ch. Could be good for other instances too, to show where the content was published from.

tzarebczan commented

2019-03-30 05:56:24 +01:00

(Migrated from github.com)

Staying put for now...surprising considering how much @kauffj wanted it gone!! lol

This discussion has been locked. Commenting is limited to contributors.

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/spee.ch#584

No description provided.

Rows
Columns