Make configurable embeds #676

Merged

skhameneh merged 3 commits from embedConfig into master

2018-11-02 23:47:26 +01:00

skhameneh commented

2018-11-02 09:49:56 +01:00

(Migrated from github.com)

Works and is usable and ready to merge, still working on final touches.

e.g.:

http://localhost:3000/video-embed/jiggytom/3023ed665a45361626f70375db616af074f314ab/pad:large,bottom,logoClaim:252e3c5137c076d4ea0786c0d418e965b5c1e9cf%2Fantimedia-logo

Supports:

pad:{[small, medium, large]}
bottom
right
logoClaim:{claimId}%2F{claimName}
logoLink:{url}

Also has some player fixes to properly adjust sizing. This should provide a much better embed experience.

Works and is usable and ready to merge, still working on final touches. e.g.: ``` http://localhost:3000/video-embed/jiggytom/3023ed665a45361626f70375db616af074f314ab/pad:large,bottom,logoClaim:252e3c5137c076d4ea0786c0d418e965b5c1e9cf%2Fantimedia-logo ``` Supports: - pad:{[small, medium, large]} - bottom - right - logoClaim:{claimId}%2F{claimName} - logoLink:{url} Also has some player fixes to properly adjust sizing. This should provide a much better embed experience.

daovist (Migrated from github.com) approved these changes 2018-11-02 19:08:51 +01:00

No reviewers

daovist

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/spee.ch#676

No description provided.