moves sensitive keys to gitignored folder #747

Merged

jessopb merged 1 commit from sensitiveKeys into master

2018-11-30 16:45:46 +01:00

jessopb commented

2018-11-15 05:24:51 +01:00

(Migrated from github.com)

Old behavior: siteConfig had some sensitive passwords.
New behavior: passwords are stored in ./config which is gitignored.

Old behavior: siteConfig had some sensitive passwords. New behavior: passwords are stored in ./config which is gitignored.

skhameneh (Migrated from github.com) reviewed 2018-11-15 06:34:56 +01:00

skhameneh (Migrated from github.com) left a comment

Looks good

cli/configure.js

skhameneh (Migrated from github.com) commented

2018-11-15 06:34:45 +01:00

When we spoke, I may have said /config, which I meant /site/config in context.
We don't need a separate directory, but if we use one I would suggest using site/secrets.

When we spoke, I may have said `/config`, which I meant `/site/config` in context. We don't need a separate directory, but if we use one I would suggest using `site/secrets`.

jessopb (Migrated from github.com) reviewed 2018-11-15 17:10:42 +01:00

cli/configure.js

jessopb (Migrated from github.com) commented

2018-11-15 17:10:42 +01:00

Ok. What you said was literally true: The spee.ch repo's gitignore did indeed cover /config even though the folder didn't exist. Where would you like the gitignore for the site repo?

skhameneh (Migrated from github.com) approved these changes 2018-11-15 23:20:09 +01:00

skhameneh (Migrated from github.com) left a comment

Will need to update environments before merging/deploying

No reviewers

skhameneh

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/spee.ch#747

No description provided.