Fix SCSS overrides for site/custom #802

Merged

skhameneh merged 1 commit from fix-custom-css into master

2018-12-03 22:37:03 +01:00

skhameneh commented

2018-12-03 22:36:36 +01:00

(Migrated from github.com)

Few things:

sass-loader will only use aliases if a tilde, ~, is used.
Webpack only allows strings as aliases (not arrays)
Aliases/Resolves do not work with a SCSS file in the root path e.g. Can't use ~fileName.scss.
Webpack's resolve pipeline will be used for modules (directory name) even if there is no matching alias.

Few things: 1. `sass-loader` will only use aliases if a tilde, `~`, is used. 2. Webpack only allows strings as aliases (not arrays) 3. Aliases/Resolves do not work with a SCSS file in the root path e.g. Can't use `~fileName.scss`. 4. Webpack's resolve pipeline will be used for modules (directory name) even if there is no matching alias.

jessopb (Migrated from github.com) reviewed 2018-12-03 22:36:36 +01:00

kauffj commented

2018-12-03 23:37:48 +01:00

(Migrated from github.com)

Nice, thank you!

No reviewers

jessopb

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/spee.ch#802

No description provided.