bugfixes around display of permanentURIs #814

2018-12-07T03:41:18+01:00

jessopb commented

2018-12-07 03:41:18 +01:00

(Migrated from github.com)

previous behavior:

AssetInfo PermanentURLs for anonymous publishes was broken.
Edit claim message "Editing lbry:// had a malformed url.

new behavior:

buildURI has been renamed to createPermanentURI to be consistent with lbrynet output.
buildURI has been modified to return proper strings for permanent URIs for both anonymous and channeled claims.
PublishTools message "editing lbry://abcd" now displays a link text that actually works.
AssetInfo displays and uses proper permanent URIs for both anonymous and channeled claims.
@clientutils alias was added to remove confusion about ../../../../../../utils.

previous behavior: - AssetInfo PermanentURLs for anonymous publishes was broken. - Edit claim message "Editing lbry:// had a malformed url. new behavior: - buildURI has been renamed to createPermanentURI to be consistent with lbrynet output. - buildURI has been modified to return proper strings for permanent URIs for both anonymous and channeled claims. - PublishTools message "editing lbry://abcd" now displays a link text that actually works. - AssetInfo displays and uses proper permanent URIs for both anonymous and channeled claims. - @clientutils alias was added to remove confusion about ../../../../../../utils.

skhameneh (Migrated from github.com) approved these changes 2018-12-07 03:57:20 +01:00

utils/createModuleAliases.js

					
				@ -35,2 +35,4 @@

				  moduleAliases['@private'] = resolve('site/private');

				  // aliases for utils

				  moduleAliases['@globalutils'] = resolve('utils');

skhameneh (Migrated from github.com) commented

2018-12-07 03:57:07 +01:00

I would suggest renaming to something like @rootUtils

I would suggest renaming to something like `@rootUtils`

Sign in to join this conversation.

No reviewers

skhameneh

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/spee.ch#814