makes enhancements to dmca system #851

Merged
jessopb merged 2 commits from dmca into master 2019-01-08 00:06:10 +01:00
jessopb commented 2019-01-01 03:36:20 +01:00 (Migrated from github.com)

Visiting a content page shows an AssetBlocked component.
Visiting a component page still attempts to fetch() the file in order to elicit the 451 error.
I didn't want to send a 451 on document because document generally doesn't reload during normal navigation, and the document hangs on to the status throughout browsing. (This is also an issue for the 404).
Visiting a Channel page, until we redo pagination, Blocked content shows a customized 451 channel preview.
Blocklist is now in memory in a javascript Set() though I noticed no speed gains compared to local DB.
Blocklist Endpoint is now a configurable siteConfig.json -> details -> blockListEndpoint : "" parameter.
LBRY's blocklist is still the default configuration if blockListEndpoint is missing or null.

  • three states of blockListEndpoint tested:
    • api-url
    • "" empty string
    • null => defaults to api-url

Blocklist Set() updates from database every 60 seconds, in preparation for periodic database updates in the future.
Some extraneous .then()s in promise chains removed.
See slack channel for test url.

Visiting a content page shows an AssetBlocked component. Visiting a component page still attempts to fetch() the file in order to elicit the 451 error. I didn't want to send a 451 on document because document generally doesn't reload during normal navigation, and the document hangs on to the status throughout browsing. (This is also an issue for the 404). Visiting a Channel page, until we redo pagination, Blocked content shows a customized 451 channel preview. Blocklist is now in memory in a javascript Set() though I noticed no speed gains compared to local DB. Blocklist Endpoint is now a configurable siteConfig.json -> details -> blockListEndpoint : "" parameter. LBRY's blocklist is still the default configuration if blockListEndpoint is missing or null. - three states of blockListEndpoint tested: - api-url - "" empty string - null => defaults to api-url Blocklist Set() updates from database every 60 seconds, in preparation for periodic database updates in the future. Some extraneous .then()s in promise chains removed. See slack channel for test url.
skhameneh (Migrated from github.com) approved these changes 2019-01-03 03:39:19 +01:00
skhameneh (Migrated from github.com) left a comment

Looks good at first glance, I'll revisit as well

Looks good at first glance, I'll revisit as well
@ -0,0 +1,58 @@
import React from 'react';
import createCanonicalLink from '../../../../utils/createCanonicalLink';
skhameneh (Migrated from github.com) commented 2019-01-03 02:34:41 +01:00

We should have a shorter alias for this that you can use

We should have a shorter alias for this that you can use
skhameneh commented 2019-01-03 03:41:34 +01:00 (Migrated from github.com)

When you're ready, merge to master, cut to staging, and have us (including @tzarebczan) test this.

When you're ready, merge to master, cut to staging, and have us (including @tzarebczan) test this.
jessopb (Migrated from github.com) reviewed 2019-01-08 00:05:40 +01:00
@ -0,0 +1,58 @@
import React from 'react';
import createCanonicalLink from '../../../../utils/createCanonicalLink';
jessopb (Migrated from github.com) commented 2019-01-08 00:05:40 +01:00

I'll do a pass of alias insertion soon.

I'll do a pass of alias insertion soon.
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/spee.ch#851
No description provided.