some thumbnails show broken on initial channel load #863

New issue

Open

opened 2019-01-09 03:48:01 +01:00 by jessopb · 3 comments

jessopb commented

2019-01-09 03:48:01 +01:00

(Migrated from github.com)

When loading a channel the speech instance has not loaded before, thumbnails are hit and miss, and show up broken.

jessopb commented

2019-01-19 20:24:37 +01:00

(Migrated from github.com)

getClaimAndServeAsset() asks local db.File for a fileRecord, which fails on first request. It sets NO_FILE which causes 307 redirect to api/claim/get{$claimName}/${claimId}).
claimGet() completes the get and returns success, but the NO_FILE error never actually tries serveAsset after initiating claimGet().

`getClaimAndServeAsset()` asks local db.File for a fileRecord, which fails on first request. It sets NO_FILE which causes 307 redirect to api/claim/get{$claimName}/${claimId}). claimGet() completes the get and returns success, but the NO_FILE error never actually tries serveAsset after initiating claimGet().

jessopb commented

2019-01-19 21:41:20 +01:00

(Migrated from github.com)

For images, we're using the actual claim (embedUrl), rather than the external thumbnail url, which means that showing even the channel page means downloading all claims that are images in that channel. This will have to be checked against pagination: A channel with 1000 images could pose a problem if it gets all of them at once.

jessopb commented

2019-03-08 08:45:17 +01:00

(Migrated from github.com)

I have some concern whether it's wise to implement the "get all image claims on this page" solution before connection management is in the sdk. We may just ensure a default thumbnail (rather than a broken one) is displayed, for now. Comments?

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/spee.ch#863

No description provided.