LBRYCommunity/spee.ch
1
0
Fork 0
Code Issues 95 Pull requests 2 Projects Releases 4 Packages Wiki Activity

styling, markdown settings tied to config #906

Merged
jessopb merged 1 commit from mdhtml2 into master 2019-02-16 22:10:42 +01:00
Conversation 1 Commits 1 Files changed 8 +367 -139
jessopb commented 2019-02-09 06:00:03 +01:00 (Migrated from github.com)
Copy link

links markdown settings to siteConfig
fixes some styling

links markdown settings to siteConfig fixes some styling
skhameneh (Migrated from github.com) requested changes 2019-02-11 03:34:58 +01:00
client/src/components/FileViewer/index.jsx
skhameneh (Migrated from github.com) commented 2019-02-11 03:34:52 +01:00
Copy link

This change is very dangerous, can you make a list of what is whitelisted?

Blacklists are not safe when it comes to script injection.

This change is **very** dangerous, can you make a list of what is **whitelisted**? Blacklists are not safe when it comes to script injection.
jessopb (Migrated from github.com) reviewed 2019-02-13 23:24:13 +01:00
client/src/components/FileViewer/index.jsx
jessopb (Migrated from github.com) commented 2019-02-13 23:24:13 +01:00
Copy link

It is now a very long whitelist :)

It is now a very long whitelist :)
skhameneh (Migrated from github.com) reviewed 2019-02-14 22:25:43 +01:00
cli/defaults/siteConfig.json
@ -49,4 +39,3 @@
},
"maxSizeImage": 10000000,
"maxSizeGif": 50000000,
"maxSizeVideo": 50000000
skhameneh (Migrated from github.com) commented 2019-02-14 22:25:37 +01:00
Copy link

I took a closer look, set this to true and make sure it's documented as a dangerous setting.
I don't want users deploying making mistakes, this needs to be explicitly true on all our instances that allow public content.

I took a closer look, set this to `true` and make sure it's documented as a dangerous setting. I don't want users deploying making mistakes, this needs to be explicitly `true` on all our instances that allow public content.
jessopb commented 2019-02-15 07:16:03 +01:00 (Migrated from github.com)
Copy link

I made the changes you requested. Also added an ErrorBoundary component to the FileViewer component to prevent it from crashing the app.

I made the changes you requested. Also added an ErrorBoundary component to the FileViewer component to prevent it from crashing the app.
skhameneh (Migrated from github.com) approved these changes 2019-02-15 17:09:15 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
skhameneh
Labels
Clear labels   
area: devops

   
area: discovery

   
area: docs

   
area: livestream

   
area: proposal

Work is part of a proposal

  
consider soon

Discuss this issue at the next planning meeting, then remove this label

  
dependencies

Pull requests that update a dependency file

  
Epic

   
good first issue

   
hacktoberfest

Welcome to Hacktoberfest

  
help wanted

   
icebox

Long-term storage

  
level: 1

No knowledge of the existing code required

  
level: 2

Some knowledge of the existing code is recommended

  
level: 3

Significant knowledge of the existing code is recommended

  
level: 4

Intimate knowledge of the existing code is recommended

  
needs: exploration

Solution unclear, needs research

  
needs: grooming

Issue needs to be groomed before work can start

  
needs: priority

Priority level needs to be defined

  
needs: repro

Issue needs step-by-step instructions on how to reproduce in latest code

  
needs: tech design

Needs technical design signoff before implementation can begin

  
on hold

Temporarily paused

  
Osprey

Spee.ch special project

  
priority: blocker

Issue is blocking release, do ASAP

  
priority: high

Work needs to be moved into sprint ASAP

  
priority: low

Work should be done but can stay in the backlog for now

  
priority: medium

Work needs to be done within 2-3 sprints

  
protocol dependent

   
resilience

   
Tom's Wishlist

   
type: bug

Existing functionality is wrong or broken

  
type: discussion

A conversation. No specific changes requested

  
type: error handling

   
type: improvement

Existing (or partially existing) functionality needs to be changed

  
type: new feature

New functionality that does not exist yet

  
type: refactor

Minimal user-visible changes, but significant internal work

  
type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

  
type: testing

Solution needs additional user testing

  
unplanned

Work that was not planned into the spirnt, took priority over planned work

No labels
area: devops
area: discovery
area: docs
area: livestream
area: proposal
consider soon
dependencies
Epic
good first issue
hacktoberfest
help wanted
icebox
level: 1
level: 2
level: 3
level: 4
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
on hold
Osprey
priority: blocker
priority: high
priority: low
priority: medium
protocol dependent
resilience
Tom's Wishlist
type: bug
type: discussion
type: error handling
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/spee.ch#906
No description provided.
Delete branch "mdhtml2"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?