Adds License and LicenseUrl to AssetInfo and Publish/Edit Forms #935

Merged

jessopb merged 3 commits from licenseDev2 into master

2019-02-26 09:44:03 +01:00

jessopb commented

2019-02-24 09:01:21 +01:00

(Migrated from github.com)

Adds license, and if url, licenseUrl as a link to assetInfo.
Adds licenseUrl and license to chainquery model
Adds licenseUrl to publish / edit form.
Populates license and licenseUrl from previous publish state
Tweaks select style

Adds license, and if url, licenseUrl as a link to assetInfo. Adds licenseUrl and license to chainquery model Adds licenseUrl to publish / edit form. Populates license and licenseUrl from previous publish state Tweaks select style

skhameneh (Migrated from github.com) approved these changes 2019-02-26 06:54:51 +01:00

client/src/components/PublishLicenseInput/index.jsx

skhameneh (Migrated from github.com) commented

2019-02-26 06:50:18 +01:00

We should have a more suitable alias to use instead of the ../../

We should have a more suitable alias to use instead of the `../../`

client/src/components/PublishLicenseUrlInput/index.jsx

skhameneh (Migrated from github.com) commented

2019-02-26 06:50:29 +01:00

alias

client/src/containers/AssetInfo/view.jsx

skhameneh (Migrated from github.com) commented

2019-02-26 06:51:09 +01:00

If you break this line into multiple lines, will the linter allow it? If not, please ping me

server/controllers/api/claim/publish/createPublishParams.js

skhameneh (Migrated from github.com) commented

2019-02-26 06:53:14 +01:00

probably don't need the // default to empty string comments, can clean up.

I would suggest using something like:

licenseUrl = licenseUrl === null ? '' : licenseUrl.trim();

probably don't need the `// default to empty string` comments, can clean up. I would suggest using something like: ``` licenseUrl = licenseUrl === null ? '' : licenseUrl.trim(); ```

server/controllers/api/claim/publish/index.js

skhameneh (Migrated from github.com) commented

2019-02-26 06:53:38 +01:00

Would you mind cleaning up this path while you're here?

server/controllers/api/claim/publish/index.js

skhameneh (Migrated from github.com) commented

2019-02-26 06:54:32 +01:00

Can also format as .catch(() => claimId.slice(0, 1))

Can also format as `.catch(() => claimId.slice(0, 1))`