Upload refactor #242

Merged
bones7242 merged 24 commits from upload-refactor into master 2017-11-13 21:39:21 +01:00
Showing only changes of commit c881d7c64b - Show all commits

View file

@ -1,23 +1,22 @@
kauffj commented 2017-11-10 18:24:47 +01:00 (Migrated from github.com)
Review

A more common convention for this is probably speechConfig.example.js or speechConfig.js.example.

A more common convention for this is probably `speechConfig.example.js` or `speechConfig.js.example`.
bones7242 commented 2017-11-13 20:25:03 +01:00 (Migrated from github.com)
Review

I like speechConfig.js.example

I like `speechConfig.js.example`
kauffj commented 2017-11-10 18:24:47 +01:00 (Migrated from github.com)
Review

A more common convention for this is probably speechConfig.example.js or speechConfig.js.example.

A more common convention for this is probably `speechConfig.example.js` or `speechConfig.js.example`.
bones7242 commented 2017-11-13 20:25:03 +01:00 (Migrated from github.com)
Review

I like speechConfig.js.example

I like `speechConfig.js.example`
module.exports = {
wallet: {
lbryClaimAddress: null,
kauffj commented 2017-11-10 18:24:47 +01:00 (Migrated from github.com)
Review

A more common convention for this is probably speechConfig.example.js or speechConfig.js.example.

A more common convention for this is probably `speechConfig.example.js` or `speechConfig.js.example`.
bones7242 commented 2017-11-13 20:25:03 +01:00 (Migrated from github.com)
Review

I like speechConfig.js.example

I like `speechConfig.js.example`
defaultChannel : null,
kauffj commented 2017-11-10 18:24:47 +01:00 (Migrated from github.com)
Review

A more common convention for this is probably speechConfig.example.js or speechConfig.js.example.

A more common convention for this is probably `speechConfig.example.js` or `speechConfig.js.example`.
bones7242 commented 2017-11-13 20:25:03 +01:00 (Migrated from github.com)
Review

I like speechConfig.js.example

I like `speechConfig.js.example`
lbryClaimAddress: null, // choose an address from your lbry wallet
kauffj commented 2017-11-10 18:24:47 +01:00 (Migrated from github.com)
Review

A more common convention for this is probably speechConfig.example.js or speechConfig.js.example.

A more common convention for this is probably `speechConfig.example.js` or `speechConfig.js.example`.
bones7242 commented 2017-11-13 20:25:03 +01:00 (Migrated from github.com)
Review

I like speechConfig.js.example

I like `speechConfig.js.example`
},
analytics: {
googleId: null,
kauffj commented 2017-11-10 18:24:47 +01:00 (Migrated from github.com)
Review

A more common convention for this is probably speechConfig.example.js or speechConfig.js.example.

A more common convention for this is probably `speechConfig.example.js` or `speechConfig.js.example`.
bones7242 commented 2017-11-13 20:25:03 +01:00 (Migrated from github.com)
Review

I like speechConfig.js.example

I like `speechConfig.js.example`
googleId: null, // google id for analytics tracking; leave `null` if not applicable
kauffj commented 2017-11-10 18:24:47 +01:00 (Migrated from github.com)
Review

A more common convention for this is probably speechConfig.example.js or speechConfig.js.example.

A more common convention for this is probably `speechConfig.example.js` or `speechConfig.js.example`.
bones7242 commented 2017-11-13 20:25:03 +01:00 (Migrated from github.com)
Review

I like speechConfig.js.example

I like `speechConfig.js.example`
},
sql: {
database: 'lbry',
kauffj commented 2017-11-10 18:24:47 +01:00 (Migrated from github.com)
Review

A more common convention for this is probably speechConfig.example.js or speechConfig.js.example.

A more common convention for this is probably `speechConfig.example.js` or `speechConfig.js.example`.
bones7242 commented 2017-11-13 20:25:03 +01:00 (Migrated from github.com)
Review

I like speechConfig.js.example

I like `speechConfig.js.example`
username: null,
kauffj commented 2017-11-10 18:24:47 +01:00 (Migrated from github.com)
Review

A more common convention for this is probably speechConfig.example.js or speechConfig.js.example.

A more common convention for this is probably `speechConfig.example.js` or `speechConfig.js.example`.
bones7242 commented 2017-11-13 20:25:03 +01:00 (Migrated from github.com)
Review

I like speechConfig.js.example

I like `speechConfig.js.example`
password: null,
kauffj commented 2017-11-10 18:24:47 +01:00 (Migrated from github.com)
Review

A more common convention for this is probably speechConfig.example.js or speechConfig.js.example.

A more common convention for this is probably `speechConfig.example.js` or `speechConfig.js.example`.
bones7242 commented 2017-11-13 20:25:03 +01:00 (Migrated from github.com)
Review

I like speechConfig.js.example

I like `speechConfig.js.example`
database: null, // name of mysql database
kauffj commented 2017-11-10 18:24:47 +01:00 (Migrated from github.com)
Review

A more common convention for this is probably speechConfig.example.js or speechConfig.js.example.

A more common convention for this is probably `speechConfig.example.js` or `speechConfig.js.example`.
bones7242 commented 2017-11-13 20:25:03 +01:00 (Migrated from github.com)
Review

I like speechConfig.js.example

I like `speechConfig.js.example`
username: null, // username for mysql
kauffj commented 2017-11-10 18:24:47 +01:00 (Migrated from github.com)
Review

A more common convention for this is probably speechConfig.example.js or speechConfig.js.example.

A more common convention for this is probably `speechConfig.example.js` or `speechConfig.js.example`.
bones7242 commented 2017-11-13 20:25:03 +01:00 (Migrated from github.com)
Review

I like speechConfig.js.example

I like `speechConfig.js.example`
password: null, // password for mysql
kauffj commented 2017-11-10 18:24:47 +01:00 (Migrated from github.com)
Review

A more common convention for this is probably speechConfig.example.js or speechConfig.js.example.

A more common convention for this is probably `speechConfig.example.js` or `speechConfig.js.example`.
bones7242 commented 2017-11-13 20:25:03 +01:00 (Migrated from github.com)
Review

I like speechConfig.js.example

I like `speechConfig.js.example`
},
logging: {
logLevel : null,
kauffj commented 2017-11-10 18:24:47 +01:00 (Migrated from github.com)
Review

A more common convention for this is probably speechConfig.example.js or speechConfig.js.example.

A more common convention for this is probably `speechConfig.example.js` or `speechConfig.js.example`.
bones7242 commented 2017-11-13 20:25:03 +01:00 (Migrated from github.com)
Review

I like speechConfig.js.example

I like `speechConfig.js.example`
slackWebHook : null,
kauffj commented 2017-11-10 18:24:47 +01:00 (Migrated from github.com)
Review

A more common convention for this is probably speechConfig.example.js or speechConfig.js.example.

A more common convention for this is probably `speechConfig.example.js` or `speechConfig.js.example`.
bones7242 commented 2017-11-13 20:25:03 +01:00 (Migrated from github.com)
Review

I like speechConfig.js.example

I like `speechConfig.js.example`
slackErrorChannel: null,
kauffj commented 2017-11-10 18:24:47 +01:00 (Migrated from github.com)
Review

A more common convention for this is probably speechConfig.example.js or speechConfig.js.example.

A more common convention for this is probably `speechConfig.example.js` or `speechConfig.js.example`.
bones7242 commented 2017-11-13 20:25:03 +01:00 (Migrated from github.com)
Review

I like speechConfig.js.example

I like `speechConfig.js.example`
slackInfoChannel : null,
kauffj commented 2017-11-10 18:24:47 +01:00 (Migrated from github.com)
Review

A more common convention for this is probably speechConfig.example.js or speechConfig.js.example.

A more common convention for this is probably `speechConfig.example.js` or `speechConfig.js.example`.
bones7242 commented 2017-11-13 20:25:03 +01:00 (Migrated from github.com)
Review

I like speechConfig.js.example

I like `speechConfig.js.example`
logLevel : null, // options: silly, debug, verbose, info
kauffj commented 2017-11-10 18:24:47 +01:00 (Migrated from github.com)
Review

A more common convention for this is probably speechConfig.example.js or speechConfig.js.example.

A more common convention for this is probably `speechConfig.example.js` or `speechConfig.js.example`.
bones7242 commented 2017-11-13 20:25:03 +01:00 (Migrated from github.com)
Review

I like speechConfig.js.example

I like `speechConfig.js.example`
slackWebHook : null, // enter a webhook if you wish to push logs to slack; otherwise leave as `null`
kauffj commented 2017-11-10 18:24:47 +01:00 (Migrated from github.com)
Review

A more common convention for this is probably speechConfig.example.js or speechConfig.js.example.

A more common convention for this is probably `speechConfig.example.js` or `speechConfig.js.example`.
bones7242 commented 2017-11-13 20:25:03 +01:00 (Migrated from github.com)
Review

I like speechConfig.js.example

I like `speechConfig.js.example`
slackErrorChannel: null, // enter a slack channel (#example) for errors to be sent to; otherwise leave null
kauffj commented 2017-11-10 18:24:47 +01:00 (Migrated from github.com)
Review

A more common convention for this is probably speechConfig.example.js or speechConfig.js.example.

A more common convention for this is probably `speechConfig.example.js` or `speechConfig.js.example`.
bones7242 commented 2017-11-13 20:25:03 +01:00 (Migrated from github.com)
Review

I like speechConfig.js.example

I like `speechConfig.js.example`
slackInfoChannel : null, // enter a slack channel (#info) for info level logs to be sent to otherwise leave null
kauffj commented 2017-11-10 18:24:47 +01:00 (Migrated from github.com)
Review

A more common convention for this is probably speechConfig.example.js or speechConfig.js.example.

A more common convention for this is probably `speechConfig.example.js` or `speechConfig.js.example`.
bones7242 commented 2017-11-13 20:25:03 +01:00 (Migrated from github.com)
Review

I like speechConfig.js.example

I like `speechConfig.js.example`
},
session: {
sessionKey: null,
kauffj commented 2017-11-10 18:24:47 +01:00 (Migrated from github.com)
Review

A more common convention for this is probably speechConfig.example.js or speechConfig.js.example.

A more common convention for this is probably `speechConfig.example.js` or `speechConfig.js.example`.
bones7242 commented 2017-11-13 20:25:03 +01:00 (Migrated from github.com)
Review

I like speechConfig.js.example

I like `speechConfig.js.example`
sessionKey: null, // enter a secret key to be used for session encryption
kauffj commented 2017-11-10 18:24:47 +01:00 (Migrated from github.com)
Review

A more common convention for this is probably speechConfig.example.js or speechConfig.js.example.

A more common convention for this is probably `speechConfig.example.js` or `speechConfig.js.example`.
bones7242 commented 2017-11-13 20:25:03 +01:00 (Migrated from github.com)
Review

I like speechConfig.js.example

I like `speechConfig.js.example`
},
};

kauffj commented 2017-11-10 18:24:47 +01:00 (Migrated from github.com)
Review

A more common convention for this is probably speechConfig.example.js or speechConfig.js.example.

A more common convention for this is probably `speechConfig.example.js` or `speechConfig.js.example`.
bones7242 commented 2017-11-13 20:25:03 +01:00 (Migrated from github.com)
Review

I like speechConfig.js.example

I like `speechConfig.js.example`
kauffj commented 2017-11-10 18:24:47 +01:00 (Migrated from github.com)
Review

A more common convention for this is probably speechConfig.example.js or speechConfig.js.example.

A more common convention for this is probably `speechConfig.example.js` or `speechConfig.js.example`.
bones7242 commented 2017-11-13 20:25:03 +01:00 (Migrated from github.com)
Review

I like speechConfig.js.example

I like `speechConfig.js.example`