React/Redux - publish component #323

Merged
bones7242 merged 80 commits from react-upload into master 2018-01-25 22:43:20 +01:00
7 changed files with 80 additions and 64 deletions
Showing only changes of commit 1461a8b494 - Show all commits

View file

@ -1 +0,0 @@
const EMAIL_FORMAT = 'ERROR_EMAIL_FORMAT';

View file

@ -1,2 +0,0 @@

View file

@ -39,27 +39,6 @@ function postRequest (url, params) {
}) })
kauffj commented 2018-01-22 19:36:32 +01:00 (Migrated from github.com)
Review

This probably should not be a string based check.

This probably should not be a string based check.
} }
function toggleSection(event){
event.preventDefault();
var dataSet = event.target.dataset;
var status = dataSet.open;
var masterElement = document.getElementById(event.target.id||event.srcElement.id);
var slaveElement = document.getElementById(dataSet.slaveelementid);
var closedLabel = dataSet.closedlabel;
var openLabel = dataSet.openlabel;
if (status === "false") {
slaveElement.hidden = false;
masterElement.innerText = openLabel;
masterElement.dataset.open = "true";
} else {
slaveElement.hidden = true;
masterElement.innerText = closedLabel;
masterElement.dataset.open = "false";
}
}
function createProgressBar(element, size){ function createProgressBar(element, size){
var x = 0; var x = 0;
var adder = 1; var adder = 1;

View file

@ -1,37 +0,0 @@
var stagedFiles = null;
const publishFileFunctions = {
// Validate the publish submission and then trigger upload
showUploadStartedMessage: function (){
console.log('starting upload');
// hide the publish tool
this.hidePublishTools();
// show the progress status and animation
this.showPublishStatus();
this.showPublishProgressBar();
},
showUploadProgressMessage: function (percentage){
this.updatePublishStatus('<p>File is loading to server</p>');
this.updateUploadPercent('<p class="blue">' + percentage + '% </p>');
},
showFilePublishUpdate: function (msg) {
this.updatePublishStatus('<p>' + msg + '</p>');
this.updateUploadPercent('<p>Curious what magic is happening here? <a class="link--primary" target="blank" href="https://lbry.io/faq/what-is-lbry">Learn more.</a></p>');
},
showFilePublishFailure: function (msg){
this.updatePublishStatus('<p>Something went wrong...</p><p><strong>' + msg + '</strong></p><p>For help, post the above error text in the #speech channel on the <a class="link--primary" href="https://discord.gg/YjYbwhS" target="_blank">lbry discord</a>');
this.hidePublishProgressBar();
this.hideUploadPercent();
},
showFilePublishComplete: function (msg) {
console.log('Publish complete!');
const showUrl = msg.lbryTx.claim_id + "/" + msg.name;
// update status
this.updatePublishStatus('<p>Your publish is complete! You are being redirected to it now.</p>');
this.updateUploadPercent('<p><a class="link--primary" target="_blank" href="' + showUrl + '">If you do not get redirected, click here.</a></p>')
// redirect the user
window.location.href = showUrl;
},
}

View file

@ -0,0 +1,76 @@
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
import React from 'react';
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
function ActiveBar () {
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
return <span className="progress-bar progress-bar--active">| </span>;
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
}
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
function InactiveBar () {
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
return <span className="progress-bar progress-bar--inactive">| </span>;
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
}
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
class ProgressBar extends React.Component {
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
constructor (props) {
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
super(props);
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
this.state = {
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
size : 12,
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
bars : [],
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
index : 0,
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
incrementer: 1,
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
};
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
this.startProgressBar = this.startProgressBar.bind(this);
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
this.updateProgressBar = this.updateProgressBar.bind(this);
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
this.stopProgressBar = this.stopProgressBar.bind(this);
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
}
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
componentWillMount () {
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
const bars = [];
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
for (let i = 0; i <= this.state.size; i++) {
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
bars.push(<InactiveBar key={i} />);
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
}
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
this.setState({ bars });
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
}
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
componentWillUnmount () {
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
this.stopProgressBar();
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
}
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
componentDidMount () {
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
this.startProgressBar();
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
}
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
startProgressBar () {
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
this.updateInterval = setInterval(this.updateProgressBar.bind(this), 300);
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
};
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
updateProgressBar () {
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
let index = this.state.index;
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
let incrementer = this.state.incrementer;
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
let bars = this.state.bars;
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
// flip incrementer if necessary, to stay in bounds
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
if ((index < 0) || (index > this.state.size)) {
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
incrementer = incrementer * -1;
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
index += incrementer;
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
}
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
// update the indexed value
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
if (incrementer > 0) {
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
bars[index] = <ActiveBar key={index} />;
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
} else {
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
bars[index] = <InactiveBar key={index} />;
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
};
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
// increment index
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
index += incrementer;
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
// update state
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
this.setState({
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
bars,
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
incrementer,
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
index,
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
});
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
};
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
stopProgressBar () {
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
clearInterval(this.updateInterval);
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
};
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
render () {
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
return (
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
<div>
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
{this.state.bars}
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
</div>
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
);
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
}
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
};
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
export default ProgressBar;
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars

View file

@ -1,4 +1,5 @@
import React from 'react'; import React from 'react';
import ProgressBar from '../components/ProgressBar.jsx';
const LOAD_START = 'LOAD_START'; const LOAD_START = 'LOAD_START';
const LOADING = 'LOADING'; const LOADING = 'LOADING';
@ -26,7 +27,7 @@ function PublishStatus ({ status, message }) {
{(status === PUBLISHING) && {(status === PUBLISHING) &&
<div className="row align-content-center"> <div className="row align-content-center">
<p>Upload complete. Your file is now being published on the blockchain...</p> <p>Upload complete. Your file is now being published on the blockchain...</p>
<p>PROGRESS BAR HERE</p> <ProgressBar/>
<p>Curious what magic is happening here? <a className="link--primary" target="blank" href="https://lbry.io/faq/what-is-lbry">Learn more.</a></p> <p>Curious what magic is happening here? <a className="link--primary" target="blank" href="https://lbry.io/faq/what-is-lbry">Learn more.</a></p>
</div> </div>
} }

View file

@ -1,5 +1,5 @@
import React from 'react'; import React from 'react';
import PreviewDropzone from './Dropzone.jsx'; import Dropzone from './Dropzone.jsx';
import PublishForm from './PublishForm.jsx'; import PublishForm from './PublishForm.jsx';
import PublishStatus from '../components/PublishStatus.jsx'; import PublishStatus from '../components/PublishStatus.jsx';
import {connect} from 'react-redux'; import {connect} from 'react-redux';
@ -18,7 +18,7 @@ class PublishTool extends React.Component {
return <PublishForm />; return <PublishForm />;
} }
} else { } else {
return <PreviewDropzone />; return <Dropzone />;
} }
} }
}; };