LBRYCommunity/spee.ch
1
0
Fork 0
Code Issues 95 Pull requests 2 Projects Releases 4 Packages Wiki Activity

React/Redux - publish component #323

Merged
bones7242 merged 80 commits from react-upload into master 2018-01-25 22:43:20 +01:00
Conversation 1 Commits 80 Files changed 82 -22
1 changed files with 0 additions and 22 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 6931628595 - Show all commits

22
react/utils/page.js
View file

@ -1,22 +0,0 @@
kauffj commented 2018-01-15 20:26:37 +01:00 (Migrated from github.com)
Review
Copy link

Shouldn't this design be obviated by addition of React/Redux? The component should be able to refresh based on external state change

Shouldn't this design be obviated by addition of React/Redux? The component should be able to refresh based on external state change
bones7242 commented 2018-01-18 23:25:06 +01:00 (Migrated from github.com)
Review
Copy link

The reason for this was that html outside of the react publish component (the top nav bar) needed to be updated. To solve this, I added a nav bar component that can draw from the store.

The reason for this was that html outside of the react publish component (the top nav bar) needed to be updated. To solve this, I added a nav bar component that can draw from the store.
kauffj commented 2018-01-15 20:26:37 +01:00 (Migrated from github.com)
Review
Copy link

Shouldn't this design be obviated by addition of React/Redux? The component should be able to refresh based on external state change

Shouldn't this design be obviated by addition of React/Redux? The component should be able to refresh based on external state change
bones7242 commented 2018-01-18 23:25:06 +01:00 (Migrated from github.com)
Review
Copy link

The reason for this was that html outside of the react publish component (the top nav bar) needed to be updated. To solve this, I added a nav bar component that can draw from the store.

The reason for this was that html outside of the react publish component (the top nav bar) needed to be updated. To solve this, I added a nav bar component that can draw from the store.
module.exports = {
kauffj commented 2018-01-15 20:26:37 +01:00 (Migrated from github.com)
Review
Copy link

Shouldn't this design be obviated by addition of React/Redux? The component should be able to refresh based on external state change

Shouldn't this design be obviated by addition of React/Redux? The component should be able to refresh based on external state change
bones7242 commented 2018-01-18 23:25:06 +01:00 (Migrated from github.com)
Review
Copy link

The reason for this was that html outside of the react publish component (the top nav bar) needed to be updated. To solve this, I added a nav bar component that can draw from the store.

The reason for this was that html outside of the react publish component (the top nav bar) needed to be updated. To solve this, I added a nav bar component that can draw from the store.
replaceChannelSelectionInNavBar (loggedInChannel) {
kauffj commented 2018-01-15 20:26:37 +01:00 (Migrated from github.com)
Review
Copy link

Shouldn't this design be obviated by addition of React/Redux? The component should be able to refresh based on external state change

Shouldn't this design be obviated by addition of React/Redux? The component should be able to refresh based on external state change
bones7242 commented 2018-01-18 23:25:06 +01:00 (Migrated from github.com)
Review
Copy link

The reason for this was that html outside of the react publish component (the top nav bar) needed to be updated. To solve this, I added a nav bar component that can draw from the store.

The reason for this was that html outside of the react publish component (the top nav bar) needed to be updated. To solve this, I added a nav bar component that can draw from the store.
// remove the old channel option
kauffj commented 2018-01-15 20:26:37 +01:00 (Migrated from github.com)
Review
Copy link

Shouldn't this design be obviated by addition of React/Redux? The component should be able to refresh based on external state change

Shouldn't this design be obviated by addition of React/Redux? The component should be able to refresh based on external state change
bones7242 commented 2018-01-18 23:25:06 +01:00 (Migrated from github.com)
Review
Copy link

The reason for this was that html outside of the react publish component (the top nav bar) needed to be updated. To solve this, I added a nav bar component that can draw from the store.

The reason for this was that html outside of the react publish component (the top nav bar) needed to be updated. To solve this, I added a nav bar component that can draw from the store.
const oldChannel = document.getElementById('nav-bar-channel-select-channel-option');
kauffj commented 2018-01-15 20:26:37 +01:00 (Migrated from github.com)
Review
Copy link

Shouldn't this design be obviated by addition of React/Redux? The component should be able to refresh based on external state change

Shouldn't this design be obviated by addition of React/Redux? The component should be able to refresh based on external state change
bones7242 commented 2018-01-18 23:25:06 +01:00 (Migrated from github.com)
Review
Copy link

The reason for this was that html outside of the react publish component (the top nav bar) needed to be updated. To solve this, I added a nav bar component that can draw from the store.

The reason for this was that html outside of the react publish component (the top nav bar) needed to be updated. To solve this, I added a nav bar component that can draw from the store.
if (oldChannel) {
kauffj commented 2018-01-15 20:26:37 +01:00 (Migrated from github.com)
Review
Copy link

Shouldn't this design be obviated by addition of React/Redux? The component should be able to refresh based on external state change

Shouldn't this design be obviated by addition of React/Redux? The component should be able to refresh based on external state change
bones7242 commented 2018-01-18 23:25:06 +01:00 (Migrated from github.com)
Review
Copy link

The reason for this was that html outside of the react publish component (the top nav bar) needed to be updated. To solve this, I added a nav bar component that can draw from the store.

The reason for this was that html outside of the react publish component (the top nav bar) needed to be updated. To solve this, I added a nav bar component that can draw from the store.
oldChannel.parentNode.removeChild(oldChannel);
kauffj commented 2018-01-15 20:26:37 +01:00 (Migrated from github.com)
Review
Copy link

Shouldn't this design be obviated by addition of React/Redux? The component should be able to refresh based on external state change

Shouldn't this design be obviated by addition of React/Redux? The component should be able to refresh based on external state change
bones7242 commented 2018-01-18 23:25:06 +01:00 (Migrated from github.com)
Review
Copy link

The reason for this was that html outside of the react publish component (the top nav bar) needed to be updated. To solve this, I added a nav bar component that can draw from the store.

The reason for this was that html outside of the react publish component (the top nav bar) needed to be updated. To solve this, I added a nav bar component that can draw from the store.
}
kauffj commented 2018-01-15 20:26:37 +01:00 (Migrated from github.com)
Review
Copy link

Shouldn't this design be obviated by addition of React/Redux? The component should be able to refresh based on external state change

Shouldn't this design be obviated by addition of React/Redux? The component should be able to refresh based on external state change
bones7242 commented 2018-01-18 23:25:06 +01:00 (Migrated from github.com)
Review
Copy link

The reason for this was that html outside of the react publish component (the top nav bar) needed to be updated. To solve this, I added a nav bar component that can draw from the store.

The reason for this was that html outside of the react publish component (the top nav bar) needed to be updated. To solve this, I added a nav bar component that can draw from the store.
// create new channel option & select it
kauffj commented 2018-01-15 20:26:37 +01:00 (Migrated from github.com)
Review
Copy link

Shouldn't this design be obviated by addition of React/Redux? The component should be able to refresh based on external state change

Shouldn't this design be obviated by addition of React/Redux? The component should be able to refresh based on external state change
bones7242 commented 2018-01-18 23:25:06 +01:00 (Migrated from github.com)
Review
Copy link

The reason for this was that html outside of the react publish component (the top nav bar) needed to be updated. To solve this, I added a nav bar component that can draw from the store.

The reason for this was that html outside of the react publish component (the top nav bar) needed to be updated. To solve this, I added a nav bar component that can draw from the store.
const newChannelOption = document.createElement('option');
kauffj commented 2018-01-15 20:26:37 +01:00 (Migrated from github.com)
Review
Copy link

Shouldn't this design be obviated by addition of React/Redux? The component should be able to refresh based on external state change

Shouldn't this design be obviated by addition of React/Redux? The component should be able to refresh based on external state change
bones7242 commented 2018-01-18 23:25:06 +01:00 (Migrated from github.com)
Review
Copy link

The reason for this was that html outside of the react publish component (the top nav bar) needed to be updated. To solve this, I added a nav bar component that can draw from the store.

The reason for this was that html outside of the react publish component (the top nav bar) needed to be updated. To solve this, I added a nav bar component that can draw from the store.
newChannelOption.setAttribute('value', loggedInChannel);
kauffj commented 2018-01-15 20:26:37 +01:00 (Migrated from github.com)
Review
Copy link

Shouldn't this design be obviated by addition of React/Redux? The component should be able to refresh based on external state change

Shouldn't this design be obviated by addition of React/Redux? The component should be able to refresh based on external state change
bones7242 commented 2018-01-18 23:25:06 +01:00 (Migrated from github.com)
Review
Copy link

The reason for this was that html outside of the react publish component (the top nav bar) needed to be updated. To solve this, I added a nav bar component that can draw from the store.

The reason for this was that html outside of the react publish component (the top nav bar) needed to be updated. To solve this, I added a nav bar component that can draw from the store.
newChannelOption.setAttribute('id', 'nav-bar-channel-select-channel-option');
kauffj commented 2018-01-15 20:26:37 +01:00 (Migrated from github.com)
Review
Copy link

Shouldn't this design be obviated by addition of React/Redux? The component should be able to refresh based on external state change

Shouldn't this design be obviated by addition of React/Redux? The component should be able to refresh based on external state change
bones7242 commented 2018-01-18 23:25:06 +01:00 (Migrated from github.com)
Review
Copy link

The reason for this was that html outside of the react publish component (the top nav bar) needed to be updated. To solve this, I added a nav bar component that can draw from the store.

The reason for this was that html outside of the react publish component (the top nav bar) needed to be updated. To solve this, I added a nav bar component that can draw from the store.
newChannelOption.setAttribute('selected', '');
kauffj commented 2018-01-15 20:26:37 +01:00 (Migrated from github.com)
Review
Copy link

Shouldn't this design be obviated by addition of React/Redux? The component should be able to refresh based on external state change

Shouldn't this design be obviated by addition of React/Redux? The component should be able to refresh based on external state change
bones7242 commented 2018-01-18 23:25:06 +01:00 (Migrated from github.com)
Review
Copy link

The reason for this was that html outside of the react publish component (the top nav bar) needed to be updated. To solve this, I added a nav bar component that can draw from the store.

The reason for this was that html outside of the react publish component (the top nav bar) needed to be updated. To solve this, I added a nav bar component that can draw from the store.
newChannelOption.innerText = loggedInChannel;
kauffj commented 2018-01-15 20:26:37 +01:00 (Migrated from github.com)
Review
Copy link

Shouldn't this design be obviated by addition of React/Redux? The component should be able to refresh based on external state change

Shouldn't this design be obviated by addition of React/Redux? The component should be able to refresh based on external state change
bones7242 commented 2018-01-18 23:25:06 +01:00 (Migrated from github.com)
Review
Copy link

The reason for this was that html outside of the react publish component (the top nav bar) needed to be updated. To solve this, I added a nav bar component that can draw from the store.

The reason for this was that html outside of the react publish component (the top nav bar) needed to be updated. To solve this, I added a nav bar component that can draw from the store.
// add the new option
kauffj commented 2018-01-15 20:26:37 +01:00 (Migrated from github.com)
Review
Copy link

Shouldn't this design be obviated by addition of React/Redux? The component should be able to refresh based on external state change

Shouldn't this design be obviated by addition of React/Redux? The component should be able to refresh based on external state change
bones7242 commented 2018-01-18 23:25:06 +01:00 (Migrated from github.com)
Review
Copy link

The reason for this was that html outside of the react publish component (the top nav bar) needed to be updated. To solve this, I added a nav bar component that can draw from the store.

The reason for this was that html outside of the react publish component (the top nav bar) needed to be updated. To solve this, I added a nav bar component that can draw from the store.
const channelSelect = document.getElementById('nav-bar-channel-select');
kauffj commented 2018-01-15 20:26:37 +01:00 (Migrated from github.com)
Review
Copy link

Shouldn't this design be obviated by addition of React/Redux? The component should be able to refresh based on external state change

Shouldn't this design be obviated by addition of React/Redux? The component should be able to refresh based on external state change
bones7242 commented 2018-01-18 23:25:06 +01:00 (Migrated from github.com)
Review
Copy link

The reason for this was that html outside of the react publish component (the top nav bar) needed to be updated. To solve this, I added a nav bar component that can draw from the store.

The reason for this was that html outside of the react publish component (the top nav bar) needed to be updated. To solve this, I added a nav bar component that can draw from the store.
channelSelect.style.display = 'inline-block';
kauffj commented 2018-01-15 20:26:37 +01:00 (Migrated from github.com)
Review
Copy link

Shouldn't this design be obviated by addition of React/Redux? The component should be able to refresh based on external state change

Shouldn't this design be obviated by addition of React/Redux? The component should be able to refresh based on external state change
bones7242 commented 2018-01-18 23:25:06 +01:00 (Migrated from github.com)
Review
Copy link

The reason for this was that html outside of the react publish component (the top nav bar) needed to be updated. To solve this, I added a nav bar component that can draw from the store.

The reason for this was that html outside of the react publish component (the top nav bar) needed to be updated. To solve this, I added a nav bar component that can draw from the store.
channelSelect.insertBefore(newChannelOption, channelSelect.firstChild);
kauffj commented 2018-01-15 20:26:37 +01:00 (Migrated from github.com)
Review
Copy link

Shouldn't this design be obviated by addition of React/Redux? The component should be able to refresh based on external state change

Shouldn't this design be obviated by addition of React/Redux? The component should be able to refresh based on external state change
bones7242 commented 2018-01-18 23:25:06 +01:00 (Migrated from github.com)
Review
Copy link

The reason for this was that html outside of the react publish component (the top nav bar) needed to be updated. To solve this, I added a nav bar component that can draw from the store.

The reason for this was that html outside of the react publish component (the top nav bar) needed to be updated. To solve this, I added a nav bar component that can draw from the store.
// hide login
kauffj commented 2018-01-15 20:26:37 +01:00 (Migrated from github.com)
Review
Copy link

Shouldn't this design be obviated by addition of React/Redux? The component should be able to refresh based on external state change

Shouldn't this design be obviated by addition of React/Redux? The component should be able to refresh based on external state change
bones7242 commented 2018-01-18 23:25:06 +01:00 (Migrated from github.com)
Review
Copy link

The reason for this was that html outside of the react publish component (the top nav bar) needed to be updated. To solve this, I added a nav bar component that can draw from the store.

The reason for this was that html outside of the react publish component (the top nav bar) needed to be updated. To solve this, I added a nav bar component that can draw from the store.
const navBarLoginLink = document.getElementById('nav-bar-login-link');
kauffj commented 2018-01-15 20:26:37 +01:00 (Migrated from github.com)
Review
Copy link

Shouldn't this design be obviated by addition of React/Redux? The component should be able to refresh based on external state change

Shouldn't this design be obviated by addition of React/Redux? The component should be able to refresh based on external state change
bones7242 commented 2018-01-18 23:25:06 +01:00 (Migrated from github.com)
Review
Copy link

The reason for this was that html outside of the react publish component (the top nav bar) needed to be updated. To solve this, I added a nav bar component that can draw from the store.

The reason for this was that html outside of the react publish component (the top nav bar) needed to be updated. To solve this, I added a nav bar component that can draw from the store.
navBarLoginLink.style.display = 'none';
kauffj commented 2018-01-15 20:26:37 +01:00 (Migrated from github.com)
Review
Copy link

Shouldn't this design be obviated by addition of React/Redux? The component should be able to refresh based on external state change

Shouldn't this design be obviated by addition of React/Redux? The component should be able to refresh based on external state change
bones7242 commented 2018-01-18 23:25:06 +01:00 (Migrated from github.com)
Review
Copy link

The reason for this was that html outside of the react publish component (the top nav bar) needed to be updated. To solve this, I added a nav bar component that can draw from the store.

The reason for this was that html outside of the react publish component (the top nav bar) needed to be updated. To solve this, I added a nav bar component that can draw from the store.
},
kauffj commented 2018-01-15 20:26:37 +01:00 (Migrated from github.com)
Review
Copy link

Shouldn't this design be obviated by addition of React/Redux? The component should be able to refresh based on external state change

Shouldn't this design be obviated by addition of React/Redux? The component should be able to refresh based on external state change
bones7242 commented 2018-01-18 23:25:06 +01:00 (Migrated from github.com)
Review
Copy link

The reason for this was that html outside of the react publish component (the top nav bar) needed to be updated. To solve this, I added a nav bar component that can draw from the store.

The reason for this was that html outside of the react publish component (the top nav bar) needed to be updated. To solve this, I added a nav bar component that can draw from the store.
}
kauffj commented 2018-01-15 20:26:37 +01:00 (Migrated from github.com)
Review
Copy link

Shouldn't this design be obviated by addition of React/Redux? The component should be able to refresh based on external state change

Shouldn't this design be obviated by addition of React/Redux? The component should be able to refresh based on external state change
bones7242 commented 2018-01-18 23:25:06 +01:00 (Migrated from github.com)
Review
Copy link

The reason for this was that html outside of the react publish component (the top nav bar) needed to be updated. To solve this, I added a nav bar component that can draw from the store.

The reason for this was that html outside of the react publish component (the top nav bar) needed to be updated. To solve this, I added a nav bar component that can draw from the store.