React/Redux - publish component #323

Merged
bones7242 merged 80 commits from react-upload into master 2018-01-25 22:43:20 +01:00
2 changed files with 20 additions and 13 deletions
Showing only changes of commit ae86d3dfa2 - Show all commits

View file

@ -1,4 +1,5 @@
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
import React from 'react';
import PropTypes from 'prop-types';
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
function ActiveBar () {
return <span className="progress-bar progress-bar--active">| </span>;
@ -17,22 +18,24 @@ class ProgressBar extends React.Component {
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
index : 0,
incrementer: 1,
};
this.createBars = this.createBars.bind(this);
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
this.startProgressBar = this.startProgressBar.bind(this);
this.updateProgressBar = this.updateProgressBar.bind(this);
this.stopProgressBar = this.stopProgressBar.bind(this);
}
componentDidMount () {
const bars = [];
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
for (let i = 0; i <= this.state.size; i++) {
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
bars.push(<InactiveBar key={i} />);
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
}
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
this.setState({ bars });
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
this.createBars();
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
this.startProgressBar();
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
}
componentWillUnmount () {
this.stopProgressBar();
}
componentDidMount () {
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
this.startProgressBar();
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
createBars () {
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
const bars = [];
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
for (let i = 0; i <= this.props.size; i++) {
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
bars.push({isActive: false});
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
}
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
this.setState({ bars });
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
}
startProgressBar () {
this.updateInterval = setInterval(this.updateProgressBar.bind(this), 300);
@ -42,15 +45,15 @@ class ProgressBar extends React.Component {
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
let incrementer = this.state.incrementer;
let bars = this.state.bars;
// flip incrementer if necessary, to stay in bounds
if ((index < 0) || (index > this.state.size)) {
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
if ((index < 0) || (index > this.props.size)) {
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
incrementer = incrementer * -1;
index += incrementer;
}
// update the indexed value
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
// update the indexed bar
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
if (incrementer > 0) {
bars[index] = <ActiveBar key={index} />;
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
bars[index].isActive = true;
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
} else {
bars[index] = <InactiveBar key={index} />;
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
bars[index].isActive = false;
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
};
// increment index
index += incrementer;
@ -67,10 +70,14 @@ class ProgressBar extends React.Component {
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
render () {
return (
<div>
{this.state.bars}
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
{this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index}/> )}
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
</div>
);
}
};
ProgressBar.propTypes = {
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
size: PropTypes.number.isRequired,
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
};
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
export default ProgressBar;

kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars

View file

@ -23,7 +23,7 @@ function PublishStatus ({ status, message }) {
{(status === publishStates.PUBLISHING) &&
<div className="row align-content-center">
<p>Upload complete. Your file is now being published on the blockchain...</p>
<ProgressBar/>
<ProgressBar size={12}/>
<p>Curious what magic is happening here? <a className="link--primary" target="blank" href="https://lbry.io/faq/what-is-lbry">Learn more.</a></p>
</div>
}