React/Redux - publish component #323

Merged
bones7242 merged 80 commits from react-upload into master 2018-01-25 22:43:20 +01:00
3 changed files with 3 additions and 4 deletions
Showing only changes of commit d0c6f75bff - Show all commits

View file

@ -1,6 +1,6 @@
import React from 'react';
function ActiveStatusBar () {
const ActiveStatusBar = () => {
return <span className="progress-bar progress-bar--active">| </span>;
}

View file

@ -1,7 +1,7 @@
import React from 'react';
function InactiveStatusBar () {
const InactiveStatusBar = () => {
return <span className="progress-bar progress-bar--inactive">| </span>;
}
export default InactiveStatusBar();
export default InactiveStatusBar;

View file

@ -7,7 +7,6 @@ class ProgressBar extends React.Component {
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
constructor (props) {
super(props);
this.state = {
size : 12,
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
bars : [],
index : 0,
incrementer: 1,

kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars
kauffj commented 2018-01-15 20:34:36 +01:00 (Migrated from github.com)
Review

What is the | doing here?

What is the `|` doing here?
etisdew commented 2018-01-15 21:16:12 +01:00 (Migrated from github.com)
Review

It looks as if its seeding the progress visually, is that correct?

It looks as if its seeding the progress visually, is that correct?
neb-b commented 2018-01-18 06:16:04 +01:00 (Migrated from github.com)
Review

Instead of adding react elements to state, just store the data.

Then in the render function, you can do
this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)

Instead of adding react elements to state, just store the data. Then in the `render` function, you can do `this.state.bars.map((bar, index) => bar.isActive ? <ActiveBar key={index} /> : <InactiveBar key={index} />)`
bones7242 commented 2018-01-18 23:26:24 +01:00 (Migrated from github.com)
Review

Yes, I am rendering the |s for the progress bars

Yes, I am rendering the `|`s for the progress bars