LBRYCommunity/spee.ch
1
0
Fork 0
Code Issues 95 Pull requests 2 Projects Releases 4 Packages Wiki Activity

React/Redux - publish component #323

Merged
bones7242 merged 80 commits from react-upload into master 2018-01-25 22:43:20 +01:00
Conversation 1 Commits 80 Files changed 82 -3
3 changed files with 0 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit def4e03707 - Show all commits

1
react/components/ChannelSelector.jsx
View file

@ -22,7 +22,6 @@ class ChannelSelector extends React.Component {
} }
} }
componentWillReceiveProps ({ loggedInChannelName }) { componentWillReceiveProps ({ loggedInChannelName }) {
console.log('ChannelSelector will receive props');
if (loggedInChannelName) { if (loggedInChannelName) {
this.selectOption(loggedInChannelName); this.selectOption(loggedInChannelName);
} }

1
react/components/Preview.jsx
View file

@ -14,7 +14,6 @@ class Preview extends React.Component {
neb-b commented 2018-01-18 06:08:35 +01:00 (Migrated from github.com)
Review
Copy link

Generally you should avoid doing dom stuff/setting state in componentWillMount. Especially since it seems that they will be removing it in a future React version.

componentDidMount is preferred

Generally you should avoid doing dom stuff/setting state in `componentWillMount`. Especially since it seems that they will be removing it in a future React version. `componentDidMount` is preferred
neb-b commented 2018-01-18 06:08:35 +01:00 (Migrated from github.com)
Review
Copy link

Generally you should avoid doing dom stuff/setting state in componentWillMount. Especially since it seems that they will be removing it in a future React version.

componentDidMount is preferred

Generally you should avoid doing dom stuff/setting state in `componentWillMount`. Especially since it seems that they will be removing it in a future React version. `componentDidMount` is preferred
this.previewFile(this.props.file); this.previewFile(this.props.file);
} }
componentWillReceiveProps (newProps) { componentWillReceiveProps (newProps) {
console.log('Preview will receive props', newProps);
neb-b commented 2018-01-18 06:08:35 +01:00 (Migrated from github.com)
Review
Copy link

Generally you should avoid doing dom stuff/setting state in componentWillMount. Especially since it seems that they will be removing it in a future React version.

componentDidMount is preferred

Generally you should avoid doing dom stuff/setting state in `componentWillMount`. Especially since it seems that they will be removing it in a future React version. `componentDidMount` is preferred
this.previewFile(newProps.file); this.previewFile(newProps.file);
} }
previewFile (file) { previewFile (file) {

neb-b commented 2018-01-18 06:08:35 +01:00 (Migrated from github.com)
Review
Copy link

Generally you should avoid doing dom stuff/setting state in componentWillMount. Especially since it seems that they will be removing it in a future React version.

componentDidMount is preferred

Generally you should avoid doing dom stuff/setting state in `componentWillMount`. Especially since it seems that they will be removing it in a future React version. `componentDidMount` is preferred
neb-b commented 2018-01-18 06:08:35 +01:00 (Migrated from github.com)
Review
Copy link

Generally you should avoid doing dom stuff/setting state in componentWillMount. Especially since it seems that they will be removing it in a future React version.

componentDidMount is preferred

Generally you should avoid doing dom stuff/setting state in `componentWillMount`. Especially since it seems that they will be removing it in a future React version. `componentDidMount` is preferred

1
react/containers/PublishUrlInput.jsx
View file

@ -23,7 +23,6 @@ class UrlChooser extends React.Component {
kauffj commented 2018-01-15 20:29:33 +01:00 (Migrated from github.com)
Review
Copy link

You should look at some of the linting additions @IGassman has added to app, could help keep these imports consistent in path specification (among other improvements).

You should look at some of the linting additions @IGassman has added to app, could help keep these imports consistent in path specification (among other improvements).
kauffj commented 2018-01-15 20:29:33 +01:00 (Migrated from github.com)
Review
Copy link

You should look at some of the linting additions @IGassman has added to app, could help keep these imports consistent in path specification (among other improvements).

You should look at some of the linting additions @IGassman has added to app, could help keep these imports consistent in path specification (among other improvements).
} }
} }
componentWillReceiveProps ({claim: newClaim}) { componentWillReceiveProps ({claim: newClaim}) {
console.log('PublishUrlInput will receive new props (claim)', newClaim);
kauffj commented 2018-01-15 20:29:33 +01:00 (Migrated from github.com)
Review
Copy link

You should look at some of the linting additions @IGassman has added to app, could help keep these imports consistent in path specification (among other improvements).

You should look at some of the linting additions @IGassman has added to app, could help keep these imports consistent in path specification (among other improvements).
if (newClaim) { if (newClaim) {
this.checkClaimIsAvailable(newClaim); this.checkClaimIsAvailable(newClaim);
} else { } else {

kauffj commented 2018-01-15 20:29:33 +01:00 (Migrated from github.com)
Review
Copy link

You should look at some of the linting additions @IGassman has added to app, could help keep these imports consistent in path specification (among other improvements).

You should look at some of the linting additions @IGassman has added to app, could help keep these imports consistent in path specification (among other improvements).
kauffj commented 2018-01-15 20:29:33 +01:00 (Migrated from github.com)
Review
Copy link

You should look at some of the linting additions @IGassman has added to app, could help keep these imports consistent in path specification (among other improvements).

You should look at some of the linting additions @IGassman has added to app, could help keep these imports consistent in path specification (among other improvements).