LBRYCommunity/spee.ch
1
0
Fork 0
Code Issues 95 Pull requests 2 Projects Releases 4 Packages Wiki Activity

React/Redux - publish component #323

Merged
bones7242 merged 80 commits from react-upload into master 2018-01-25 22:43:20 +01:00
Conversation 1 Commits 80 Files changed 82 -2
2 changed files with 0 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit e663460c87 - Show all commits

1
react/components/Preview.jsx
View file

@ -18,7 +18,6 @@ class Preview extends React.Component {
neb-b commented 2018-01-18 06:08:35 +01:00 (Migrated from github.com)
Review
Copy link

Generally you should avoid doing dom stuff/setting state in componentWillMount. Especially since it seems that they will be removing it in a future React version.

componentDidMount is preferred

Generally you should avoid doing dom stuff/setting state in `componentWillMount`. Especially since it seems that they will be removing it in a future React version. `componentDidMount` is preferred
neb-b commented 2018-01-18 06:08:35 +01:00 (Migrated from github.com)
Review
Copy link

Generally you should avoid doing dom stuff/setting state in componentWillMount. Especially since it seems that they will be removing it in a future React version.

componentDidMount is preferred

Generally you should avoid doing dom stuff/setting state in `componentWillMount`. Especially since it seems that they will be removing it in a future React version. `componentDidMount` is preferred
this.previewFile(newProps.file); this.previewFile(newProps.file);
} }
if (newProps.thumbnail !== this.props.thumbnail) { if (newProps.thumbnail !== this.props.thumbnail) {
console.log('updating thumbnail', this.props.thumbnail);
neb-b commented 2018-01-18 06:08:35 +01:00 (Migrated from github.com)
Review
Copy link

Generally you should avoid doing dom stuff/setting state in componentWillMount. Especially since it seems that they will be removing it in a future React version.

componentDidMount is preferred

Generally you should avoid doing dom stuff/setting state in `componentWillMount`. Especially since it seems that they will be removing it in a future React version. `componentDidMount` is preferred
this.setState({imgSource: (newProps.thumbnail || this.state.defaultThumbnail)}); this.setState({imgSource: (newProps.thumbnail || this.state.defaultThumbnail)});
} }
} }

neb-b commented 2018-01-18 06:08:35 +01:00 (Migrated from github.com)
Review
Copy link

Generally you should avoid doing dom stuff/setting state in componentWillMount. Especially since it seems that they will be removing it in a future React version.

componentDidMount is preferred

Generally you should avoid doing dom stuff/setting state in `componentWillMount`. Especially since it seems that they will be removing it in a future React version. `componentDidMount` is preferred
neb-b commented 2018-01-18 06:08:35 +01:00 (Migrated from github.com)
Review
Copy link

Generally you should avoid doing dom stuff/setting state in componentWillMount. Especially since it seems that they will be removing it in a future React version.

componentDidMount is preferred

Generally you should avoid doing dom stuff/setting state in `componentWillMount`. Especially since it seems that they will be removing it in a future React version. `componentDidMount` is preferred

1
react/containers/NavBar/view.jsx
View file

@ -42,7 +42,6 @@ class NavBar extends React.Component {
// check for whether a channel is already logged in // check for whether a channel is already logged in
let channelName, channelShortId, channelLongId; let channelName, channelShortId, channelLongId;
({ channelName, channelShortId, channelLongId } = getUserCookies()); ({ channelName, channelShortId, channelLongId } = getUserCookies());
console.log(`userCookies`, getUserCookies());
console.log(`cookies found for channel: ${channelName} ${channelShortId} ${channelLongId}`); console.log(`cookies found for channel: ${channelName} ${channelShortId} ${channelLongId}`);
this.props.onChannelLogin(channelName, channelShortId, channelLongId); this.props.onChannelLogin(channelName, channelShortId, channelLongId);
} }