Speech as a package - export components #401

Merged
bones7242 merged 8 commits from speech-as-a-package-export-component-lib into speech-as-a-package 2018-03-22 06:11:03 +01:00
Showing only changes of commit 8ae9f393ae - Show all commits

View file

@ -4,7 +4,7 @@ const { join } = require('path');
neb-b commented 2018-03-22 06:00:36 +01:00 (Migrated from github.com)
Review

I would use const if you aren't changing anything

I would use `const` if you aren't changing anything
bones7242 commented 2018-03-22 06:04:53 +01:00 (Migrated from github.com)
Review

nice

nice
neb-b commented 2018-03-22 06:00:36 +01:00 (Migrated from github.com)
Review

I would use const if you aren't changing anything

I would use `const` if you aren't changing anything
bones7242 commented 2018-03-22 06:04:53 +01:00 (Migrated from github.com)
Review

nice

nice
export const getSubDirectoryNames = (root) => {
return readdirSync(root)
.filter(name => {
let fullPath = join(root, name);
neb-b commented 2018-03-22 06:00:36 +01:00 (Migrated from github.com)
Review

I would use const if you aren't changing anything

I would use `const` if you aren't changing anything
bones7242 commented 2018-03-22 06:04:53 +01:00 (Migrated from github.com)
Review

nice

nice
const fullPath = join(root, name);
neb-b commented 2018-03-22 06:00:36 +01:00 (Migrated from github.com)
Review

I would use const if you aren't changing anything

I would use `const` if you aren't changing anything
bones7242 commented 2018-03-22 06:04:53 +01:00 (Migrated from github.com)
Review

nice

nice
return lstatSync(fullPath).isDirectory();
});
};

neb-b commented 2018-03-22 06:00:36 +01:00 (Migrated from github.com)
Review

I would use const if you aren't changing anything

I would use `const` if you aren't changing anything
bones7242 commented 2018-03-22 06:04:53 +01:00 (Migrated from github.com)
Review

nice

nice
neb-b commented 2018-03-22 06:00:36 +01:00 (Migrated from github.com)
Review

I would use const if you aren't changing anything

I would use `const` if you aren't changing anything
bones7242 commented 2018-03-22 06:04:53 +01:00 (Migrated from github.com)
Review

nice

nice