Speech as a package #416

Merged
bones7242 merged 89 commits from speech-as-a-package into master 2018-04-18 21:47:34 +02:00
2 changed files with 3 additions and 3 deletions
Showing only changes of commit e6ade3b728 - Show all commits

File diff suppressed because one or more lines are too long

View file

@ -50,7 +50,7 @@ function Server () {
neb-b commented 2018-04-17 22:37:07 +02:00 (Migrated from github.com)
Review

For these you can just do

this.configureLogger = loggerConfig.update
For these you can just do ``` this.configureLogger = loggerConfig.update ```
neb-b commented 2018-04-17 22:39:55 +02:00 (Migrated from github.com)
Review

Do we need to have any maxAge? It would be nice if the user was never logged out

Do we need to have any `maxAge`? It would be nice if the user was never logged out
neb-b commented 2018-04-17 22:40:27 +02:00 (Migrated from github.com)
Review

I thought handlebars was removed?

I thought handlebars was removed?
bones7242 commented 2018-04-18 21:29:39 +02:00 (Migrated from github.com)
Review

it's still being used in one specific case: for sharing videos on twitter via cards, twitter needs an html page with a video player embedded, so I am using handlebars to generate that one page when needed.

it's still being used in one specific case: for sharing videos on twitter via cards, twitter needs an html page with a video player embedded, so I am using handlebars to generate that one page when needed.
bones7242 commented 2018-04-18 21:47:28 +02:00 (Migrated from github.com)
Review

I guess we don't need to, and it does make a better user experience if the user doesn't need to log back in ever day. I eliminated the maxAge so sessions should last indefinitely.

I guess we don't need to, and it does make a better user experience if the user doesn't need to log back in ever day. I eliminated the maxAge so sessions should last indefinitely.
neb-b commented 2018-04-17 22:37:07 +02:00 (Migrated from github.com)
Review

For these you can just do

this.configureLogger = loggerConfig.update
For these you can just do ``` this.configureLogger = loggerConfig.update ```
neb-b commented 2018-04-17 22:39:55 +02:00 (Migrated from github.com)
Review

Do we need to have any maxAge? It would be nice if the user was never logged out

Do we need to have any `maxAge`? It would be nice if the user was never logged out
neb-b commented 2018-04-17 22:40:27 +02:00 (Migrated from github.com)
Review

I thought handlebars was removed?

I thought handlebars was removed?
bones7242 commented 2018-04-18 21:29:39 +02:00 (Migrated from github.com)
Review

it's still being used in one specific case: for sharing videos on twitter via cards, twitter needs an html page with a video player embedded, so I am using handlebars to generate that one page when needed.

it's still being used in one specific case: for sharing videos on twitter via cards, twitter needs an html page with a video player embedded, so I am using handlebars to generate that one page when needed.
bones7242 commented 2018-04-18 21:47:28 +02:00 (Migrated from github.com)
Review

I guess we don't need to, and it does make a better user experience if the user doesn't need to log back in ever day. I eliminated the maxAge so sessions should last indefinitely.

I guess we don't need to, and it does make a better user experience if the user doesn't need to log back in ever day. I eliminated the maxAge so sessions should last indefinitely.
app.use(express.static(publicFolder));
logger.info('serving static files from custom path:', publicFolder);
} else {
const publicPath = Path.resolve(process.cwd(), 'static');
neb-b commented 2018-04-17 22:37:07 +02:00 (Migrated from github.com)
Review

For these you can just do

this.configureLogger = loggerConfig.update
For these you can just do ``` this.configureLogger = loggerConfig.update ```
neb-b commented 2018-04-17 22:39:55 +02:00 (Migrated from github.com)
Review

Do we need to have any maxAge? It would be nice if the user was never logged out

Do we need to have any `maxAge`? It would be nice if the user was never logged out
neb-b commented 2018-04-17 22:40:27 +02:00 (Migrated from github.com)
Review

I thought handlebars was removed?

I thought handlebars was removed?
bones7242 commented 2018-04-18 21:29:39 +02:00 (Migrated from github.com)
Review

it's still being used in one specific case: for sharing videos on twitter via cards, twitter needs an html page with a video player embedded, so I am using handlebars to generate that one page when needed.

it's still being used in one specific case: for sharing videos on twitter via cards, twitter needs an html page with a video player embedded, so I am using handlebars to generate that one page when needed.
bones7242 commented 2018-04-18 21:47:28 +02:00 (Migrated from github.com)
Review

I guess we don't need to, and it does make a better user experience if the user doesn't need to log back in ever day. I eliminated the maxAge so sessions should last indefinitely.

I guess we don't need to, and it does make a better user experience if the user doesn't need to log back in ever day. I eliminated the maxAge so sessions should last indefinitely.
const publicPath = Path.resolve(process.cwd(), 'public');
neb-b commented 2018-04-17 22:37:07 +02:00 (Migrated from github.com)
Review

For these you can just do

this.configureLogger = loggerConfig.update
For these you can just do ``` this.configureLogger = loggerConfig.update ```
neb-b commented 2018-04-17 22:39:55 +02:00 (Migrated from github.com)
Review

Do we need to have any maxAge? It would be nice if the user was never logged out

Do we need to have any `maxAge`? It would be nice if the user was never logged out
neb-b commented 2018-04-17 22:40:27 +02:00 (Migrated from github.com)
Review

I thought handlebars was removed?

I thought handlebars was removed?
bones7242 commented 2018-04-18 21:29:39 +02:00 (Migrated from github.com)
Review

it's still being used in one specific case: for sharing videos on twitter via cards, twitter needs an html page with a video player embedded, so I am using handlebars to generate that one page when needed.

it's still being used in one specific case: for sharing videos on twitter via cards, twitter needs an html page with a video player embedded, so I am using handlebars to generate that one page when needed.
bones7242 commented 2018-04-18 21:47:28 +02:00 (Migrated from github.com)
Review

I guess we don't need to, and it does make a better user experience if the user doesn't need to log back in ever day. I eliminated the maxAge so sessions should last indefinitely.

I guess we don't need to, and it does make a better user experience if the user doesn't need to log back in ever day. I eliminated the maxAge so sessions should last indefinitely.
app.use(express.static(publicPath));
logger.warn(`serving static files from default static path at ${publicPath}. Please specify a path in your config/siteConfig.js file`, );
};

neb-b commented 2018-04-17 22:37:07 +02:00 (Migrated from github.com)
Review

For these you can just do

this.configureLogger = loggerConfig.update
For these you can just do ``` this.configureLogger = loggerConfig.update ```
neb-b commented 2018-04-17 22:39:55 +02:00 (Migrated from github.com)
Review

Do we need to have any maxAge? It would be nice if the user was never logged out

Do we need to have any `maxAge`? It would be nice if the user was never logged out
neb-b commented 2018-04-17 22:40:27 +02:00 (Migrated from github.com)
Review

I thought handlebars was removed?

I thought handlebars was removed?
bones7242 commented 2018-04-18 21:29:39 +02:00 (Migrated from github.com)
Review

it's still being used in one specific case: for sharing videos on twitter via cards, twitter needs an html page with a video player embedded, so I am using handlebars to generate that one page when needed.

it's still being used in one specific case: for sharing videos on twitter via cards, twitter needs an html page with a video player embedded, so I am using handlebars to generate that one page when needed.
bones7242 commented 2018-04-18 21:47:28 +02:00 (Migrated from github.com)
Review

I guess we don't need to, and it does make a better user experience if the user doesn't need to log back in ever day. I eliminated the maxAge so sessions should last indefinitely.

I guess we don't need to, and it does make a better user experience if the user doesn't need to log back in ever day. I eliminated the maxAge so sessions should last indefinitely.
neb-b commented 2018-04-17 22:37:07 +02:00 (Migrated from github.com)
Review

For these you can just do

this.configureLogger = loggerConfig.update
For these you can just do ``` this.configureLogger = loggerConfig.update ```
neb-b commented 2018-04-17 22:39:55 +02:00 (Migrated from github.com)
Review

Do we need to have any maxAge? It would be nice if the user was never logged out

Do we need to have any `maxAge`? It would be nice if the user was never logged out
neb-b commented 2018-04-17 22:40:27 +02:00 (Migrated from github.com)
Review

I thought handlebars was removed?

I thought handlebars was removed?
bones7242 commented 2018-04-18 21:29:39 +02:00 (Migrated from github.com)
Review

it's still being used in one specific case: for sharing videos on twitter via cards, twitter needs an html page with a video player embedded, so I am using handlebars to generate that one page when needed.

it's still being used in one specific case: for sharing videos on twitter via cards, twitter needs an html page with a video player embedded, so I am using handlebars to generate that one page when needed.
bones7242 commented 2018-04-18 21:47:28 +02:00 (Migrated from github.com)
Review

I guess we don't need to, and it does make a better user experience if the user doesn't need to log back in ever day. I eliminated the maxAge so sessions should last indefinitely.

I guess we don't need to, and it does make a better user experience if the user doesn't need to log back in ever day. I eliminated the maxAge so sessions should last indefinitely.