Speech as a package #416

Merged
bones7242 merged 89 commits from speech-as-a-package into master 2018-04-18 21:47:34 +02:00
Showing only changes of commit fb48f8b1fe - Show all commits

View file

@ -15,10 +15,10 @@ const siteConfig = require('./config/siteConfig.js');
neb-b commented 2018-04-17 22:33:42 +02:00 (Migrated from github.com)
Review

Don't commit this

Don't commit this
bones7242 commented 2018-04-17 23:17:02 +02:00 (Migrated from github.com)
Review

hmm, the problem is that the server uses jsx for server side rendering, so it needs to be transpiled (I think that's the only part that needs to be transpiled), so I wanted to build a bundle and export that bundle. Do you think I should just transpile with babel and not actual bundle with webpack? That's what I did for spee.ch-components

hmm, the problem is that the server uses jsx for server side rendering, so it needs to be transpiled (I think that's the only part that needs to be transpiled), so I wanted to build a bundle and export that bundle. Do you think I should just transpile with babel and not actual bundle with webpack? That's what I did for [spee.ch-components](https://github.com/lbryio/spee.ch-components)
neb-b commented 2018-04-17 23:27:56 +02:00 (Migrated from github.com)
Review

Oh I gotcha. I was confused.

I still don't think this needs to be committed. You can build before publishing. IMO if someone is cloning the repo, they will be building the app on their own.

Oh I gotcha. I was confused. I still don't think this needs to be committed. You can build before publishing. IMO if someone is cloning the repo, they will be building the app on their own.
bones7242 commented 2018-04-18 21:26:22 +02:00 (Migrated from github.com)
Review

i updated it to only transpile the two jsx render functions that are needed for SSR, the rest does not need to be built at this level, as the implementation will build the app again.

i updated it to only transpile the two jsx render functions that are needed for SSR, the rest does not need to be built at this level, as the implementation will build the app again.
neb-b commented 2018-04-17 22:33:42 +02:00 (Migrated from github.com)
Review

Don't commit this

Don't commit this
bones7242 commented 2018-04-17 23:17:02 +02:00 (Migrated from github.com)
Review

hmm, the problem is that the server uses jsx for server side rendering, so it needs to be transpiled (I think that's the only part that needs to be transpiled), so I wanted to build a bundle and export that bundle. Do you think I should just transpile with babel and not actual bundle with webpack? That's what I did for spee.ch-components

hmm, the problem is that the server uses jsx for server side rendering, so it needs to be transpiled (I think that's the only part that needs to be transpiled), so I wanted to build a bundle and export that bundle. Do you think I should just transpile with babel and not actual bundle with webpack? That's what I did for [spee.ch-components](https://github.com/lbryio/spee.ch-components)
neb-b commented 2018-04-17 23:27:56 +02:00 (Migrated from github.com)
Review

Oh I gotcha. I was confused.

I still don't think this needs to be committed. You can build before publishing. IMO if someone is cloning the repo, they will be building the app on their own.

Oh I gotcha. I was confused. I still don't think this needs to be committed. You can build before publishing. IMO if someone is cloning the repo, they will be building the app on their own.
bones7242 commented 2018-04-18 21:26:22 +02:00 (Migrated from github.com)
Review

i updated it to only transpile the two jsx render functions that are needed for SSR, the rest does not need to be built at this level, as the implementation will build the app again.

i updated it to only transpile the two jsx render functions that are needed for SSR, the rest does not need to be built at this level, as the implementation will build the app again.
const slackConfig = require('./config/slackConfig.js');
function Server () {
this.configureLogger = loggerConfig.update(userConfig);
neb-b commented 2018-04-17 22:33:42 +02:00 (Migrated from github.com)
Review

Don't commit this

Don't commit this
bones7242 commented 2018-04-17 23:17:02 +02:00 (Migrated from github.com)
Review

hmm, the problem is that the server uses jsx for server side rendering, so it needs to be transpiled (I think that's the only part that needs to be transpiled), so I wanted to build a bundle and export that bundle. Do you think I should just transpile with babel and not actual bundle with webpack? That's what I did for spee.ch-components

hmm, the problem is that the server uses jsx for server side rendering, so it needs to be transpiled (I think that's the only part that needs to be transpiled), so I wanted to build a bundle and export that bundle. Do you think I should just transpile with babel and not actual bundle with webpack? That's what I did for [spee.ch-components](https://github.com/lbryio/spee.ch-components)
neb-b commented 2018-04-17 23:27:56 +02:00 (Migrated from github.com)
Review

Oh I gotcha. I was confused.

I still don't think this needs to be committed. You can build before publishing. IMO if someone is cloning the repo, they will be building the app on their own.

Oh I gotcha. I was confused. I still don't think this needs to be committed. You can build before publishing. IMO if someone is cloning the repo, they will be building the app on their own.
bones7242 commented 2018-04-18 21:26:22 +02:00 (Migrated from github.com)
Review

i updated it to only transpile the two jsx render functions that are needed for SSR, the rest does not need to be built at this level, as the implementation will build the app again.

i updated it to only transpile the two jsx render functions that are needed for SSR, the rest does not need to be built at this level, as the implementation will build the app again.
this.configureMysql = mysqlConfig.update(userConfig);
neb-b commented 2018-04-17 22:33:42 +02:00 (Migrated from github.com)
Review

Don't commit this

Don't commit this
bones7242 commented 2018-04-17 23:17:02 +02:00 (Migrated from github.com)
Review

hmm, the problem is that the server uses jsx for server side rendering, so it needs to be transpiled (I think that's the only part that needs to be transpiled), so I wanted to build a bundle and export that bundle. Do you think I should just transpile with babel and not actual bundle with webpack? That's what I did for spee.ch-components

hmm, the problem is that the server uses jsx for server side rendering, so it needs to be transpiled (I think that's the only part that needs to be transpiled), so I wanted to build a bundle and export that bundle. Do you think I should just transpile with babel and not actual bundle with webpack? That's what I did for [spee.ch-components](https://github.com/lbryio/spee.ch-components)
neb-b commented 2018-04-17 23:27:56 +02:00 (Migrated from github.com)
Review

Oh I gotcha. I was confused.

I still don't think this needs to be committed. You can build before publishing. IMO if someone is cloning the repo, they will be building the app on their own.

Oh I gotcha. I was confused. I still don't think this needs to be committed. You can build before publishing. IMO if someone is cloning the repo, they will be building the app on their own.
bones7242 commented 2018-04-18 21:26:22 +02:00 (Migrated from github.com)
Review

i updated it to only transpile the two jsx render functions that are needed for SSR, the rest does not need to be built at this level, as the implementation will build the app again.

i updated it to only transpile the two jsx render functions that are needed for SSR, the rest does not need to be built at this level, as the implementation will build the app again.
this.configureSite = siteConfig.update(userConfig);
neb-b commented 2018-04-17 22:33:42 +02:00 (Migrated from github.com)
Review

Don't commit this

Don't commit this
bones7242 commented 2018-04-17 23:17:02 +02:00 (Migrated from github.com)
Review

hmm, the problem is that the server uses jsx for server side rendering, so it needs to be transpiled (I think that's the only part that needs to be transpiled), so I wanted to build a bundle and export that bundle. Do you think I should just transpile with babel and not actual bundle with webpack? That's what I did for spee.ch-components

hmm, the problem is that the server uses jsx for server side rendering, so it needs to be transpiled (I think that's the only part that needs to be transpiled), so I wanted to build a bundle and export that bundle. Do you think I should just transpile with babel and not actual bundle with webpack? That's what I did for [spee.ch-components](https://github.com/lbryio/spee.ch-components)
neb-b commented 2018-04-17 23:27:56 +02:00 (Migrated from github.com)
Review

Oh I gotcha. I was confused.

I still don't think this needs to be committed. You can build before publishing. IMO if someone is cloning the repo, they will be building the app on their own.

Oh I gotcha. I was confused. I still don't think this needs to be committed. You can build before publishing. IMO if someone is cloning the repo, they will be building the app on their own.
bones7242 commented 2018-04-18 21:26:22 +02:00 (Migrated from github.com)
Review

i updated it to only transpile the two jsx render functions that are needed for SSR, the rest does not need to be built at this level, as the implementation will build the app again.

i updated it to only transpile the two jsx render functions that are needed for SSR, the rest does not need to be built at this level, as the implementation will build the app again.
this.configureSlack = slackConfig.update(userConfig);
neb-b commented 2018-04-17 22:33:42 +02:00 (Migrated from github.com)
Review

Don't commit this

Don't commit this
bones7242 commented 2018-04-17 23:17:02 +02:00 (Migrated from github.com)
Review

hmm, the problem is that the server uses jsx for server side rendering, so it needs to be transpiled (I think that's the only part that needs to be transpiled), so I wanted to build a bundle and export that bundle. Do you think I should just transpile with babel and not actual bundle with webpack? That's what I did for spee.ch-components

hmm, the problem is that the server uses jsx for server side rendering, so it needs to be transpiled (I think that's the only part that needs to be transpiled), so I wanted to build a bundle and export that bundle. Do you think I should just transpile with babel and not actual bundle with webpack? That's what I did for [spee.ch-components](https://github.com/lbryio/spee.ch-components)
neb-b commented 2018-04-17 23:27:56 +02:00 (Migrated from github.com)
Review

Oh I gotcha. I was confused.

I still don't think this needs to be committed. You can build before publishing. IMO if someone is cloning the repo, they will be building the app on their own.

Oh I gotcha. I was confused. I still don't think this needs to be committed. You can build before publishing. IMO if someone is cloning the repo, they will be building the app on their own.
bones7242 commented 2018-04-18 21:26:22 +02:00 (Migrated from github.com)
Review

i updated it to only transpile the two jsx render functions that are needed for SSR, the rest does not need to be built at this level, as the implementation will build the app again.

i updated it to only transpile the two jsx render functions that are needed for SSR, the rest does not need to be built at this level, as the implementation will build the app again.
this.configureLogger = loggerConfig.update;
neb-b commented 2018-04-17 22:33:42 +02:00 (Migrated from github.com)
Review

Don't commit this

Don't commit this
bones7242 commented 2018-04-17 23:17:02 +02:00 (Migrated from github.com)
Review

hmm, the problem is that the server uses jsx for server side rendering, so it needs to be transpiled (I think that's the only part that needs to be transpiled), so I wanted to build a bundle and export that bundle. Do you think I should just transpile with babel and not actual bundle with webpack? That's what I did for spee.ch-components

hmm, the problem is that the server uses jsx for server side rendering, so it needs to be transpiled (I think that's the only part that needs to be transpiled), so I wanted to build a bundle and export that bundle. Do you think I should just transpile with babel and not actual bundle with webpack? That's what I did for [spee.ch-components](https://github.com/lbryio/spee.ch-components)
neb-b commented 2018-04-17 23:27:56 +02:00 (Migrated from github.com)
Review

Oh I gotcha. I was confused.

I still don't think this needs to be committed. You can build before publishing. IMO if someone is cloning the repo, they will be building the app on their own.

Oh I gotcha. I was confused. I still don't think this needs to be committed. You can build before publishing. IMO if someone is cloning the repo, they will be building the app on their own.
bones7242 commented 2018-04-18 21:26:22 +02:00 (Migrated from github.com)
Review

i updated it to only transpile the two jsx render functions that are needed for SSR, the rest does not need to be built at this level, as the implementation will build the app again.

i updated it to only transpile the two jsx render functions that are needed for SSR, the rest does not need to be built at this level, as the implementation will build the app again.
this.configureMysql = mysqlConfig.update;
neb-b commented 2018-04-17 22:33:42 +02:00 (Migrated from github.com)
Review

Don't commit this

Don't commit this
bones7242 commented 2018-04-17 23:17:02 +02:00 (Migrated from github.com)
Review

hmm, the problem is that the server uses jsx for server side rendering, so it needs to be transpiled (I think that's the only part that needs to be transpiled), so I wanted to build a bundle and export that bundle. Do you think I should just transpile with babel and not actual bundle with webpack? That's what I did for spee.ch-components

hmm, the problem is that the server uses jsx for server side rendering, so it needs to be transpiled (I think that's the only part that needs to be transpiled), so I wanted to build a bundle and export that bundle. Do you think I should just transpile with babel and not actual bundle with webpack? That's what I did for [spee.ch-components](https://github.com/lbryio/spee.ch-components)
neb-b commented 2018-04-17 23:27:56 +02:00 (Migrated from github.com)
Review

Oh I gotcha. I was confused.

I still don't think this needs to be committed. You can build before publishing. IMO if someone is cloning the repo, they will be building the app on their own.

Oh I gotcha. I was confused. I still don't think this needs to be committed. You can build before publishing. IMO if someone is cloning the repo, they will be building the app on their own.
bones7242 commented 2018-04-18 21:26:22 +02:00 (Migrated from github.com)
Review

i updated it to only transpile the two jsx render functions that are needed for SSR, the rest does not need to be built at this level, as the implementation will build the app again.

i updated it to only transpile the two jsx render functions that are needed for SSR, the rest does not need to be built at this level, as the implementation will build the app again.
this.configureSite = siteConfig.update;
neb-b commented 2018-04-17 22:33:42 +02:00 (Migrated from github.com)
Review

Don't commit this

Don't commit this
bones7242 commented 2018-04-17 23:17:02 +02:00 (Migrated from github.com)
Review

hmm, the problem is that the server uses jsx for server side rendering, so it needs to be transpiled (I think that's the only part that needs to be transpiled), so I wanted to build a bundle and export that bundle. Do you think I should just transpile with babel and not actual bundle with webpack? That's what I did for spee.ch-components

hmm, the problem is that the server uses jsx for server side rendering, so it needs to be transpiled (I think that's the only part that needs to be transpiled), so I wanted to build a bundle and export that bundle. Do you think I should just transpile with babel and not actual bundle with webpack? That's what I did for [spee.ch-components](https://github.com/lbryio/spee.ch-components)
neb-b commented 2018-04-17 23:27:56 +02:00 (Migrated from github.com)
Review

Oh I gotcha. I was confused.

I still don't think this needs to be committed. You can build before publishing. IMO if someone is cloning the repo, they will be building the app on their own.

Oh I gotcha. I was confused. I still don't think this needs to be committed. You can build before publishing. IMO if someone is cloning the repo, they will be building the app on their own.
bones7242 commented 2018-04-18 21:26:22 +02:00 (Migrated from github.com)
Review

i updated it to only transpile the two jsx render functions that are needed for SSR, the rest does not need to be built at this level, as the implementation will build the app again.

i updated it to only transpile the two jsx render functions that are needed for SSR, the rest does not need to be built at this level, as the implementation will build the app again.
this.configureSlack = slackConfig.update;
neb-b commented 2018-04-17 22:33:42 +02:00 (Migrated from github.com)
Review

Don't commit this

Don't commit this
bones7242 commented 2018-04-17 23:17:02 +02:00 (Migrated from github.com)
Review

hmm, the problem is that the server uses jsx for server side rendering, so it needs to be transpiled (I think that's the only part that needs to be transpiled), so I wanted to build a bundle and export that bundle. Do you think I should just transpile with babel and not actual bundle with webpack? That's what I did for spee.ch-components

hmm, the problem is that the server uses jsx for server side rendering, so it needs to be transpiled (I think that's the only part that needs to be transpiled), so I wanted to build a bundle and export that bundle. Do you think I should just transpile with babel and not actual bundle with webpack? That's what I did for [spee.ch-components](https://github.com/lbryio/spee.ch-components)
neb-b commented 2018-04-17 23:27:56 +02:00 (Migrated from github.com)
Review

Oh I gotcha. I was confused.

I still don't think this needs to be committed. You can build before publishing. IMO if someone is cloning the repo, they will be building the app on their own.

Oh I gotcha. I was confused. I still don't think this needs to be committed. You can build before publishing. IMO if someone is cloning the repo, they will be building the app on their own.
bones7242 commented 2018-04-18 21:26:22 +02:00 (Migrated from github.com)
Review

i updated it to only transpile the two jsx render functions that are needed for SSR, the rest does not need to be built at this level, as the implementation will build the app again.

i updated it to only transpile the two jsx render functions that are needed for SSR, the rest does not need to be built at this level, as the implementation will build the app again.
this.configureModels = () => {
logger.debug('here is where you could add/overwrite the default models')
};

neb-b commented 2018-04-17 22:33:42 +02:00 (Migrated from github.com)
Review

Don't commit this

Don't commit this
bones7242 commented 2018-04-17 23:17:02 +02:00 (Migrated from github.com)
Review

hmm, the problem is that the server uses jsx for server side rendering, so it needs to be transpiled (I think that's the only part that needs to be transpiled), so I wanted to build a bundle and export that bundle. Do you think I should just transpile with babel and not actual bundle with webpack? That's what I did for spee.ch-components

hmm, the problem is that the server uses jsx for server side rendering, so it needs to be transpiled (I think that's the only part that needs to be transpiled), so I wanted to build a bundle and export that bundle. Do you think I should just transpile with babel and not actual bundle with webpack? That's what I did for [spee.ch-components](https://github.com/lbryio/spee.ch-components)
neb-b commented 2018-04-17 23:27:56 +02:00 (Migrated from github.com)
Review

Oh I gotcha. I was confused.

I still don't think this needs to be committed. You can build before publishing. IMO if someone is cloning the repo, they will be building the app on their own.

Oh I gotcha. I was confused. I still don't think this needs to be committed. You can build before publishing. IMO if someone is cloning the repo, they will be building the app on their own.
bones7242 commented 2018-04-18 21:26:22 +02:00 (Migrated from github.com)
Review

i updated it to only transpile the two jsx render functions that are needed for SSR, the rest does not need to be built at this level, as the implementation will build the app again.

i updated it to only transpile the two jsx render functions that are needed for SSR, the rest does not need to be built at this level, as the implementation will build the app again.
neb-b commented 2018-04-17 22:33:42 +02:00 (Migrated from github.com)
Review

Don't commit this

Don't commit this
bones7242 commented 2018-04-17 23:17:02 +02:00 (Migrated from github.com)
Review

hmm, the problem is that the server uses jsx for server side rendering, so it needs to be transpiled (I think that's the only part that needs to be transpiled), so I wanted to build a bundle and export that bundle. Do you think I should just transpile with babel and not actual bundle with webpack? That's what I did for spee.ch-components

hmm, the problem is that the server uses jsx for server side rendering, so it needs to be transpiled (I think that's the only part that needs to be transpiled), so I wanted to build a bundle and export that bundle. Do you think I should just transpile with babel and not actual bundle with webpack? That's what I did for [spee.ch-components](https://github.com/lbryio/spee.ch-components)
neb-b commented 2018-04-17 23:27:56 +02:00 (Migrated from github.com)
Review

Oh I gotcha. I was confused.

I still don't think this needs to be committed. You can build before publishing. IMO if someone is cloning the repo, they will be building the app on their own.

Oh I gotcha. I was confused. I still don't think this needs to be committed. You can build before publishing. IMO if someone is cloning the repo, they will be building the app on their own.
bones7242 commented 2018-04-18 21:26:22 +02:00 (Migrated from github.com)
Review

i updated it to only transpile the two jsx render functions that are needed for SSR, the rest does not need to be built at this level, as the implementation will build the app again.

i updated it to only transpile the two jsx render functions that are needed for SSR, the rest does not need to be built at this level, as the implementation will build the app again.