LBRYCommunity/spee.ch
1
0
Fork 0
Code Issues 95 Pull requests 2 Projects Releases 4 Packages Wiki Activity

Add chainquery dependencies for Spee.ch, does not include migrations #593

Merged
skhameneh merged 15 commits from add-chainquery into master 2018-10-10 02:12:18 +02:00
Conversation 3 Commits 15 Files changed 70 +79 -36
10 changed files with 79 additions and 36 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 580ca10a8e - Show all commits

13
server/chainquery/models/AbnormalClaimModel.js
View file

@ -3,7 +3,12 @@ const getterMethods = {
tiger5226 commented 2018-09-05 01:25:52 +02:00 (Migrated from github.com)
Review
Copy link

These are timestamps, is it ok to create it as an integer?

These are timestamps, is it ok to create it as an integer?
skhameneh commented 2018-09-05 02:36:40 +02:00 (Migrated from github.com)
Review
Copy link

This will work for now, I need to verify that Sequelize.DATE(6) is fully compatible first.
There's a few things like INT(1) that I'm using INTEGER for as well that could probably be switched to Sequelize.BOOLEAN. I know there's a number of BIGINT as well that I need to adjust.

This will work for now, I need to verify that `Sequelize.DATE(6)` is fully compatible first. There's a few things like `INT(1)` that I'm using `INTEGER` for as well that could probably be switched to `Sequelize.BOOLEAN`. I know there's a number of `BIGINT` as well that I need to adjust.
tiger5226 commented 2018-09-05 01:25:52 +02:00 (Migrated from github.com)
Review
Copy link

These are timestamps, is it ok to create it as an integer?

These are timestamps, is it ok to create it as an integer?
skhameneh commented 2018-09-05 02:36:40 +02:00 (Migrated from github.com)
Review
Copy link

This will work for now, I need to verify that Sequelize.DATE(6) is fully compatible first.
There's a few things like INT(1) that I'm using INTEGER for as well that could probably be switched to Sequelize.BOOLEAN. I know there's a number of BIGINT as well that I need to adjust.

This will work for now, I need to verify that `Sequelize.DATE(6)` is fully compatible first. There's a few things like `INT(1)` that I'm using `INTEGER` for as well that could probably be switched to `Sequelize.BOOLEAN`. I know there's a number of `BIGINT` as well that I need to adjust.
} }
export default (sequelize, { export default (sequelize, {
STRING, BOOLEAN, INTEGER, TEXT, DECIMAL BOOLEAN,
tiger5226 commented 2018-09-05 01:25:52 +02:00 (Migrated from github.com)
Review
Copy link

These are timestamps, is it ok to create it as an integer?

These are timestamps, is it ok to create it as an integer?
skhameneh commented 2018-09-05 02:36:40 +02:00 (Migrated from github.com)
Review
Copy link

This will work for now, I need to verify that Sequelize.DATE(6) is fully compatible first.
There's a few things like INT(1) that I'm using INTEGER for as well that could probably be switched to Sequelize.BOOLEAN. I know there's a number of BIGINT as well that I need to adjust.

This will work for now, I need to verify that `Sequelize.DATE(6)` is fully compatible first. There's a few things like `INT(1)` that I'm using `INTEGER` for as well that could probably be switched to `Sequelize.BOOLEAN`. I know there's a number of `BIGINT` as well that I need to adjust.
tiger5226 commented 2018-09-05 01:25:52 +02:00 (Migrated from github.com)
Review
Copy link

These are timestamps, is it ok to create it as an integer?

These are timestamps, is it ok to create it as an integer?
skhameneh commented 2018-09-05 02:36:40 +02:00 (Migrated from github.com)
Review
Copy link

This will work for now, I need to verify that Sequelize.DATE(6) is fully compatible first.
There's a few things like INT(1) that I'm using INTEGER for as well that could probably be switched to Sequelize.BOOLEAN. I know there's a number of BIGINT as well that I need to adjust.

This will work for now, I need to verify that `Sequelize.DATE(6)` is fully compatible first. There's a few things like `INT(1)` that I'm using `INTEGER` for as well that could probably be switched to `Sequelize.BOOLEAN`. I know there's a number of `BIGINT` as well that I need to adjust.
DATE,
tiger5226 commented 2018-09-05 01:25:52 +02:00 (Migrated from github.com)
Review
Copy link

These are timestamps, is it ok to create it as an integer?

These are timestamps, is it ok to create it as an integer?
skhameneh commented 2018-09-05 02:36:40 +02:00 (Migrated from github.com)
Review
Copy link

This will work for now, I need to verify that Sequelize.DATE(6) is fully compatible first.
There's a few things like INT(1) that I'm using INTEGER for as well that could probably be switched to Sequelize.BOOLEAN. I know there's a number of BIGINT as well that I need to adjust.

This will work for now, I need to verify that `Sequelize.DATE(6)` is fully compatible first. There's a few things like `INT(1)` that I'm using `INTEGER` for as well that could probably be switched to `Sequelize.BOOLEAN`. I know there's a number of `BIGINT` as well that I need to adjust.
DECIMAL,
tiger5226 commented 2018-09-05 01:25:52 +02:00 (Migrated from github.com)
Review
Copy link

These are timestamps, is it ok to create it as an integer?

These are timestamps, is it ok to create it as an integer?
skhameneh commented 2018-09-05 02:36:40 +02:00 (Migrated from github.com)
Review
Copy link

This will work for now, I need to verify that Sequelize.DATE(6) is fully compatible first.
There's a few things like INT(1) that I'm using INTEGER for as well that could probably be switched to Sequelize.BOOLEAN. I know there's a number of BIGINT as well that I need to adjust.

This will work for now, I need to verify that `Sequelize.DATE(6)` is fully compatible first. There's a few things like `INT(1)` that I'm using `INTEGER` for as well that could probably be switched to `Sequelize.BOOLEAN`. I know there's a number of `BIGINT` as well that I need to adjust.
INTEGER,
tiger5226 commented 2018-09-05 01:25:52 +02:00 (Migrated from github.com)
Review
Copy link

These are timestamps, is it ok to create it as an integer?

These are timestamps, is it ok to create it as an integer?
skhameneh commented 2018-09-05 02:36:40 +02:00 (Migrated from github.com)
Review
Copy link

This will work for now, I need to verify that Sequelize.DATE(6) is fully compatible first.
There's a few things like INT(1) that I'm using INTEGER for as well that could probably be switched to Sequelize.BOOLEAN. I know there's a number of BIGINT as well that I need to adjust.

This will work for now, I need to verify that `Sequelize.DATE(6)` is fully compatible first. There's a few things like `INT(1)` that I'm using `INTEGER` for as well that could probably be switched to `Sequelize.BOOLEAN`. I know there's a number of `BIGINT` as well that I need to adjust.
STRING,
tiger5226 commented 2018-09-05 01:25:52 +02:00 (Migrated from github.com)
Review
Copy link

These are timestamps, is it ok to create it as an integer?

These are timestamps, is it ok to create it as an integer?
skhameneh commented 2018-09-05 02:36:40 +02:00 (Migrated from github.com)
Review
Copy link

This will work for now, I need to verify that Sequelize.DATE(6) is fully compatible first.
There's a few things like INT(1) that I'm using INTEGER for as well that could probably be switched to Sequelize.BOOLEAN. I know there's a number of BIGINT as well that I need to adjust.

This will work for now, I need to verify that `Sequelize.DATE(6)` is fully compatible first. There's a few things like `INT(1)` that I'm using `INTEGER` for as well that could probably be switched to `Sequelize.BOOLEAN`. I know there's a number of `BIGINT` as well that I need to adjust.
TEXT,
tiger5226 commented 2018-09-05 01:25:52 +02:00 (Migrated from github.com)
Review
Copy link

These are timestamps, is it ok to create it as an integer?

These are timestamps, is it ok to create it as an integer?
skhameneh commented 2018-09-05 02:36:40 +02:00 (Migrated from github.com)
Review
Copy link

This will work for now, I need to verify that Sequelize.DATE(6) is fully compatible first.
There's a few things like INT(1) that I'm using INTEGER for as well that could probably be switched to Sequelize.BOOLEAN. I know there's a number of BIGINT as well that I need to adjust.

This will work for now, I need to verify that `Sequelize.DATE(6)` is fully compatible first. There's a few things like `INT(1)` that I'm using `INTEGER` for as well that could probably be switched to `Sequelize.BOOLEAN`. I know there's a number of `BIGINT` as well that I need to adjust.
}) => sequelize.define( }) => sequelize.define(
'abnormal_claim', 'abnormal_claim',
{ {
@ -21,7 +26,7 @@ export default (sequelize, {
tiger5226 commented 2018-09-05 01:25:52 +02:00 (Migrated from github.com)
Review
Copy link

These are timestamps, is it ok to create it as an integer?

These are timestamps, is it ok to create it as an integer?
skhameneh commented 2018-09-05 02:36:40 +02:00 (Migrated from github.com)
Review
Copy link

This will work for now, I need to verify that Sequelize.DATE(6) is fully compatible first.
There's a few things like INT(1) that I'm using INTEGER for as well that could probably be switched to Sequelize.BOOLEAN. I know there's a number of BIGINT as well that I need to adjust.

This will work for now, I need to verify that `Sequelize.DATE(6)` is fully compatible first. There's a few things like `INT(1)` that I'm using `INTEGER` for as well that could probably be switched to `Sequelize.BOOLEAN`. I know there's a number of `BIGINT` as well that I need to adjust.
tiger5226 commented 2018-09-05 01:25:52 +02:00 (Migrated from github.com)
Review
Copy link

These are timestamps, is it ok to create it as an integer?

These are timestamps, is it ok to create it as an integer?
skhameneh commented 2018-09-05 02:36:40 +02:00 (Migrated from github.com)
Review
Copy link

This will work for now, I need to verify that Sequelize.DATE(6) is fully compatible first.
There's a few things like INT(1) that I'm using INTEGER for as well that could probably be switched to Sequelize.BOOLEAN. I know there's a number of BIGINT as well that I need to adjust.

This will work for now, I need to verify that `Sequelize.DATE(6)` is fully compatible first. There's a few things like `INT(1)` that I'm using `INTEGER` for as well that could probably be switched to `Sequelize.BOOLEAN`. I know there's a number of `BIGINT` as well that I need to adjust.
set() { }, set() { },
}, },
is_update: { is_update: {
type: INTEGER, type: BOOLEAN,
tiger5226 commented 2018-09-05 01:25:52 +02:00 (Migrated from github.com)
Review
Copy link

These are timestamps, is it ok to create it as an integer?

These are timestamps, is it ok to create it as an integer?
skhameneh commented 2018-09-05 02:36:40 +02:00 (Migrated from github.com)
Review
Copy link

This will work for now, I need to verify that Sequelize.DATE(6) is fully compatible first.
There's a few things like INT(1) that I'm using INTEGER for as well that could probably be switched to Sequelize.BOOLEAN. I know there's a number of BIGINT as well that I need to adjust.

This will work for now, I need to verify that `Sequelize.DATE(6)` is fully compatible first. There's a few things like `INT(1)` that I'm using `INTEGER` for as well that could probably be switched to `Sequelize.BOOLEAN`. I know there's a number of `BIGINT` as well that I need to adjust.
tiger5226 commented 2018-09-05 01:25:52 +02:00 (Migrated from github.com)
Review
Copy link

These are timestamps, is it ok to create it as an integer?

These are timestamps, is it ok to create it as an integer?
skhameneh commented 2018-09-05 02:36:40 +02:00 (Migrated from github.com)
Review
Copy link

This will work for now, I need to verify that Sequelize.DATE(6) is fully compatible first.
There's a few things like INT(1) that I'm using INTEGER for as well that could probably be switched to Sequelize.BOOLEAN. I know there's a number of BIGINT as well that I need to adjust.

This will work for now, I need to verify that `Sequelize.DATE(6)` is fully compatible first. There's a few things like `INT(1)` that I'm using `INTEGER` for as well that could probably be switched to `Sequelize.BOOLEAN`. I know there's a number of `BIGINT` as well that I need to adjust.
set() { }, set() { },
}, },
block_hash: { block_hash: {
@ -49,11 +54,11 @@ export default (sequelize, {
tiger5226 commented 2018-09-05 01:25:52 +02:00 (Migrated from github.com)
Review
Copy link

These are timestamps, is it ok to create it as an integer?

These are timestamps, is it ok to create it as an integer?
skhameneh commented 2018-09-05 02:36:40 +02:00 (Migrated from github.com)
Review
Copy link

This will work for now, I need to verify that Sequelize.DATE(6) is fully compatible first.
There's a few things like INT(1) that I'm using INTEGER for as well that could probably be switched to Sequelize.BOOLEAN. I know there's a number of BIGINT as well that I need to adjust.

This will work for now, I need to verify that `Sequelize.DATE(6)` is fully compatible first. There's a few things like `INT(1)` that I'm using `INTEGER` for as well that could probably be switched to `Sequelize.BOOLEAN`. I know there's a number of `BIGINT` as well that I need to adjust.
tiger5226 commented 2018-09-05 01:25:52 +02:00 (Migrated from github.com)
Review
Copy link

These are timestamps, is it ok to create it as an integer?

These are timestamps, is it ok to create it as an integer?
skhameneh commented 2018-09-05 02:36:40 +02:00 (Migrated from github.com)
Review
Copy link

This will work for now, I need to verify that Sequelize.DATE(6) is fully compatible first.
There's a few things like INT(1) that I'm using INTEGER for as well that could probably be switched to Sequelize.BOOLEAN. I know there's a number of BIGINT as well that I need to adjust.

This will work for now, I need to verify that `Sequelize.DATE(6)` is fully compatible first. There's a few things like `INT(1)` that I'm using `INTEGER` for as well that could probably be switched to `Sequelize.BOOLEAN`. I know there's a number of `BIGINT` as well that I need to adjust.
set() { }, set() { },
}, },
created_at: { created_at: {
type: INTEGER, type: DATE(6),
tiger5226 commented 2018-09-05 01:25:52 +02:00 (Migrated from github.com)
Review
Copy link

These are timestamps, is it ok to create it as an integer?

These are timestamps, is it ok to create it as an integer?
skhameneh commented 2018-09-05 02:36:40 +02:00 (Migrated from github.com)
Review
Copy link

This will work for now, I need to verify that Sequelize.DATE(6) is fully compatible first.
There's a few things like INT(1) that I'm using INTEGER for as well that could probably be switched to Sequelize.BOOLEAN. I know there's a number of BIGINT as well that I need to adjust.

This will work for now, I need to verify that `Sequelize.DATE(6)` is fully compatible first. There's a few things like `INT(1)` that I'm using `INTEGER` for as well that could probably be switched to `Sequelize.BOOLEAN`. I know there's a number of `BIGINT` as well that I need to adjust.
tiger5226 commented 2018-09-05 01:25:52 +02:00 (Migrated from github.com)
Review
Copy link

These are timestamps, is it ok to create it as an integer?

These are timestamps, is it ok to create it as an integer?
skhameneh commented 2018-09-05 02:36:40 +02:00 (Migrated from github.com)
Review
Copy link

This will work for now, I need to verify that Sequelize.DATE(6) is fully compatible first.
There's a few things like INT(1) that I'm using INTEGER for as well that could probably be switched to Sequelize.BOOLEAN. I know there's a number of BIGINT as well that I need to adjust.

This will work for now, I need to verify that `Sequelize.DATE(6)` is fully compatible first. There's a few things like `INT(1)` that I'm using `INTEGER` for as well that could probably be switched to `Sequelize.BOOLEAN`. I know there's a number of `BIGINT` as well that I need to adjust.
set() { }, set() { },
}, },
modified_at: { modified_at: {
type: INTEGER, type: DATE(6),
tiger5226 commented 2018-09-05 01:25:52 +02:00 (Migrated from github.com)
Review
Copy link

These are timestamps, is it ok to create it as an integer?

These are timestamps, is it ok to create it as an integer?
skhameneh commented 2018-09-05 02:36:40 +02:00 (Migrated from github.com)
Review
Copy link

This will work for now, I need to verify that Sequelize.DATE(6) is fully compatible first.
There's a few things like INT(1) that I'm using INTEGER for as well that could probably be switched to Sequelize.BOOLEAN. I know there's a number of BIGINT as well that I need to adjust.

This will work for now, I need to verify that `Sequelize.DATE(6)` is fully compatible first. There's a few things like `INT(1)` that I'm using `INTEGER` for as well that could probably be switched to `Sequelize.BOOLEAN`. I know there's a number of `BIGINT` as well that I need to adjust.
tiger5226 commented 2018-09-05 01:25:52 +02:00 (Migrated from github.com)
Review
Copy link

These are timestamps, is it ok to create it as an integer?

These are timestamps, is it ok to create it as an integer?
skhameneh commented 2018-09-05 02:36:40 +02:00 (Migrated from github.com)
Review
Copy link

This will work for now, I need to verify that Sequelize.DATE(6) is fully compatible first.
There's a few things like INT(1) that I'm using INTEGER for as well that could probably be switched to Sequelize.BOOLEAN. I know there's a number of BIGINT as well that I need to adjust.

This will work for now, I need to verify that `Sequelize.DATE(6)` is fully compatible first. There's a few things like `INT(1)` that I'm using `INTEGER` for as well that could probably be switched to `Sequelize.BOOLEAN`. I know there's a number of `BIGINT` as well that I need to adjust.
set() { }, set() { },
}, },
}, },

tiger5226 commented 2018-09-05 01:25:52 +02:00 (Migrated from github.com)
Review
Copy link

These are timestamps, is it ok to create it as an integer?

These are timestamps, is it ok to create it as an integer?
skhameneh commented 2018-09-05 02:36:40 +02:00 (Migrated from github.com)
Review
Copy link

This will work for now, I need to verify that Sequelize.DATE(6) is fully compatible first.
There's a few things like INT(1) that I'm using INTEGER for as well that could probably be switched to Sequelize.BOOLEAN. I know there's a number of BIGINT as well that I need to adjust.

This will work for now, I need to verify that `Sequelize.DATE(6)` is fully compatible first. There's a few things like `INT(1)` that I'm using `INTEGER` for as well that could probably be switched to `Sequelize.BOOLEAN`. I know there's a number of `BIGINT` as well that I need to adjust.
tiger5226 commented 2018-09-05 01:25:52 +02:00 (Migrated from github.com)
Review
Copy link

These are timestamps, is it ok to create it as an integer?

These are timestamps, is it ok to create it as an integer?
skhameneh commented 2018-09-05 02:36:40 +02:00 (Migrated from github.com)
Review
Copy link

This will work for now, I need to verify that Sequelize.DATE(6) is fully compatible first.
There's a few things like INT(1) that I'm using INTEGER for as well that could probably be switched to Sequelize.BOOLEAN. I know there's a number of BIGINT as well that I need to adjust.

This will work for now, I need to verify that `Sequelize.DATE(6)` is fully compatible first. There's a few things like `INT(1)` that I'm using `INTEGER` for as well that could probably be switched to `Sequelize.BOOLEAN`. I know there's a number of `BIGINT` as well that I need to adjust.

13
server/chainquery/models/AddressModel.js
View file

@ -3,7 +3,12 @@ const getterMethods = {
} }
export default (sequelize, { export default (sequelize, {
STRING, BOOLEAN, INTEGER, TEXT, DECIMAL BOOLEAN,
DATE,
DECIMAL,
INTEGER,
STRING,
TEXT,
}) => sequelize.define( }) => sequelize.define(
'address', 'address',
{ {
@ -17,15 +22,15 @@ export default (sequelize, {
set() { }, set() { },
}, },
first_seen: { first_seen: {
type: INTEGER, type: DATE(6),
set() { }, set() { },
}, },
created_at: { created_at: {
type: INTEGER, type: DATE(6),
set() { }, set() { },
}, },
modified_at: { modified_at: {
type: INTEGER, type: DATE(6),
set() { }, set() { },
}, },
}, },

11
server/chainquery/models/BlockModel.js
View file

@ -3,7 +3,12 @@ const getterMethods = {
} }
export default (sequelize, { export default (sequelize, {
STRING, BOOLEAN, INTEGER, TEXT, DECIMAL BOOLEAN,
DATE,
DECIMAL,
INTEGER,
STRING,
TEXT,
}) => sequelize.define( }) => sequelize.define(
'block', 'block',
{ {
@ -81,11 +86,11 @@ export default (sequelize, {
set() { }, set() { },
}, },
created_at: { created_at: {
type: INTEGER, type: DATE(6),
set() { }, set() { },
}, },
modified_at: { modified_at: {
type: INTEGER, type: DATE(6),
set() { }, set() { },
}, },
}, },

15
server/chainquery/models/ClaimModel.js
View file

@ -35,7 +35,12 @@ const getterMethods = {
tiger5226 commented 2018-09-05 01:28:59 +02:00 (Migrated from github.com)
Review
Copy link

This is a boolean that is a TINYINT(1) in the database.

This is a boolean that is a `TINYINT(1)` in the database.
tiger5226 commented 2018-09-05 01:29:58 +02:00 (Migrated from github.com)
Review
Copy link

This is also an enumeration. I see that you set an enumeration above. Should this be listed as well? Active,Expired,Controlling,Spent,Accepted are the enumerations.

This is also an enumeration. I see that you set an enumeration above. Should this be listed as well? `Active,Expired,Controlling,Spent,Accepted` are the enumerations.
tiger5226 commented 2018-09-05 01:28:59 +02:00 (Migrated from github.com)
Review
Copy link

This is a boolean that is a TINYINT(1) in the database.

This is a boolean that is a `TINYINT(1)` in the database.
tiger5226 commented 2018-09-05 01:29:58 +02:00 (Migrated from github.com)
Review
Copy link

This is also an enumeration. I see that you set an enumeration above. Should this be listed as well? Active,Expired,Controlling,Spent,Accepted are the enumerations.

This is also an enumeration. I see that you set an enumeration above. Should this be listed as well? `Active,Expired,Controlling,Spent,Accepted` are the enumerations.
} }
export default (sequelize, { export default (sequelize, {
STRING, BOOLEAN, INTEGER, TEXT, DECIMAL BOOLEAN,
tiger5226 commented 2018-09-05 01:28:59 +02:00 (Migrated from github.com)
Review
Copy link

This is a boolean that is a TINYINT(1) in the database.

This is a boolean that is a `TINYINT(1)` in the database.
tiger5226 commented 2018-09-05 01:29:58 +02:00 (Migrated from github.com)
Review
Copy link

This is also an enumeration. I see that you set an enumeration above. Should this be listed as well? Active,Expired,Controlling,Spent,Accepted are the enumerations.

This is also an enumeration. I see that you set an enumeration above. Should this be listed as well? `Active,Expired,Controlling,Spent,Accepted` are the enumerations.
tiger5226 commented 2018-09-05 01:28:59 +02:00 (Migrated from github.com)
Review
Copy link

This is a boolean that is a TINYINT(1) in the database.

This is a boolean that is a `TINYINT(1)` in the database.
tiger5226 commented 2018-09-05 01:29:58 +02:00 (Migrated from github.com)
Review
Copy link

This is also an enumeration. I see that you set an enumeration above. Should this be listed as well? Active,Expired,Controlling,Spent,Accepted are the enumerations.

This is also an enumeration. I see that you set an enumeration above. Should this be listed as well? `Active,Expired,Controlling,Spent,Accepted` are the enumerations.
DATE,
tiger5226 commented 2018-09-05 01:28:59 +02:00 (Migrated from github.com)
Review
Copy link

This is a boolean that is a TINYINT(1) in the database.

This is a boolean that is a `TINYINT(1)` in the database.
tiger5226 commented 2018-09-05 01:29:58 +02:00 (Migrated from github.com)
Review
Copy link

This is also an enumeration. I see that you set an enumeration above. Should this be listed as well? Active,Expired,Controlling,Spent,Accepted are the enumerations.

This is also an enumeration. I see that you set an enumeration above. Should this be listed as well? `Active,Expired,Controlling,Spent,Accepted` are the enumerations.
DECIMAL,
tiger5226 commented 2018-09-05 01:28:59 +02:00 (Migrated from github.com)
Review
Copy link

This is a boolean that is a TINYINT(1) in the database.

This is a boolean that is a `TINYINT(1)` in the database.
tiger5226 commented 2018-09-05 01:29:58 +02:00 (Migrated from github.com)
Review
Copy link

This is also an enumeration. I see that you set an enumeration above. Should this be listed as well? Active,Expired,Controlling,Spent,Accepted are the enumerations.

This is also an enumeration. I see that you set an enumeration above. Should this be listed as well? `Active,Expired,Controlling,Spent,Accepted` are the enumerations.
INTEGER,
tiger5226 commented 2018-09-05 01:28:59 +02:00 (Migrated from github.com)
Review
Copy link

This is a boolean that is a TINYINT(1) in the database.

This is a boolean that is a `TINYINT(1)` in the database.
tiger5226 commented 2018-09-05 01:29:58 +02:00 (Migrated from github.com)
Review
Copy link

This is also an enumeration. I see that you set an enumeration above. Should this be listed as well? Active,Expired,Controlling,Spent,Accepted are the enumerations.

This is also an enumeration. I see that you set an enumeration above. Should this be listed as well? `Active,Expired,Controlling,Spent,Accepted` are the enumerations.
STRING,
tiger5226 commented 2018-09-05 01:28:59 +02:00 (Migrated from github.com)
Review
Copy link

This is a boolean that is a TINYINT(1) in the database.

This is a boolean that is a `TINYINT(1)` in the database.
tiger5226 commented 2018-09-05 01:29:58 +02:00 (Migrated from github.com)
Review
Copy link

This is also an enumeration. I see that you set an enumeration above. Should this be listed as well? Active,Expired,Controlling,Spent,Accepted are the enumerations.

This is also an enumeration. I see that you set an enumeration above. Should this be listed as well? `Active,Expired,Controlling,Spent,Accepted` are the enumerations.
TEXT,
tiger5226 commented 2018-09-05 01:28:59 +02:00 (Migrated from github.com)
Review
Copy link

This is a boolean that is a TINYINT(1) in the database.

This is a boolean that is a `TINYINT(1)` in the database.
tiger5226 commented 2018-09-05 01:29:58 +02:00 (Migrated from github.com)
Review
Copy link

This is also an enumeration. I see that you set an enumeration above. Should this be listed as well? Active,Expired,Controlling,Spent,Accepted are the enumerations.

This is also an enumeration. I see that you set an enumeration above. Should this be listed as well? `Active,Expired,Controlling,Spent,Accepted` are the enumerations.
}) => sequelize.define( }) => sequelize.define(
'claim', 'claim',
{ {
@ -121,7 +126,7 @@ export default (sequelize, {
tiger5226 commented 2018-09-05 01:28:59 +02:00 (Migrated from github.com)
Review
Copy link

This is a boolean that is a TINYINT(1) in the database.

This is a boolean that is a `TINYINT(1)` in the database.
tiger5226 commented 2018-09-05 01:29:58 +02:00 (Migrated from github.com)
Review
Copy link

This is also an enumeration. I see that you set an enumeration above. Should this be listed as well? Active,Expired,Controlling,Spent,Accepted are the enumerations.

This is also an enumeration. I see that you set an enumeration above. Should this be listed as well? `Active,Expired,Controlling,Spent,Accepted` are the enumerations.
tiger5226 commented 2018-09-05 01:28:59 +02:00 (Migrated from github.com)
Review
Copy link

This is a boolean that is a TINYINT(1) in the database.

This is a boolean that is a `TINYINT(1)` in the database.
tiger5226 commented 2018-09-05 01:29:58 +02:00 (Migrated from github.com)
Review
Copy link

This is also an enumeration. I see that you set an enumeration above. Should this be listed as well? Active,Expired,Controlling,Spent,Accepted are the enumerations.

This is also an enumeration. I see that you set an enumeration above. Should this be listed as well? `Active,Expired,Controlling,Spent,Accepted` are the enumerations.
set() { }, set() { },
}, },
is_nsfw: { is_nsfw: {
type: INTEGER, type: BOOLEAN,
tiger5226 commented 2018-09-05 01:28:59 +02:00 (Migrated from github.com)
Review
Copy link

This is a boolean that is a TINYINT(1) in the database.

This is a boolean that is a `TINYINT(1)` in the database.
tiger5226 commented 2018-09-05 01:29:58 +02:00 (Migrated from github.com)
Review
Copy link

This is also an enumeration. I see that you set an enumeration above. Should this be listed as well? Active,Expired,Controlling,Spent,Accepted are the enumerations.

This is also an enumeration. I see that you set an enumeration above. Should this be listed as well? `Active,Expired,Controlling,Spent,Accepted` are the enumerations.
tiger5226 commented 2018-09-05 01:28:59 +02:00 (Migrated from github.com)
Review
Copy link

This is a boolean that is a TINYINT(1) in the database.

This is a boolean that is a `TINYINT(1)` in the database.
tiger5226 commented 2018-09-05 01:29:58 +02:00 (Migrated from github.com)
Review
Copy link

This is also an enumeration. I see that you set an enumeration above. Should this be listed as well? Active,Expired,Controlling,Spent,Accepted are the enumerations.

This is also an enumeration. I see that you set an enumeration above. Should this be listed as well? `Active,Expired,Controlling,Spent,Accepted` are the enumerations.
set() { }, set() { },
}, },
language: { language: {
@ -145,7 +150,7 @@ export default (sequelize, {
tiger5226 commented 2018-09-05 01:28:59 +02:00 (Migrated from github.com)
Review
Copy link

This is a boolean that is a TINYINT(1) in the database.

This is a boolean that is a `TINYINT(1)` in the database.
tiger5226 commented 2018-09-05 01:29:58 +02:00 (Migrated from github.com)
Review
Copy link

This is also an enumeration. I see that you set an enumeration above. Should this be listed as well? Active,Expired,Controlling,Spent,Accepted are the enumerations.

This is also an enumeration. I see that you set an enumeration above. Should this be listed as well? `Active,Expired,Controlling,Spent,Accepted` are the enumerations.
tiger5226 commented 2018-09-05 01:28:59 +02:00 (Migrated from github.com)
Review
Copy link

This is a boolean that is a TINYINT(1) in the database.

This is a boolean that is a `TINYINT(1)` in the database.
tiger5226 commented 2018-09-05 01:29:58 +02:00 (Migrated from github.com)
Review
Copy link

This is also an enumeration. I see that you set an enumeration above. Should this be listed as well? Active,Expired,Controlling,Spent,Accepted are the enumerations.

This is also an enumeration. I see that you set an enumeration above. Should this be listed as well? `Active,Expired,Controlling,Spent,Accepted` are the enumerations.
set() { }, set() { },
}, },
is_filtered: { is_filtered: {
type: INTEGER, type: BOOLEAN,
tiger5226 commented 2018-09-05 01:28:59 +02:00 (Migrated from github.com)
Review
Copy link

This is a boolean that is a TINYINT(1) in the database.

This is a boolean that is a `TINYINT(1)` in the database.
tiger5226 commented 2018-09-05 01:29:58 +02:00 (Migrated from github.com)
Review
Copy link

This is also an enumeration. I see that you set an enumeration above. Should this be listed as well? Active,Expired,Controlling,Spent,Accepted are the enumerations.

This is also an enumeration. I see that you set an enumeration above. Should this be listed as well? `Active,Expired,Controlling,Spent,Accepted` are the enumerations.
tiger5226 commented 2018-09-05 01:28:59 +02:00 (Migrated from github.com)
Review
Copy link

This is a boolean that is a TINYINT(1) in the database.

This is a boolean that is a `TINYINT(1)` in the database.
tiger5226 commented 2018-09-05 01:29:58 +02:00 (Migrated from github.com)
Review
Copy link

This is also an enumeration. I see that you set an enumeration above. Should this be listed as well? Active,Expired,Controlling,Spent,Accepted are the enumerations.

This is also an enumeration. I see that you set an enumeration above. Should this be listed as well? `Active,Expired,Controlling,Spent,Accepted` are the enumerations.
set() { }, set() { },
}, },
bid_state: { bid_state: {
@ -153,11 +158,11 @@ export default (sequelize, {
tiger5226 commented 2018-09-05 01:28:59 +02:00 (Migrated from github.com)
Review
Copy link

This is a boolean that is a TINYINT(1) in the database.

This is a boolean that is a `TINYINT(1)` in the database.
tiger5226 commented 2018-09-05 01:29:58 +02:00 (Migrated from github.com)
Review
Copy link

This is also an enumeration. I see that you set an enumeration above. Should this be listed as well? Active,Expired,Controlling,Spent,Accepted are the enumerations.

This is also an enumeration. I see that you set an enumeration above. Should this be listed as well? `Active,Expired,Controlling,Spent,Accepted` are the enumerations.
tiger5226 commented 2018-09-05 01:28:59 +02:00 (Migrated from github.com)
Review
Copy link

This is a boolean that is a TINYINT(1) in the database.

This is a boolean that is a `TINYINT(1)` in the database.
tiger5226 commented 2018-09-05 01:29:58 +02:00 (Migrated from github.com)
Review
Copy link

This is also an enumeration. I see that you set an enumeration above. Should this be listed as well? Active,Expired,Controlling,Spent,Accepted are the enumerations.

This is also an enumeration. I see that you set an enumeration above. Should this be listed as well? `Active,Expired,Controlling,Spent,Accepted` are the enumerations.
set() { }, set() { },
}, },
created_at: { created_at: {
type: INTEGER, type: DATE(6),
tiger5226 commented 2018-09-05 01:28:59 +02:00 (Migrated from github.com)
Review
Copy link

This is a boolean that is a TINYINT(1) in the database.

This is a boolean that is a `TINYINT(1)` in the database.
tiger5226 commented 2018-09-05 01:29:58 +02:00 (Migrated from github.com)
Review
Copy link

This is also an enumeration. I see that you set an enumeration above. Should this be listed as well? Active,Expired,Controlling,Spent,Accepted are the enumerations.

This is also an enumeration. I see that you set an enumeration above. Should this be listed as well? `Active,Expired,Controlling,Spent,Accepted` are the enumerations.
tiger5226 commented 2018-09-05 01:28:59 +02:00 (Migrated from github.com)
Review
Copy link

This is a boolean that is a TINYINT(1) in the database.

This is a boolean that is a `TINYINT(1)` in the database.
tiger5226 commented 2018-09-05 01:29:58 +02:00 (Migrated from github.com)
Review
Copy link

This is also an enumeration. I see that you set an enumeration above. Should this be listed as well? Active,Expired,Controlling,Spent,Accepted are the enumerations.

This is also an enumeration. I see that you set an enumeration above. Should this be listed as well? `Active,Expired,Controlling,Spent,Accepted` are the enumerations.
set() { }, set() { },
}, },
modified_at: { modified_at: {
type: INTEGER, type: DATE(6),
tiger5226 commented 2018-09-05 01:28:59 +02:00 (Migrated from github.com)
Review
Copy link

This is a boolean that is a TINYINT(1) in the database.

This is a boolean that is a `TINYINT(1)` in the database.
tiger5226 commented 2018-09-05 01:29:58 +02:00 (Migrated from github.com)
Review
Copy link

This is also an enumeration. I see that you set an enumeration above. Should this be listed as well? Active,Expired,Controlling,Spent,Accepted are the enumerations.

This is also an enumeration. I see that you set an enumeration above. Should this be listed as well? `Active,Expired,Controlling,Spent,Accepted` are the enumerations.
tiger5226 commented 2018-09-05 01:28:59 +02:00 (Migrated from github.com)
Review
Copy link

This is a boolean that is a TINYINT(1) in the database.

This is a boolean that is a `TINYINT(1)` in the database.
tiger5226 commented 2018-09-05 01:29:58 +02:00 (Migrated from github.com)
Review
Copy link

This is also an enumeration. I see that you set an enumeration above. Should this be listed as well? Active,Expired,Controlling,Spent,Accepted are the enumerations.

This is also an enumeration. I see that you set an enumeration above. Should this be listed as well? `Active,Expired,Controlling,Spent,Accepted` are the enumerations.
set() { }, set() { },
}, },
fee_address: { fee_address: {

tiger5226 commented 2018-09-05 01:28:59 +02:00 (Migrated from github.com)
Review
Copy link

This is a boolean that is a TINYINT(1) in the database.

This is a boolean that is a `TINYINT(1)` in the database.
tiger5226 commented 2018-09-05 01:29:58 +02:00 (Migrated from github.com)
Review
Copy link

This is also an enumeration. I see that you set an enumeration above. Should this be listed as well? Active,Expired,Controlling,Spent,Accepted are the enumerations.

This is also an enumeration. I see that you set an enumeration above. Should this be listed as well? `Active,Expired,Controlling,Spent,Accepted` are the enumerations.
tiger5226 commented 2018-09-05 01:28:59 +02:00 (Migrated from github.com)
Review
Copy link

This is a boolean that is a TINYINT(1) in the database.

This is a boolean that is a `TINYINT(1)` in the database.
tiger5226 commented 2018-09-05 01:29:58 +02:00 (Migrated from github.com)
Review
Copy link

This is also an enumeration. I see that you set an enumeration above. Should this be listed as well? Active,Expired,Controlling,Spent,Accepted are the enumerations.

This is also an enumeration. I see that you set an enumeration above. Should this be listed as well? `Active,Expired,Controlling,Spent,Accepted` are the enumerations.

15
server/chainquery/models/InputModel.js
View file

@ -3,7 +3,12 @@ const getterMethods = {
tiger5226 commented 2018-09-05 01:30:22 +02:00 (Migrated from github.com)
Review
Copy link

boolean

boolean
tiger5226 commented 2018-09-05 01:30:46 +02:00 (Migrated from github.com)
Review
Copy link

this is unsigned. Does it matter that you treat it as just an integer?

this is unsigned. Does it matter that you treat it as just an integer?
skhameneh commented 2018-09-05 02:42:19 +02:00 (Migrated from github.com)
Review
Copy link

Ha, alright! I didn't realize TINYINT(1) is exactly the same as BOOL
https://dev.mysql.com/doc/refman/5.7/en/numeric-type-overview.html

BOOL, BOOLEAN
These types are synonyms for TINYINT(1). A value of zero is considered false. Nonzero values are considered true

Ha, alright! I didn't realize `TINYINT(1)` is exactly the same as `BOOL` https://dev.mysql.com/doc/refman/5.7/en/numeric-type-overview.html > **BOOL, BOOLEAN** > These types are synonyms for TINYINT(1). A value of zero is considered false. Nonzero values are considered true
tiger5226 commented 2018-09-05 01:30:22 +02:00 (Migrated from github.com)
Review
Copy link

boolean

boolean
tiger5226 commented 2018-09-05 01:30:46 +02:00 (Migrated from github.com)
Review
Copy link

this is unsigned. Does it matter that you treat it as just an integer?

this is unsigned. Does it matter that you treat it as just an integer?
skhameneh commented 2018-09-05 02:42:19 +02:00 (Migrated from github.com)
Review
Copy link

Ha, alright! I didn't realize TINYINT(1) is exactly the same as BOOL
https://dev.mysql.com/doc/refman/5.7/en/numeric-type-overview.html

BOOL, BOOLEAN
These types are synonyms for TINYINT(1). A value of zero is considered false. Nonzero values are considered true

Ha, alright! I didn't realize `TINYINT(1)` is exactly the same as `BOOL` https://dev.mysql.com/doc/refman/5.7/en/numeric-type-overview.html > **BOOL, BOOLEAN** > These types are synonyms for TINYINT(1). A value of zero is considered false. Nonzero values are considered true
} }
export default (sequelize, { export default (sequelize, {
STRING, BOOLEAN, INTEGER, TEXT, DECIMAL BOOLEAN,
tiger5226 commented 2018-09-05 01:30:22 +02:00 (Migrated from github.com)
Review
Copy link

boolean

boolean
tiger5226 commented 2018-09-05 01:30:46 +02:00 (Migrated from github.com)
Review
Copy link

this is unsigned. Does it matter that you treat it as just an integer?

this is unsigned. Does it matter that you treat it as just an integer?
skhameneh commented 2018-09-05 02:42:19 +02:00 (Migrated from github.com)
Review
Copy link

Ha, alright! I didn't realize TINYINT(1) is exactly the same as BOOL
https://dev.mysql.com/doc/refman/5.7/en/numeric-type-overview.html

BOOL, BOOLEAN
These types are synonyms for TINYINT(1). A value of zero is considered false. Nonzero values are considered true

Ha, alright! I didn't realize `TINYINT(1)` is exactly the same as `BOOL` https://dev.mysql.com/doc/refman/5.7/en/numeric-type-overview.html > **BOOL, BOOLEAN** > These types are synonyms for TINYINT(1). A value of zero is considered false. Nonzero values are considered true
tiger5226 commented 2018-09-05 01:30:22 +02:00 (Migrated from github.com)
Review
Copy link

boolean

boolean
tiger5226 commented 2018-09-05 01:30:46 +02:00 (Migrated from github.com)
Review
Copy link

this is unsigned. Does it matter that you treat it as just an integer?

this is unsigned. Does it matter that you treat it as just an integer?
skhameneh commented 2018-09-05 02:42:19 +02:00 (Migrated from github.com)
Review
Copy link

Ha, alright! I didn't realize TINYINT(1) is exactly the same as BOOL
https://dev.mysql.com/doc/refman/5.7/en/numeric-type-overview.html

BOOL, BOOLEAN
These types are synonyms for TINYINT(1). A value of zero is considered false. Nonzero values are considered true

Ha, alright! I didn't realize `TINYINT(1)` is exactly the same as `BOOL` https://dev.mysql.com/doc/refman/5.7/en/numeric-type-overview.html > **BOOL, BOOLEAN** > These types are synonyms for TINYINT(1). A value of zero is considered false. Nonzero values are considered true
DATE,
tiger5226 commented 2018-09-05 01:30:22 +02:00 (Migrated from github.com)
Review
Copy link

boolean

boolean
tiger5226 commented 2018-09-05 01:30:46 +02:00 (Migrated from github.com)
Review
Copy link

this is unsigned. Does it matter that you treat it as just an integer?

this is unsigned. Does it matter that you treat it as just an integer?
skhameneh commented 2018-09-05 02:42:19 +02:00 (Migrated from github.com)
Review
Copy link

Ha, alright! I didn't realize TINYINT(1) is exactly the same as BOOL
https://dev.mysql.com/doc/refman/5.7/en/numeric-type-overview.html

BOOL, BOOLEAN
These types are synonyms for TINYINT(1). A value of zero is considered false. Nonzero values are considered true

Ha, alright! I didn't realize `TINYINT(1)` is exactly the same as `BOOL` https://dev.mysql.com/doc/refman/5.7/en/numeric-type-overview.html > **BOOL, BOOLEAN** > These types are synonyms for TINYINT(1). A value of zero is considered false. Nonzero values are considered true
DECIMAL,
tiger5226 commented 2018-09-05 01:30:22 +02:00 (Migrated from github.com)
Review
Copy link

boolean

boolean
tiger5226 commented 2018-09-05 01:30:46 +02:00 (Migrated from github.com)
Review
Copy link

this is unsigned. Does it matter that you treat it as just an integer?

this is unsigned. Does it matter that you treat it as just an integer?
skhameneh commented 2018-09-05 02:42:19 +02:00 (Migrated from github.com)
Review
Copy link

Ha, alright! I didn't realize TINYINT(1) is exactly the same as BOOL
https://dev.mysql.com/doc/refman/5.7/en/numeric-type-overview.html

BOOL, BOOLEAN
These types are synonyms for TINYINT(1). A value of zero is considered false. Nonzero values are considered true

Ha, alright! I didn't realize `TINYINT(1)` is exactly the same as `BOOL` https://dev.mysql.com/doc/refman/5.7/en/numeric-type-overview.html > **BOOL, BOOLEAN** > These types are synonyms for TINYINT(1). A value of zero is considered false. Nonzero values are considered true
INTEGER,
tiger5226 commented 2018-09-05 01:30:22 +02:00 (Migrated from github.com)
Review
Copy link

boolean

boolean
tiger5226 commented 2018-09-05 01:30:46 +02:00 (Migrated from github.com)
Review
Copy link

this is unsigned. Does it matter that you treat it as just an integer?

this is unsigned. Does it matter that you treat it as just an integer?
skhameneh commented 2018-09-05 02:42:19 +02:00 (Migrated from github.com)
Review
Copy link

Ha, alright! I didn't realize TINYINT(1) is exactly the same as BOOL
https://dev.mysql.com/doc/refman/5.7/en/numeric-type-overview.html

BOOL, BOOLEAN
These types are synonyms for TINYINT(1). A value of zero is considered false. Nonzero values are considered true

Ha, alright! I didn't realize `TINYINT(1)` is exactly the same as `BOOL` https://dev.mysql.com/doc/refman/5.7/en/numeric-type-overview.html > **BOOL, BOOLEAN** > These types are synonyms for TINYINT(1). A value of zero is considered false. Nonzero values are considered true
STRING,
tiger5226 commented 2018-09-05 01:30:22 +02:00 (Migrated from github.com)
Review
Copy link

boolean

boolean
tiger5226 commented 2018-09-05 01:30:46 +02:00 (Migrated from github.com)
Review
Copy link

this is unsigned. Does it matter that you treat it as just an integer?

this is unsigned. Does it matter that you treat it as just an integer?
skhameneh commented 2018-09-05 02:42:19 +02:00 (Migrated from github.com)
Review
Copy link

Ha, alright! I didn't realize TINYINT(1) is exactly the same as BOOL
https://dev.mysql.com/doc/refman/5.7/en/numeric-type-overview.html

BOOL, BOOLEAN
These types are synonyms for TINYINT(1). A value of zero is considered false. Nonzero values are considered true

Ha, alright! I didn't realize `TINYINT(1)` is exactly the same as `BOOL` https://dev.mysql.com/doc/refman/5.7/en/numeric-type-overview.html > **BOOL, BOOLEAN** > These types are synonyms for TINYINT(1). A value of zero is considered false. Nonzero values are considered true
TEXT,
tiger5226 commented 2018-09-05 01:30:22 +02:00 (Migrated from github.com)
Review
Copy link

boolean

boolean
tiger5226 commented 2018-09-05 01:30:46 +02:00 (Migrated from github.com)
Review
Copy link

this is unsigned. Does it matter that you treat it as just an integer?

this is unsigned. Does it matter that you treat it as just an integer?
skhameneh commented 2018-09-05 02:42:19 +02:00 (Migrated from github.com)
Review
Copy link

Ha, alright! I didn't realize TINYINT(1) is exactly the same as BOOL
https://dev.mysql.com/doc/refman/5.7/en/numeric-type-overview.html

BOOL, BOOLEAN
These types are synonyms for TINYINT(1). A value of zero is considered false. Nonzero values are considered true

Ha, alright! I didn't realize `TINYINT(1)` is exactly the same as `BOOL` https://dev.mysql.com/doc/refman/5.7/en/numeric-type-overview.html > **BOOL, BOOLEAN** > These types are synonyms for TINYINT(1). A value of zero is considered false. Nonzero values are considered true
}) => sequelize.define( }) => sequelize.define(
'input', 'input',
{ {
@ -25,7 +30,7 @@ export default (sequelize, {
tiger5226 commented 2018-09-05 01:30:22 +02:00 (Migrated from github.com)
Review
Copy link

boolean

boolean
tiger5226 commented 2018-09-05 01:30:46 +02:00 (Migrated from github.com)
Review
Copy link

this is unsigned. Does it matter that you treat it as just an integer?

this is unsigned. Does it matter that you treat it as just an integer?
skhameneh commented 2018-09-05 02:42:19 +02:00 (Migrated from github.com)
Review
Copy link

Ha, alright! I didn't realize TINYINT(1) is exactly the same as BOOL
https://dev.mysql.com/doc/refman/5.7/en/numeric-type-overview.html

BOOL, BOOLEAN
These types are synonyms for TINYINT(1). A value of zero is considered false. Nonzero values are considered true

Ha, alright! I didn't realize `TINYINT(1)` is exactly the same as `BOOL` https://dev.mysql.com/doc/refman/5.7/en/numeric-type-overview.html > **BOOL, BOOLEAN** > These types are synonyms for TINYINT(1). A value of zero is considered false. Nonzero values are considered true
tiger5226 commented 2018-09-05 01:30:22 +02:00 (Migrated from github.com)
Review
Copy link

boolean

boolean
tiger5226 commented 2018-09-05 01:30:46 +02:00 (Migrated from github.com)
Review
Copy link

this is unsigned. Does it matter that you treat it as just an integer?

this is unsigned. Does it matter that you treat it as just an integer?
skhameneh commented 2018-09-05 02:42:19 +02:00 (Migrated from github.com)
Review
Copy link

Ha, alright! I didn't realize TINYINT(1) is exactly the same as BOOL
https://dev.mysql.com/doc/refman/5.7/en/numeric-type-overview.html

BOOL, BOOLEAN
These types are synonyms for TINYINT(1). A value of zero is considered false. Nonzero values are considered true

Ha, alright! I didn't realize `TINYINT(1)` is exactly the same as `BOOL` https://dev.mysql.com/doc/refman/5.7/en/numeric-type-overview.html > **BOOL, BOOLEAN** > These types are synonyms for TINYINT(1). A value of zero is considered false. Nonzero values are considered true
set() { }, set() { },
}, },
is_coinbase: { is_coinbase: {
type: INTEGER, type: BOOLEAN,
tiger5226 commented 2018-09-05 01:30:22 +02:00 (Migrated from github.com)
Review
Copy link

boolean

boolean
tiger5226 commented 2018-09-05 01:30:46 +02:00 (Migrated from github.com)
Review
Copy link

this is unsigned. Does it matter that you treat it as just an integer?

this is unsigned. Does it matter that you treat it as just an integer?
skhameneh commented 2018-09-05 02:42:19 +02:00 (Migrated from github.com)
Review
Copy link

Ha, alright! I didn't realize TINYINT(1) is exactly the same as BOOL
https://dev.mysql.com/doc/refman/5.7/en/numeric-type-overview.html

BOOL, BOOLEAN
These types are synonyms for TINYINT(1). A value of zero is considered false. Nonzero values are considered true

Ha, alright! I didn't realize `TINYINT(1)` is exactly the same as `BOOL` https://dev.mysql.com/doc/refman/5.7/en/numeric-type-overview.html > **BOOL, BOOLEAN** > These types are synonyms for TINYINT(1). A value of zero is considered false. Nonzero values are considered true
tiger5226 commented 2018-09-05 01:30:22 +02:00 (Migrated from github.com)
Review
Copy link

boolean

boolean
tiger5226 commented 2018-09-05 01:30:46 +02:00 (Migrated from github.com)
Review
Copy link

this is unsigned. Does it matter that you treat it as just an integer?

this is unsigned. Does it matter that you treat it as just an integer?
skhameneh commented 2018-09-05 02:42:19 +02:00 (Migrated from github.com)
Review
Copy link

Ha, alright! I didn't realize TINYINT(1) is exactly the same as BOOL
https://dev.mysql.com/doc/refman/5.7/en/numeric-type-overview.html

BOOL, BOOLEAN
These types are synonyms for TINYINT(1). A value of zero is considered false. Nonzero values are considered true

Ha, alright! I didn't realize `TINYINT(1)` is exactly the same as `BOOL` https://dev.mysql.com/doc/refman/5.7/en/numeric-type-overview.html > **BOOL, BOOLEAN** > These types are synonyms for TINYINT(1). A value of zero is considered false. Nonzero values are considered true
set() { }, set() { },
}, },
coinbase: { coinbase: {
@ -37,7 +42,7 @@ export default (sequelize, {
tiger5226 commented 2018-09-05 01:30:22 +02:00 (Migrated from github.com)
Review
Copy link

boolean

boolean
tiger5226 commented 2018-09-05 01:30:46 +02:00 (Migrated from github.com)
Review
Copy link

this is unsigned. Does it matter that you treat it as just an integer?

this is unsigned. Does it matter that you treat it as just an integer?
skhameneh commented 2018-09-05 02:42:19 +02:00 (Migrated from github.com)
Review
Copy link

Ha, alright! I didn't realize TINYINT(1) is exactly the same as BOOL
https://dev.mysql.com/doc/refman/5.7/en/numeric-type-overview.html

BOOL, BOOLEAN
These types are synonyms for TINYINT(1). A value of zero is considered false. Nonzero values are considered true

Ha, alright! I didn't realize `TINYINT(1)` is exactly the same as `BOOL` https://dev.mysql.com/doc/refman/5.7/en/numeric-type-overview.html > **BOOL, BOOLEAN** > These types are synonyms for TINYINT(1). A value of zero is considered false. Nonzero values are considered true
tiger5226 commented 2018-09-05 01:30:22 +02:00 (Migrated from github.com)
Review
Copy link

boolean

boolean
tiger5226 commented 2018-09-05 01:30:46 +02:00 (Migrated from github.com)
Review
Copy link

this is unsigned. Does it matter that you treat it as just an integer?

this is unsigned. Does it matter that you treat it as just an integer?
skhameneh commented 2018-09-05 02:42:19 +02:00 (Migrated from github.com)
Review
Copy link

Ha, alright! I didn't realize TINYINT(1) is exactly the same as BOOL
https://dev.mysql.com/doc/refman/5.7/en/numeric-type-overview.html

BOOL, BOOLEAN
These types are synonyms for TINYINT(1). A value of zero is considered false. Nonzero values are considered true

Ha, alright! I didn't realize `TINYINT(1)` is exactly the same as `BOOL` https://dev.mysql.com/doc/refman/5.7/en/numeric-type-overview.html > **BOOL, BOOLEAN** > These types are synonyms for TINYINT(1). A value of zero is considered false. Nonzero values are considered true
set() { }, set() { },
}, },
prevout_n: { prevout_n: {
type: INTEGER, type: INTEGER.UNSIGNED,
tiger5226 commented 2018-09-05 01:30:22 +02:00 (Migrated from github.com)
Review
Copy link

boolean

boolean
tiger5226 commented 2018-09-05 01:30:46 +02:00 (Migrated from github.com)
Review
Copy link

this is unsigned. Does it matter that you treat it as just an integer?

this is unsigned. Does it matter that you treat it as just an integer?
skhameneh commented 2018-09-05 02:42:19 +02:00 (Migrated from github.com)
Review
Copy link

Ha, alright! I didn't realize TINYINT(1) is exactly the same as BOOL
https://dev.mysql.com/doc/refman/5.7/en/numeric-type-overview.html

BOOL, BOOLEAN
These types are synonyms for TINYINT(1). A value of zero is considered false. Nonzero values are considered true

Ha, alright! I didn't realize `TINYINT(1)` is exactly the same as `BOOL` https://dev.mysql.com/doc/refman/5.7/en/numeric-type-overview.html > **BOOL, BOOLEAN** > These types are synonyms for TINYINT(1). A value of zero is considered false. Nonzero values are considered true
tiger5226 commented 2018-09-05 01:30:22 +02:00 (Migrated from github.com)
Review
Copy link

boolean

boolean
tiger5226 commented 2018-09-05 01:30:46 +02:00 (Migrated from github.com)
Review
Copy link

this is unsigned. Does it matter that you treat it as just an integer?

this is unsigned. Does it matter that you treat it as just an integer?
skhameneh commented 2018-09-05 02:42:19 +02:00 (Migrated from github.com)
Review
Copy link

Ha, alright! I didn't realize TINYINT(1) is exactly the same as BOOL
https://dev.mysql.com/doc/refman/5.7/en/numeric-type-overview.html

BOOL, BOOLEAN
These types are synonyms for TINYINT(1). A value of zero is considered false. Nonzero values are considered true

Ha, alright! I didn't realize `TINYINT(1)` is exactly the same as `BOOL` https://dev.mysql.com/doc/refman/5.7/en/numeric-type-overview.html > **BOOL, BOOLEAN** > These types are synonyms for TINYINT(1). A value of zero is considered false. Nonzero values are considered true
set() { }, set() { },
}, },
prevout_spend_updated: { prevout_spend_updated: {
@ -61,11 +66,11 @@ export default (sequelize, {
tiger5226 commented 2018-09-05 01:30:22 +02:00 (Migrated from github.com)
Review
Copy link

boolean

boolean
tiger5226 commented 2018-09-05 01:30:46 +02:00 (Migrated from github.com)
Review
Copy link

this is unsigned. Does it matter that you treat it as just an integer?

this is unsigned. Does it matter that you treat it as just an integer?
skhameneh commented 2018-09-05 02:42:19 +02:00 (Migrated from github.com)
Review
Copy link

Ha, alright! I didn't realize TINYINT(1) is exactly the same as BOOL
https://dev.mysql.com/doc/refman/5.7/en/numeric-type-overview.html

BOOL, BOOLEAN
These types are synonyms for TINYINT(1). A value of zero is considered false. Nonzero values are considered true

Ha, alright! I didn't realize `TINYINT(1)` is exactly the same as `BOOL` https://dev.mysql.com/doc/refman/5.7/en/numeric-type-overview.html > **BOOL, BOOLEAN** > These types are synonyms for TINYINT(1). A value of zero is considered false. Nonzero values are considered true
tiger5226 commented 2018-09-05 01:30:22 +02:00 (Migrated from github.com)
Review
Copy link

boolean

boolean
tiger5226 commented 2018-09-05 01:30:46 +02:00 (Migrated from github.com)
Review
Copy link

this is unsigned. Does it matter that you treat it as just an integer?

this is unsigned. Does it matter that you treat it as just an integer?
skhameneh commented 2018-09-05 02:42:19 +02:00 (Migrated from github.com)
Review
Copy link

Ha, alright! I didn't realize TINYINT(1) is exactly the same as BOOL
https://dev.mysql.com/doc/refman/5.7/en/numeric-type-overview.html

BOOL, BOOLEAN
These types are synonyms for TINYINT(1). A value of zero is considered false. Nonzero values are considered true

Ha, alright! I didn't realize `TINYINT(1)` is exactly the same as `BOOL` https://dev.mysql.com/doc/refman/5.7/en/numeric-type-overview.html > **BOOL, BOOLEAN** > These types are synonyms for TINYINT(1). A value of zero is considered false. Nonzero values are considered true
set() { }, set() { },
}, },
created: { created: {
type: INTEGER, type: DATE(6),
tiger5226 commented 2018-09-05 01:30:22 +02:00 (Migrated from github.com)
Review
Copy link

boolean

boolean
tiger5226 commented 2018-09-05 01:30:46 +02:00 (Migrated from github.com)
Review
Copy link

this is unsigned. Does it matter that you treat it as just an integer?

this is unsigned. Does it matter that you treat it as just an integer?
skhameneh commented 2018-09-05 02:42:19 +02:00 (Migrated from github.com)
Review
Copy link

Ha, alright! I didn't realize TINYINT(1) is exactly the same as BOOL
https://dev.mysql.com/doc/refman/5.7/en/numeric-type-overview.html

BOOL, BOOLEAN
These types are synonyms for TINYINT(1). A value of zero is considered false. Nonzero values are considered true

Ha, alright! I didn't realize `TINYINT(1)` is exactly the same as `BOOL` https://dev.mysql.com/doc/refman/5.7/en/numeric-type-overview.html > **BOOL, BOOLEAN** > These types are synonyms for TINYINT(1). A value of zero is considered false. Nonzero values are considered true
tiger5226 commented 2018-09-05 01:30:22 +02:00 (Migrated from github.com)
Review
Copy link

boolean

boolean
tiger5226 commented 2018-09-05 01:30:46 +02:00 (Migrated from github.com)
Review
Copy link

this is unsigned. Does it matter that you treat it as just an integer?

this is unsigned. Does it matter that you treat it as just an integer?
skhameneh commented 2018-09-05 02:42:19 +02:00 (Migrated from github.com)
Review
Copy link

Ha, alright! I didn't realize TINYINT(1) is exactly the same as BOOL
https://dev.mysql.com/doc/refman/5.7/en/numeric-type-overview.html

BOOL, BOOLEAN
These types are synonyms for TINYINT(1). A value of zero is considered false. Nonzero values are considered true

Ha, alright! I didn't realize `TINYINT(1)` is exactly the same as `BOOL` https://dev.mysql.com/doc/refman/5.7/en/numeric-type-overview.html > **BOOL, BOOLEAN** > These types are synonyms for TINYINT(1). A value of zero is considered false. Nonzero values are considered true
set() { }, set() { },
}, },
modified: { modified: {
type: INTEGER, type: DATE(6),
tiger5226 commented 2018-09-05 01:30:22 +02:00 (Migrated from github.com)
Review
Copy link

boolean

boolean
tiger5226 commented 2018-09-05 01:30:46 +02:00 (Migrated from github.com)
Review
Copy link

this is unsigned. Does it matter that you treat it as just an integer?

this is unsigned. Does it matter that you treat it as just an integer?
skhameneh commented 2018-09-05 02:42:19 +02:00 (Migrated from github.com)
Review
Copy link

Ha, alright! I didn't realize TINYINT(1) is exactly the same as BOOL
https://dev.mysql.com/doc/refman/5.7/en/numeric-type-overview.html

BOOL, BOOLEAN
These types are synonyms for TINYINT(1). A value of zero is considered false. Nonzero values are considered true

Ha, alright! I didn't realize `TINYINT(1)` is exactly the same as `BOOL` https://dev.mysql.com/doc/refman/5.7/en/numeric-type-overview.html > **BOOL, BOOLEAN** > These types are synonyms for TINYINT(1). A value of zero is considered false. Nonzero values are considered true
tiger5226 commented 2018-09-05 01:30:22 +02:00 (Migrated from github.com)
Review
Copy link

boolean

boolean
tiger5226 commented 2018-09-05 01:30:46 +02:00 (Migrated from github.com)
Review
Copy link

this is unsigned. Does it matter that you treat it as just an integer?

this is unsigned. Does it matter that you treat it as just an integer?
skhameneh commented 2018-09-05 02:42:19 +02:00 (Migrated from github.com)
Review
Copy link

Ha, alright! I didn't realize TINYINT(1) is exactly the same as BOOL
https://dev.mysql.com/doc/refman/5.7/en/numeric-type-overview.html

BOOL, BOOLEAN
These types are synonyms for TINYINT(1). A value of zero is considered false. Nonzero values are considered true

Ha, alright! I didn't realize `TINYINT(1)` is exactly the same as `BOOL` https://dev.mysql.com/doc/refman/5.7/en/numeric-type-overview.html > **BOOL, BOOLEAN** > These types are synonyms for TINYINT(1). A value of zero is considered false. Nonzero values are considered true
set() { }, set() { },
}, },
}, },

tiger5226 commented 2018-09-05 01:30:22 +02:00 (Migrated from github.com)
Review
Copy link

boolean

boolean
tiger5226 commented 2018-09-05 01:30:46 +02:00 (Migrated from github.com)
Review
Copy link

this is unsigned. Does it matter that you treat it as just an integer?

this is unsigned. Does it matter that you treat it as just an integer?
skhameneh commented 2018-09-05 02:42:19 +02:00 (Migrated from github.com)
Review
Copy link

Ha, alright! I didn't realize TINYINT(1) is exactly the same as BOOL
https://dev.mysql.com/doc/refman/5.7/en/numeric-type-overview.html

BOOL, BOOLEAN
These types are synonyms for TINYINT(1). A value of zero is considered false. Nonzero values are considered true

Ha, alright! I didn't realize `TINYINT(1)` is exactly the same as `BOOL` https://dev.mysql.com/doc/refman/5.7/en/numeric-type-overview.html > **BOOL, BOOLEAN** > These types are synonyms for TINYINT(1). A value of zero is considered false. Nonzero values are considered true
tiger5226 commented 2018-09-05 01:30:22 +02:00 (Migrated from github.com)
Review
Copy link

boolean

boolean
tiger5226 commented 2018-09-05 01:30:46 +02:00 (Migrated from github.com)
Review
Copy link

this is unsigned. Does it matter that you treat it as just an integer?

this is unsigned. Does it matter that you treat it as just an integer?
skhameneh commented 2018-09-05 02:42:19 +02:00 (Migrated from github.com)
Review
Copy link

Ha, alright! I didn't realize TINYINT(1) is exactly the same as BOOL
https://dev.mysql.com/doc/refman/5.7/en/numeric-type-overview.html

BOOL, BOOLEAN
These types are synonyms for TINYINT(1). A value of zero is considered false. Nonzero values are considered true

Ha, alright! I didn't realize `TINYINT(1)` is exactly the same as `BOOL` https://dev.mysql.com/doc/refman/5.7/en/numeric-type-overview.html > **BOOL, BOOLEAN** > These types are synonyms for TINYINT(1). A value of zero is considered false. Nonzero values are considered true

13
server/chainquery/models/OutputModel.js
View file

@ -3,7 +3,12 @@ const getterMethods = {
tiger5226 commented 2018-09-05 01:33:23 +02:00 (Migrated from github.com)
Review
Copy link

boolean

boolean
tiger5226 commented 2018-09-05 01:33:23 +02:00 (Migrated from github.com)
Review
Copy link

boolean

boolean
} }
export default (sequelize, { export default (sequelize, {
STRING, BOOLEAN, INTEGER, TEXT, DECIMAL BOOLEAN,
tiger5226 commented 2018-09-05 01:33:23 +02:00 (Migrated from github.com)
Review
Copy link

boolean

boolean
tiger5226 commented 2018-09-05 01:33:23 +02:00 (Migrated from github.com)
Review
Copy link

boolean

boolean
DATE,
tiger5226 commented 2018-09-05 01:33:23 +02:00 (Migrated from github.com)
Review
Copy link

boolean

boolean
DECIMAL,
tiger5226 commented 2018-09-05 01:33:23 +02:00 (Migrated from github.com)
Review
Copy link

boolean

boolean
INTEGER,
tiger5226 commented 2018-09-05 01:33:23 +02:00 (Migrated from github.com)
Review
Copy link

boolean

boolean
STRING,
tiger5226 commented 2018-09-05 01:33:23 +02:00 (Migrated from github.com)
Review
Copy link

boolean

boolean
TEXT,
tiger5226 commented 2018-09-05 01:33:23 +02:00 (Migrated from github.com)
Review
Copy link

boolean

boolean
}) => sequelize.define( }) => sequelize.define(
'output', 'output',
{ {
@ -49,7 +54,7 @@ export default (sequelize, {
tiger5226 commented 2018-09-05 01:33:23 +02:00 (Migrated from github.com)
Review
Copy link

boolean

boolean
tiger5226 commented 2018-09-05 01:33:23 +02:00 (Migrated from github.com)
Review
Copy link

boolean

boolean
set() { }, set() { },
}, },
is_spent: { is_spent: {
type: INTEGER, type: BOOLEAN,
tiger5226 commented 2018-09-05 01:33:23 +02:00 (Migrated from github.com)
Review
Copy link

boolean

boolean
tiger5226 commented 2018-09-05 01:33:23 +02:00 (Migrated from github.com)
Review
Copy link

boolean

boolean
set() { }, set() { },
}, },
spent_by_input_id: { spent_by_input_id: {
@ -57,11 +62,11 @@ export default (sequelize, {
tiger5226 commented 2018-09-05 01:33:23 +02:00 (Migrated from github.com)
Review
Copy link

boolean

boolean
tiger5226 commented 2018-09-05 01:33:23 +02:00 (Migrated from github.com)
Review
Copy link

boolean

boolean
set() { }, set() { },
}, },
created_at: { created_at: {
type: INTEGER, type: DATE(6),
tiger5226 commented 2018-09-05 01:33:23 +02:00 (Migrated from github.com)
Review
Copy link

boolean

boolean
tiger5226 commented 2018-09-05 01:33:23 +02:00 (Migrated from github.com)
Review
Copy link

boolean

boolean
set() { }, set() { },
}, },
modified_at: { modified_at: {
type: INTEGER, type: DATE(6),
tiger5226 commented 2018-09-05 01:33:23 +02:00 (Migrated from github.com)
Review
Copy link

boolean

boolean
tiger5226 commented 2018-09-05 01:33:23 +02:00 (Migrated from github.com)
Review
Copy link

boolean

boolean
set() { }, set() { },
}, },
claim_id: { claim_id: {

tiger5226 commented 2018-09-05 01:33:23 +02:00 (Migrated from github.com)
Review
Copy link

boolean

boolean
tiger5226 commented 2018-09-05 01:33:23 +02:00 (Migrated from github.com)
Review
Copy link

boolean

boolean

11
server/chainquery/models/SupportModel.js
View file

@ -3,7 +3,12 @@ const getterMethods = {
} }
export default (sequelize, { export default (sequelize, {
STRING, BOOLEAN, INTEGER, TEXT, DECIMAL BOOLEAN,
DATE,
DECIMAL,
INTEGER,
STRING,
TEXT,
}) => sequelize.define( }) => sequelize.define(
'support', 'support',
{ {
@ -33,11 +38,11 @@ export default (sequelize, {
set() { }, set() { },
}, },
created_at: { created_at: {
type: INTEGER, type: DATE(6),
set() { }, set() { },
}, },
modified_at: { modified_at: {
type: INTEGER, type: DATE(6),
set() { }, set() { },
}, },
}, },

7
server/chainquery/models/TransactionAddressModel.js
View file

@ -3,7 +3,12 @@ const getterMethods = {
} }
export default (sequelize, { export default (sequelize, {
STRING, BOOLEAN, INTEGER, TEXT, DECIMAL BOOLEAN,
DATE,
DECIMAL,
INTEGER,
STRING,
TEXT,
}) => sequelize.define( }) => sequelize.define(
'transaction_address', 'transaction_address',
{ {

15
server/chainquery/models/TransactionModel.js
View file

@ -3,7 +3,12 @@ const getterMethods = {
} }
export default (sequelize, { export default (sequelize, {
STRING, BOOLEAN, INTEGER, TEXT, DECIMAL BOOLEAN,
DATE,
DECIMAL,
INTEGER,
STRING,
TEXT,
}) => sequelize.define( }) => sequelize.define(
'transaction', 'transaction',
{ {
@ -45,7 +50,7 @@ export default (sequelize, {
set() { }, set() { },
}, },
lock_time: { lock_time: {
type: INTEGER, type: DATE(6),
set() { }, set() { },
}, },
raw: { raw: {
@ -53,15 +58,15 @@ export default (sequelize, {
set() { }, set() { },
}, },
created_at: { created_at: {
type: INTEGER, type: DATE(6),
set() { }, set() { },
}, },
modified_at: { modified_at: {
type: INTEGER, type: DATE(6),
set() { }, set() { },
}, },
created_time: { created_time: {
type: INTEGER, type: DATE(6),
set() {}, set() {},
}, },
}, },

2
server/render/build/handleShowRender.js
View file

@ -88,8 +88,6 @@ module.exports = function (req, res) {
res.send((0, _renderFullPage.default)(helmet, html, preloadedState)); res.send((0, _renderFullPage.default)(helmet, html, preloadedState));
}; };
console.log(httpContext.get('routePath'), runSaga, httpContext.get('routeData'), action, saga);
if (runSaga) { if (runSaga) {
// create and apply middleware // create and apply middleware
var sagaMiddleware = (0, _reduxSaga.default)(); var sagaMiddleware = (0, _reduxSaga.default)();