Refactor publish and validation and servability for all file types #902

Merged
jessopb merged 2 commits from refactorPublishValidate into master 2019-02-09 21:41:07 +01:00
8 changed files with 121 additions and 17 deletions

View file

@ -23,7 +23,7 @@
"publishing": {
"primaryClaimAddress": null,
"uploadDirectory": "/home/lbry/Uploads",
"lbrynetHome": "/home/lbry",
"lbrynetHome": "/CURRENTLYUNUSED",
"thumbnailChannel": null,
"thumbnailChannelId": null,
"additionalClaimAddresses": [],
@ -36,6 +36,17 @@
"publishingChannelWhitelist": [],
"channelClaimBidAmount": "0.1",
"fileClaimBidAmount": "0.01",
"fileSizeLimits": {
"image": 50000000,
"video": 50000000,
"audio": 50000000,
"text": 50000000,
"model": 50000000,
"application": 50000000,
"customByContentType": {
"application/octet-stream": 50000000
}
},
"maxSizeImage": 10000000,
"maxSizeGif": 50000000,
"maxSizeVideo": 50000000
@ -49,7 +60,19 @@
"publicDisallowedTypesMain": []
},
"customFileExtensions": {
"application/example-type": "example"
"application/x-troff-man": ".man",
"application/x-troff-me": ".me",
"application/x-mif": ".mif",
"application/x-troff-ms": ".ms",
"application/x-troff": ".roff",
"application/x-python-code": ".pyc",
"text/x-python": ".py",
"application/x-pn-realaudio": ".ram",
"application/x-sgml": ".sgm",
"model/stl": ".stl",
"image/pict": ".pct",
"text/xul": ".xul",
"text/x-go": "go"
}
},
"startup": {

View file

@ -5,8 +5,9 @@ class PublishPreview extends React.Component {
constructor (props) {
super(props);
this.state = {
imgSource : '',
defaultThumbnail: '/assets/img/video_thumb_default.png',
imgSource : '',
defaultVideoThumbnail: '/assets/img/video_thumb_default.png',
defaultThumbnail : '/assets/img/Speech_Logo_Main@OG-02.jpg',
};
}
componentDidMount () {
@ -37,12 +38,13 @@ class PublishPreview extends React.Component {
};
}
setPreviewImageSource (file) {
if (file.type !== 'video/mp4') {
if (this.props.thumbnail) {
this.setPreviewImageSourceFromFile(this.props.thumbnail);
} else if (file.type.substr(0, file.type.indexOf('/')) === 'image'){
this.setPreviewImageSourceFromFile(file);
} else if (file.type === 'video'){
this.setState({imgSource: this.state.defaultVideoThumbnail});
} else {
if (this.props.thumbnail) {
this.setPreviewImageSourceFromFile(this.props.thumbnail);
}
this.setState({imgSource: this.state.defaultThumbnail});
}
}

View file

@ -1,13 +1,13 @@
import React from 'react';
import { validateFile } from '../../utils/file';
import Memeify from '@components/Memeify';
import DropzonePreviewImage from '@components/DropzonePreviewImage';
import DropzoneDropItDisplay from '@components/DropzoneDropItDisplay';
import DropzoneInstructionsDisplay from '@components/DropzoneInstructionsDisplay';
import validateFileForPublish from '@globalutils/validateFileForPublish';
import { library } from '@fortawesome/fontawesome-svg-core'
import { FontAwesomeIcon } from '@fortawesome/react-fontawesome'
import { library } from '@fortawesome/fontawesome-svg-core';
import { FontAwesomeIcon } from '@fortawesome/react-fontawesome';
import { faEdit } from '@fortawesome/free-solid-svg-icons';
const isFacebook = (() => {
@ -29,7 +29,7 @@ class Dropzone extends React.Component {
memeify : false,
};
if(props.file) {
if (props.file) {
// No side effects allowed with `getDerivedStateFromProps`, so
// we must use `componentDidUpdate` and `constructor` routines.
// Note: `FileReader` has an `onloadend` side-effect
@ -133,7 +133,7 @@ class Dropzone extends React.Component {
chooseFile (file) {
if (file) {
try {
validateFile(file); // validate the file's name, type, and size
validateFileForPublish(file); // validate the file's name, type, and size
} catch (error) {
return this.props.setFileError(error.message);
}

View file

@ -47,8 +47,6 @@ const createAssetMetaTags = asset => {
const ogThumbnailContentType = determineContentTypeFromExtension(claimData.thumbnail);
const ogThumbnail = claimData.thumbnail || defaultThumbnail;
console.log('asset.claimData', asset.claimData);
// {property: 'og:title'] = ogTitle},
const metaTags = {
'og:title': ogTitle,

View file

@ -1,9 +1,17 @@
skhameneh commented 2019-02-07 04:00:21 +01:00 (Migrated from github.com)
Review

Please use (for legibility):

} else {
   return mime.extension(this.content_type) ? mime.extension(this.content_type) : 'jpg';
}
Please use (for legibility): ``` } else { return mime.extension(this.content_type) ? mime.extension(this.content_type) : 'jpg'; } ```
skhameneh commented 2019-02-07 04:00:21 +01:00 (Migrated from github.com)
Review

Please use (for legibility):

} else {
   return mime.extension(this.content_type) ? mime.extension(this.content_type) : 'jpg';
}
Please use (for legibility): ``` } else { return mime.extension(this.content_type) ? mime.extension(this.content_type) : 'jpg'; } ```
const logger = require('winston');
const mime = require('mime-types');
const {
skhameneh commented 2019-02-07 04:00:21 +01:00 (Migrated from github.com)
Review

Please use (for legibility):

} else {
   return mime.extension(this.content_type) ? mime.extension(this.content_type) : 'jpg';
}
Please use (for legibility): ``` } else { return mime.extension(this.content_type) ? mime.extension(this.content_type) : 'jpg'; } ```
serving: { customFileExtensions },
skhameneh commented 2019-02-07 04:00:21 +01:00 (Migrated from github.com)
Review

Please use (for legibility):

} else {
   return mime.extension(this.content_type) ? mime.extension(this.content_type) : 'jpg';
}
Please use (for legibility): ``` } else { return mime.extension(this.content_type) ? mime.extension(this.content_type) : 'jpg'; } ```
} = require('@config/siteConfig');
skhameneh commented 2019-02-07 04:00:21 +01:00 (Migrated from github.com)
Review

Please use (for legibility):

} else {
   return mime.extension(this.content_type) ? mime.extension(this.content_type) : 'jpg';
}
Please use (for legibility): ``` } else { return mime.extension(this.content_type) ? mime.extension(this.content_type) : 'jpg'; } ```
const getterMethods = {
generated_extension() {
return mime.extension(this.content_type) ? mime.extension(this.content_type) : 'jpg';
skhameneh commented 2019-02-07 04:00:21 +01:00 (Migrated from github.com)
Review

Please use (for legibility):

} else {
   return mime.extension(this.content_type) ? mime.extension(this.content_type) : 'jpg';
}
Please use (for legibility): ``` } else { return mime.extension(this.content_type) ? mime.extension(this.content_type) : 'jpg'; } ```
logger.info('trying to generate extension', this.content_type);
skhameneh commented 2019-02-07 04:00:21 +01:00 (Migrated from github.com)
Review

Please use (for legibility):

} else {
   return mime.extension(this.content_type) ? mime.extension(this.content_type) : 'jpg';
}
Please use (for legibility): ``` } else { return mime.extension(this.content_type) ? mime.extension(this.content_type) : 'jpg'; } ```
if (customFileExtensions.hasOwnProperty(this.content_type)) {
skhameneh commented 2019-02-07 04:00:21 +01:00 (Migrated from github.com)
Review

Please use (for legibility):

} else {
   return mime.extension(this.content_type) ? mime.extension(this.content_type) : 'jpg';
}
Please use (for legibility): ``` } else { return mime.extension(this.content_type) ? mime.extension(this.content_type) : 'jpg'; } ```
return customFileExtensions[this.content_type];
skhameneh commented 2019-02-07 04:00:21 +01:00 (Migrated from github.com)
Review

Please use (for legibility):

} else {
   return mime.extension(this.content_type) ? mime.extension(this.content_type) : 'jpg';
}
Please use (for legibility): ``` } else { return mime.extension(this.content_type) ? mime.extension(this.content_type) : 'jpg'; } ```
} else {
skhameneh commented 2019-02-07 04:00:21 +01:00 (Migrated from github.com)
Review

Please use (for legibility):

} else {
   return mime.extension(this.content_type) ? mime.extension(this.content_type) : 'jpg';
}
Please use (for legibility): ``` } else { return mime.extension(this.content_type) ? mime.extension(this.content_type) : 'jpg'; } ```
return mime.extension(this.content_type) ? mime.extension(this.content_type) : 'jpg';
skhameneh commented 2019-02-07 04:00:21 +01:00 (Migrated from github.com)
Review

Please use (for legibility):

} else {
   return mime.extension(this.content_type) ? mime.extension(this.content_type) : 'jpg';
}
Please use (for legibility): ``` } else { return mime.extension(this.content_type) ? mime.extension(this.content_type) : 'jpg'; } ```
}
skhameneh commented 2019-02-07 04:00:21 +01:00 (Migrated from github.com)
Review

Please use (for legibility):

} else {
   return mime.extension(this.content_type) ? mime.extension(this.content_type) : 'jpg';
}
Please use (for legibility): ``` } else { return mime.extension(this.content_type) ? mime.extension(this.content_type) : 'jpg'; } ```
},
};

skhameneh commented 2019-02-07 04:00:21 +01:00 (Migrated from github.com)
Review

Please use (for legibility):

} else {
   return mime.extension(this.content_type) ? mime.extension(this.content_type) : 'jpg';
}
Please use (for legibility): ``` } else { return mime.extension(this.content_type) ? mime.extension(this.content_type) : 'jpg'; } ```
skhameneh commented 2019-02-07 04:00:21 +01:00 (Migrated from github.com)
Review

Please use (for legibility):

} else {
   return mime.extension(this.content_type) ? mime.extension(this.content_type) : 'jpg';
}
Please use (for legibility): ``` } else { return mime.extension(this.content_type) ? mime.extension(this.content_type) : 'jpg'; } ```

View file

@ -1,5 +1,6 @@
const path = require('path');
const validateFileTypeAndSize = require('./validateFileTypeAndSize.js');
const validateFileForPublish = require('./validateFileForPublish.js');
const parsePublishApiRequestFiles = ({ file, thumbnail }, isUpdate) => {
// make sure a file was provided
@ -40,7 +41,7 @@ const parsePublishApiRequestFiles = ({ file, thumbnail }, isUpdate) => {
}
// validate the file
if (file) validateFileTypeAndSize(file);
if (file) validateFileForPublish(file);
// return results
const obj = {
fileName: file.name,

View file

@ -0,0 +1,38 @@
skhameneh commented 2019-02-07 04:00:47 +01:00 (Migrated from github.com)
Review

Remove?

Remove?
skhameneh commented 2019-02-07 04:05:09 +01:00 (Migrated from github.com)
Review

Can make an object of { [mediaType]: maxSize }, which would map to:

let mediaTypeLimit = mediaTypeLimits[mediaType] || false;
if (mediaTypeLimit) {
  if (file.size > mediaTypeLimit) {
    throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`);
  }
}
Can make an object of `{ [mediaType]: maxSize }`, which would map to: ``` let mediaTypeLimit = mediaTypeLimits[mediaType] || false; if (mediaTypeLimit) { if (file.size > mediaTypeLimit) { throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`); } } ```
jessopb commented 2019-02-09 21:35:50 +01:00 (Migrated from github.com)
Review

Done and DRY.

Done and DRY.
skhameneh commented 2019-02-07 04:00:47 +01:00 (Migrated from github.com)
Review

Remove?

Remove?
skhameneh commented 2019-02-07 04:05:09 +01:00 (Migrated from github.com)
Review

Can make an object of { [mediaType]: maxSize }, which would map to:

let mediaTypeLimit = mediaTypeLimits[mediaType] || false;
if (mediaTypeLimit) {
  if (file.size > mediaTypeLimit) {
    throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`);
  }
}
Can make an object of `{ [mediaType]: maxSize }`, which would map to: ``` let mediaTypeLimit = mediaTypeLimits[mediaType] || false; if (mediaTypeLimit) { if (file.size > mediaTypeLimit) { throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`); } } ```
jessopb commented 2019-02-09 21:35:50 +01:00 (Migrated from github.com)
Review

Done and DRY.

Done and DRY.
const logger = require('winston');
skhameneh commented 2019-02-07 04:00:47 +01:00 (Migrated from github.com)
Review

Remove?

Remove?
skhameneh commented 2019-02-07 04:05:09 +01:00 (Migrated from github.com)
Review

Can make an object of { [mediaType]: maxSize }, which would map to:

let mediaTypeLimit = mediaTypeLimits[mediaType] || false;
if (mediaTypeLimit) {
  if (file.size > mediaTypeLimit) {
    throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`);
  }
}
Can make an object of `{ [mediaType]: maxSize }`, which would map to: ``` let mediaTypeLimit = mediaTypeLimits[mediaType] || false; if (mediaTypeLimit) { if (file.size > mediaTypeLimit) { throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`); } } ```
jessopb commented 2019-02-09 21:35:50 +01:00 (Migrated from github.com)
Review

Done and DRY.

Done and DRY.
skhameneh commented 2019-02-07 04:00:47 +01:00 (Migrated from github.com)
Review

Remove?

Remove?
skhameneh commented 2019-02-07 04:05:09 +01:00 (Migrated from github.com)
Review

Can make an object of { [mediaType]: maxSize }, which would map to:

let mediaTypeLimit = mediaTypeLimits[mediaType] || false;
if (mediaTypeLimit) {
  if (file.size > mediaTypeLimit) {
    throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`);
  }
}
Can make an object of `{ [mediaType]: maxSize }`, which would map to: ``` let mediaTypeLimit = mediaTypeLimits[mediaType] || false; if (mediaTypeLimit) { if (file.size > mediaTypeLimit) { throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`); } } ```
jessopb commented 2019-02-09 21:35:50 +01:00 (Migrated from github.com)
Review

Done and DRY.

Done and DRY.
const { publishing } = require('@config/siteConfig.json');
skhameneh commented 2019-02-07 04:00:47 +01:00 (Migrated from github.com)
Review

Remove?

Remove?
skhameneh commented 2019-02-07 04:05:09 +01:00 (Migrated from github.com)
Review

Can make an object of { [mediaType]: maxSize }, which would map to:

let mediaTypeLimit = mediaTypeLimits[mediaType] || false;
if (mediaTypeLimit) {
  if (file.size > mediaTypeLimit) {
    throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`);
  }
}
Can make an object of `{ [mediaType]: maxSize }`, which would map to: ``` let mediaTypeLimit = mediaTypeLimits[mediaType] || false; if (mediaTypeLimit) { if (file.size > mediaTypeLimit) { throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`); } } ```
jessopb commented 2019-02-09 21:35:50 +01:00 (Migrated from github.com)
Review

Done and DRY.

Done and DRY.
skhameneh commented 2019-02-07 04:00:47 +01:00 (Migrated from github.com)
Review

Remove?

Remove?
skhameneh commented 2019-02-07 04:05:09 +01:00 (Migrated from github.com)
Review

Can make an object of { [mediaType]: maxSize }, which would map to:

let mediaTypeLimit = mediaTypeLimits[mediaType] || false;
if (mediaTypeLimit) {
  if (file.size > mediaTypeLimit) {
    throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`);
  }
}
Can make an object of `{ [mediaType]: maxSize }`, which would map to: ``` let mediaTypeLimit = mediaTypeLimits[mediaType] || false; if (mediaTypeLimit) { if (file.size > mediaTypeLimit) { throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`); } } ```
jessopb commented 2019-02-09 21:35:50 +01:00 (Migrated from github.com)
Review

Done and DRY.

Done and DRY.
const { fileSizeLimits } = publishing;
skhameneh commented 2019-02-07 04:00:47 +01:00 (Migrated from github.com)
Review

Remove?

Remove?
skhameneh commented 2019-02-07 04:05:09 +01:00 (Migrated from github.com)
Review

Can make an object of { [mediaType]: maxSize }, which would map to:

let mediaTypeLimit = mediaTypeLimits[mediaType] || false;
if (mediaTypeLimit) {
  if (file.size > mediaTypeLimit) {
    throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`);
  }
}
Can make an object of `{ [mediaType]: maxSize }`, which would map to: ``` let mediaTypeLimit = mediaTypeLimits[mediaType] || false; if (mediaTypeLimit) { if (file.size > mediaTypeLimit) { throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`); } } ```
jessopb commented 2019-02-09 21:35:50 +01:00 (Migrated from github.com)
Review

Done and DRY.

Done and DRY.
skhameneh commented 2019-02-07 04:00:47 +01:00 (Migrated from github.com)
Review

Remove?

Remove?
skhameneh commented 2019-02-07 04:05:09 +01:00 (Migrated from github.com)
Review

Can make an object of { [mediaType]: maxSize }, which would map to:

let mediaTypeLimit = mediaTypeLimits[mediaType] || false;
if (mediaTypeLimit) {
  if (file.size > mediaTypeLimit) {
    throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`);
  }
}
Can make an object of `{ [mediaType]: maxSize }`, which would map to: ``` let mediaTypeLimit = mediaTypeLimits[mediaType] || false; if (mediaTypeLimit) { if (file.size > mediaTypeLimit) { throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`); } } ```
jessopb commented 2019-02-09 21:35:50 +01:00 (Migrated from github.com)
Review

Done and DRY.

Done and DRY.
const SIZE_MB = 1000000;
skhameneh commented 2019-02-07 04:00:47 +01:00 (Migrated from github.com)
Review

Remove?

Remove?
skhameneh commented 2019-02-07 04:05:09 +01:00 (Migrated from github.com)
Review

Can make an object of { [mediaType]: maxSize }, which would map to:

let mediaTypeLimit = mediaTypeLimits[mediaType] || false;
if (mediaTypeLimit) {
  if (file.size > mediaTypeLimit) {
    throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`);
  }
}
Can make an object of `{ [mediaType]: maxSize }`, which would map to: ``` let mediaTypeLimit = mediaTypeLimits[mediaType] || false; if (mediaTypeLimit) { if (file.size > mediaTypeLimit) { throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`); } } ```
jessopb commented 2019-02-09 21:35:50 +01:00 (Migrated from github.com)
Review

Done and DRY.

Done and DRY.
skhameneh commented 2019-02-07 04:00:47 +01:00 (Migrated from github.com)
Review

Remove?

Remove?
skhameneh commented 2019-02-07 04:05:09 +01:00 (Migrated from github.com)
Review

Can make an object of { [mediaType]: maxSize }, which would map to:

let mediaTypeLimit = mediaTypeLimits[mediaType] || false;
if (mediaTypeLimit) {
  if (file.size > mediaTypeLimit) {
    throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`);
  }
}
Can make an object of `{ [mediaType]: maxSize }`, which would map to: ``` let mediaTypeLimit = mediaTypeLimits[mediaType] || false; if (mediaTypeLimit) { if (file.size > mediaTypeLimit) { throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`); } } ```
jessopb commented 2019-02-09 21:35:50 +01:00 (Migrated from github.com)
Review

Done and DRY.

Done and DRY.
const validateFileForPublish = file => {
skhameneh commented 2019-02-07 04:00:47 +01:00 (Migrated from github.com)
Review

Remove?

Remove?
skhameneh commented 2019-02-07 04:05:09 +01:00 (Migrated from github.com)
Review

Can make an object of { [mediaType]: maxSize }, which would map to:

let mediaTypeLimit = mediaTypeLimits[mediaType] || false;
if (mediaTypeLimit) {
  if (file.size > mediaTypeLimit) {
    throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`);
  }
}
Can make an object of `{ [mediaType]: maxSize }`, which would map to: ``` let mediaTypeLimit = mediaTypeLimits[mediaType] || false; if (mediaTypeLimit) { if (file.size > mediaTypeLimit) { throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`); } } ```
jessopb commented 2019-02-09 21:35:50 +01:00 (Migrated from github.com)
Review

Done and DRY.

Done and DRY.
let contentType = file.type;
skhameneh commented 2019-02-07 04:00:47 +01:00 (Migrated from github.com)
Review

Remove?

Remove?
skhameneh commented 2019-02-07 04:05:09 +01:00 (Migrated from github.com)
Review

Can make an object of { [mediaType]: maxSize }, which would map to:

let mediaTypeLimit = mediaTypeLimits[mediaType] || false;
if (mediaTypeLimit) {
  if (file.size > mediaTypeLimit) {
    throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`);
  }
}
Can make an object of `{ [mediaType]: maxSize }`, which would map to: ``` let mediaTypeLimit = mediaTypeLimits[mediaType] || false; if (mediaTypeLimit) { if (file.size > mediaTypeLimit) { throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`); } } ```
jessopb commented 2019-02-09 21:35:50 +01:00 (Migrated from github.com)
Review

Done and DRY.

Done and DRY.
let mediaType = contentType ? contentType.substr(0, contentType.indexOf('/')) : '';
skhameneh commented 2019-02-07 04:00:47 +01:00 (Migrated from github.com)
Review

Remove?

Remove?
skhameneh commented 2019-02-07 04:05:09 +01:00 (Migrated from github.com)
Review

Can make an object of { [mediaType]: maxSize }, which would map to:

let mediaTypeLimit = mediaTypeLimits[mediaType] || false;
if (mediaTypeLimit) {
  if (file.size > mediaTypeLimit) {
    throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`);
  }
}
Can make an object of `{ [mediaType]: maxSize }`, which would map to: ``` let mediaTypeLimit = mediaTypeLimits[mediaType] || false; if (mediaTypeLimit) { if (file.size > mediaTypeLimit) { throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`); } } ```
jessopb commented 2019-02-09 21:35:50 +01:00 (Migrated from github.com)
Review

Done and DRY.

Done and DRY.
let mediaTypeLimit = fileSizeLimits[mediaType] || false;
skhameneh commented 2019-02-07 04:00:47 +01:00 (Migrated from github.com)
Review

Remove?

Remove?
skhameneh commented 2019-02-07 04:05:09 +01:00 (Migrated from github.com)
Review

Can make an object of { [mediaType]: maxSize }, which would map to:

let mediaTypeLimit = mediaTypeLimits[mediaType] || false;
if (mediaTypeLimit) {
  if (file.size > mediaTypeLimit) {
    throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`);
  }
}
Can make an object of `{ [mediaType]: maxSize }`, which would map to: ``` let mediaTypeLimit = mediaTypeLimits[mediaType] || false; if (mediaTypeLimit) { if (file.size > mediaTypeLimit) { throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`); } } ```
jessopb commented 2019-02-09 21:35:50 +01:00 (Migrated from github.com)
Review

Done and DRY.

Done and DRY.
let customLimits = fileSizeLimits['customByContentType'];
skhameneh commented 2019-02-07 04:00:47 +01:00 (Migrated from github.com)
Review

Remove?

Remove?
skhameneh commented 2019-02-07 04:05:09 +01:00 (Migrated from github.com)
Review

Can make an object of { [mediaType]: maxSize }, which would map to:

let mediaTypeLimit = mediaTypeLimits[mediaType] || false;
if (mediaTypeLimit) {
  if (file.size > mediaTypeLimit) {
    throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`);
  }
}
Can make an object of `{ [mediaType]: maxSize }`, which would map to: ``` let mediaTypeLimit = mediaTypeLimits[mediaType] || false; if (mediaTypeLimit) { if (file.size > mediaTypeLimit) { throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`); } } ```
jessopb commented 2019-02-09 21:35:50 +01:00 (Migrated from github.com)
Review

Done and DRY.

Done and DRY.
skhameneh commented 2019-02-07 04:00:47 +01:00 (Migrated from github.com)
Review

Remove?

Remove?
skhameneh commented 2019-02-07 04:05:09 +01:00 (Migrated from github.com)
Review

Can make an object of { [mediaType]: maxSize }, which would map to:

let mediaTypeLimit = mediaTypeLimits[mediaType] || false;
if (mediaTypeLimit) {
  if (file.size > mediaTypeLimit) {
    throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`);
  }
}
Can make an object of `{ [mediaType]: maxSize }`, which would map to: ``` let mediaTypeLimit = mediaTypeLimits[mediaType] || false; if (mediaTypeLimit) { if (file.size > mediaTypeLimit) { throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`); } } ```
jessopb commented 2019-02-09 21:35:50 +01:00 (Migrated from github.com)
Review

Done and DRY.

Done and DRY.
if (!file) {
skhameneh commented 2019-02-07 04:00:47 +01:00 (Migrated from github.com)
Review

Remove?

Remove?
skhameneh commented 2019-02-07 04:05:09 +01:00 (Migrated from github.com)
Review

Can make an object of { [mediaType]: maxSize }, which would map to:

let mediaTypeLimit = mediaTypeLimits[mediaType] || false;
if (mediaTypeLimit) {
  if (file.size > mediaTypeLimit) {
    throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`);
  }
}
Can make an object of `{ [mediaType]: maxSize }`, which would map to: ``` let mediaTypeLimit = mediaTypeLimits[mediaType] || false; if (mediaTypeLimit) { if (file.size > mediaTypeLimit) { throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`); } } ```
jessopb commented 2019-02-09 21:35:50 +01:00 (Migrated from github.com)
Review

Done and DRY.

Done and DRY.
throw new Error('no file provided');
skhameneh commented 2019-02-07 04:00:47 +01:00 (Migrated from github.com)
Review

Remove?

Remove?
skhameneh commented 2019-02-07 04:05:09 +01:00 (Migrated from github.com)
Review

Can make an object of { [mediaType]: maxSize }, which would map to:

let mediaTypeLimit = mediaTypeLimits[mediaType] || false;
if (mediaTypeLimit) {
  if (file.size > mediaTypeLimit) {
    throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`);
  }
}
Can make an object of `{ [mediaType]: maxSize }`, which would map to: ``` let mediaTypeLimit = mediaTypeLimits[mediaType] || false; if (mediaTypeLimit) { if (file.size > mediaTypeLimit) { throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`); } } ```
jessopb commented 2019-02-09 21:35:50 +01:00 (Migrated from github.com)
Review

Done and DRY.

Done and DRY.
}
skhameneh commented 2019-02-07 04:00:47 +01:00 (Migrated from github.com)
Review

Remove?

Remove?
skhameneh commented 2019-02-07 04:05:09 +01:00 (Migrated from github.com)
Review

Can make an object of { [mediaType]: maxSize }, which would map to:

let mediaTypeLimit = mediaTypeLimits[mediaType] || false;
if (mediaTypeLimit) {
  if (file.size > mediaTypeLimit) {
    throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`);
  }
}
Can make an object of `{ [mediaType]: maxSize }`, which would map to: ``` let mediaTypeLimit = mediaTypeLimits[mediaType] || false; if (mediaTypeLimit) { if (file.size > mediaTypeLimit) { throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`); } } ```
jessopb commented 2019-02-09 21:35:50 +01:00 (Migrated from github.com)
Review

Done and DRY.

Done and DRY.
skhameneh commented 2019-02-07 04:00:47 +01:00 (Migrated from github.com)
Review

Remove?

Remove?
skhameneh commented 2019-02-07 04:05:09 +01:00 (Migrated from github.com)
Review

Can make an object of { [mediaType]: maxSize }, which would map to:

let mediaTypeLimit = mediaTypeLimits[mediaType] || false;
if (mediaTypeLimit) {
  if (file.size > mediaTypeLimit) {
    throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`);
  }
}
Can make an object of `{ [mediaType]: maxSize }`, which would map to: ``` let mediaTypeLimit = mediaTypeLimits[mediaType] || false; if (mediaTypeLimit) { if (file.size > mediaTypeLimit) { throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`); } } ```
jessopb commented 2019-02-09 21:35:50 +01:00 (Migrated from github.com)
Review

Done and DRY.

Done and DRY.
if (/'/.test(file.name)) {
skhameneh commented 2019-02-07 04:00:47 +01:00 (Migrated from github.com)
Review

Remove?

Remove?
skhameneh commented 2019-02-07 04:05:09 +01:00 (Migrated from github.com)
Review

Can make an object of { [mediaType]: maxSize }, which would map to:

let mediaTypeLimit = mediaTypeLimits[mediaType] || false;
if (mediaTypeLimit) {
  if (file.size > mediaTypeLimit) {
    throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`);
  }
}
Can make an object of `{ [mediaType]: maxSize }`, which would map to: ``` let mediaTypeLimit = mediaTypeLimits[mediaType] || false; if (mediaTypeLimit) { if (file.size > mediaTypeLimit) { throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`); } } ```
jessopb commented 2019-02-09 21:35:50 +01:00 (Migrated from github.com)
Review

Done and DRY.

Done and DRY.
throw new Error('apostrophes are not allowed in the file name');
skhameneh commented 2019-02-07 04:00:47 +01:00 (Migrated from github.com)
Review

Remove?

Remove?
skhameneh commented 2019-02-07 04:05:09 +01:00 (Migrated from github.com)
Review

Can make an object of { [mediaType]: maxSize }, which would map to:

let mediaTypeLimit = mediaTypeLimits[mediaType] || false;
if (mediaTypeLimit) {
  if (file.size > mediaTypeLimit) {
    throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`);
  }
}
Can make an object of `{ [mediaType]: maxSize }`, which would map to: ``` let mediaTypeLimit = mediaTypeLimits[mediaType] || false; if (mediaTypeLimit) { if (file.size > mediaTypeLimit) { throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`); } } ```
jessopb commented 2019-02-09 21:35:50 +01:00 (Migrated from github.com)
Review

Done and DRY.

Done and DRY.
}
skhameneh commented 2019-02-07 04:00:47 +01:00 (Migrated from github.com)
Review

Remove?

Remove?
skhameneh commented 2019-02-07 04:05:09 +01:00 (Migrated from github.com)
Review

Can make an object of { [mediaType]: maxSize }, which would map to:

let mediaTypeLimit = mediaTypeLimits[mediaType] || false;
if (mediaTypeLimit) {
  if (file.size > mediaTypeLimit) {
    throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`);
  }
}
Can make an object of `{ [mediaType]: maxSize }`, which would map to: ``` let mediaTypeLimit = mediaTypeLimits[mediaType] || false; if (mediaTypeLimit) { if (file.size > mediaTypeLimit) { throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`); } } ```
jessopb commented 2019-02-09 21:35:50 +01:00 (Migrated from github.com)
Review

Done and DRY.

Done and DRY.
skhameneh commented 2019-02-07 04:00:47 +01:00 (Migrated from github.com)
Review

Remove?

Remove?
skhameneh commented 2019-02-07 04:05:09 +01:00 (Migrated from github.com)
Review

Can make an object of { [mediaType]: maxSize }, which would map to:

let mediaTypeLimit = mediaTypeLimits[mediaType] || false;
if (mediaTypeLimit) {
  if (file.size > mediaTypeLimit) {
    throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`);
  }
}
Can make an object of `{ [mediaType]: maxSize }`, which would map to: ``` let mediaTypeLimit = mediaTypeLimits[mediaType] || false; if (mediaTypeLimit) { if (file.size > mediaTypeLimit) { throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`); } } ```
jessopb commented 2019-02-09 21:35:50 +01:00 (Migrated from github.com)
Review

Done and DRY.

Done and DRY.
if (Object.keys(customLimits).includes(contentType)) {
skhameneh commented 2019-02-07 04:00:47 +01:00 (Migrated from github.com)
Review

Remove?

Remove?
skhameneh commented 2019-02-07 04:05:09 +01:00 (Migrated from github.com)
Review

Can make an object of { [mediaType]: maxSize }, which would map to:

let mediaTypeLimit = mediaTypeLimits[mediaType] || false;
if (mediaTypeLimit) {
  if (file.size > mediaTypeLimit) {
    throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`);
  }
}
Can make an object of `{ [mediaType]: maxSize }`, which would map to: ``` let mediaTypeLimit = mediaTypeLimits[mediaType] || false; if (mediaTypeLimit) { if (file.size > mediaTypeLimit) { throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`); } } ```
jessopb commented 2019-02-09 21:35:50 +01:00 (Migrated from github.com)
Review

Done and DRY.

Done and DRY.
if (file.size > customLimits[contentType]) {
skhameneh commented 2019-02-07 04:00:47 +01:00 (Migrated from github.com)
Review

Remove?

Remove?
skhameneh commented 2019-02-07 04:05:09 +01:00 (Migrated from github.com)
Review

Can make an object of { [mediaType]: maxSize }, which would map to:

let mediaTypeLimit = mediaTypeLimits[mediaType] || false;
if (mediaTypeLimit) {
  if (file.size > mediaTypeLimit) {
    throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`);
  }
}
Can make an object of `{ [mediaType]: maxSize }`, which would map to: ``` let mediaTypeLimit = mediaTypeLimits[mediaType] || false; if (mediaTypeLimit) { if (file.size > mediaTypeLimit) { throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`); } } ```
jessopb commented 2019-02-09 21:35:50 +01:00 (Migrated from github.com)
Review

Done and DRY.

Done and DRY.
throw new Error(
skhameneh commented 2019-02-07 04:00:47 +01:00 (Migrated from github.com)
Review

Remove?

Remove?
skhameneh commented 2019-02-07 04:05:09 +01:00 (Migrated from github.com)
Review

Can make an object of { [mediaType]: maxSize }, which would map to:

let mediaTypeLimit = mediaTypeLimits[mediaType] || false;
if (mediaTypeLimit) {
  if (file.size > mediaTypeLimit) {
    throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`);
  }
}
Can make an object of `{ [mediaType]: maxSize }`, which would map to: ``` let mediaTypeLimit = mediaTypeLimits[mediaType] || false; if (mediaTypeLimit) { if (file.size > mediaTypeLimit) { throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`); } } ```
jessopb commented 2019-02-09 21:35:50 +01:00 (Migrated from github.com)
Review

Done and DRY.

Done and DRY.
`Sorry, type ${contentType} is limited to ${customLimits[contentType] / SIZE_MB} MB.`
skhameneh commented 2019-02-07 04:00:47 +01:00 (Migrated from github.com)
Review

Remove?

Remove?
skhameneh commented 2019-02-07 04:05:09 +01:00 (Migrated from github.com)
Review

Can make an object of { [mediaType]: maxSize }, which would map to:

let mediaTypeLimit = mediaTypeLimits[mediaType] || false;
if (mediaTypeLimit) {
  if (file.size > mediaTypeLimit) {
    throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`);
  }
}
Can make an object of `{ [mediaType]: maxSize }`, which would map to: ``` let mediaTypeLimit = mediaTypeLimits[mediaType] || false; if (mediaTypeLimit) { if (file.size > mediaTypeLimit) { throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`); } } ```
jessopb commented 2019-02-09 21:35:50 +01:00 (Migrated from github.com)
Review

Done and DRY.

Done and DRY.
);
skhameneh commented 2019-02-07 04:00:47 +01:00 (Migrated from github.com)
Review

Remove?

Remove?
skhameneh commented 2019-02-07 04:05:09 +01:00 (Migrated from github.com)
Review

Can make an object of { [mediaType]: maxSize }, which would map to:

let mediaTypeLimit = mediaTypeLimits[mediaType] || false;
if (mediaTypeLimit) {
  if (file.size > mediaTypeLimit) {
    throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`);
  }
}
Can make an object of `{ [mediaType]: maxSize }`, which would map to: ``` let mediaTypeLimit = mediaTypeLimits[mediaType] || false; if (mediaTypeLimit) { if (file.size > mediaTypeLimit) { throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`); } } ```
jessopb commented 2019-02-09 21:35:50 +01:00 (Migrated from github.com)
Review

Done and DRY.

Done and DRY.
}
skhameneh commented 2019-02-07 04:00:47 +01:00 (Migrated from github.com)
Review

Remove?

Remove?
skhameneh commented 2019-02-07 04:05:09 +01:00 (Migrated from github.com)
Review

Can make an object of { [mediaType]: maxSize }, which would map to:

let mediaTypeLimit = mediaTypeLimits[mediaType] || false;
if (mediaTypeLimit) {
  if (file.size > mediaTypeLimit) {
    throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`);
  }
}
Can make an object of `{ [mediaType]: maxSize }`, which would map to: ``` let mediaTypeLimit = mediaTypeLimits[mediaType] || false; if (mediaTypeLimit) { if (file.size > mediaTypeLimit) { throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`); } } ```
jessopb commented 2019-02-09 21:35:50 +01:00 (Migrated from github.com)
Review

Done and DRY.

Done and DRY.
}
skhameneh commented 2019-02-07 04:00:47 +01:00 (Migrated from github.com)
Review

Remove?

Remove?
skhameneh commented 2019-02-07 04:05:09 +01:00 (Migrated from github.com)
Review

Can make an object of { [mediaType]: maxSize }, which would map to:

let mediaTypeLimit = mediaTypeLimits[mediaType] || false;
if (mediaTypeLimit) {
  if (file.size > mediaTypeLimit) {
    throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`);
  }
}
Can make an object of `{ [mediaType]: maxSize }`, which would map to: ``` let mediaTypeLimit = mediaTypeLimits[mediaType] || false; if (mediaTypeLimit) { if (file.size > mediaTypeLimit) { throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`); } } ```
jessopb commented 2019-02-09 21:35:50 +01:00 (Migrated from github.com)
Review

Done and DRY.

Done and DRY.
if (mediaTypeLimit) {
skhameneh commented 2019-02-07 04:00:47 +01:00 (Migrated from github.com)
Review

Remove?

Remove?
skhameneh commented 2019-02-07 04:05:09 +01:00 (Migrated from github.com)
Review

Can make an object of { [mediaType]: maxSize }, which would map to:

let mediaTypeLimit = mediaTypeLimits[mediaType] || false;
if (mediaTypeLimit) {
  if (file.size > mediaTypeLimit) {
    throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`);
  }
}
Can make an object of `{ [mediaType]: maxSize }`, which would map to: ``` let mediaTypeLimit = mediaTypeLimits[mediaType] || false; if (mediaTypeLimit) { if (file.size > mediaTypeLimit) { throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`); } } ```
jessopb commented 2019-02-09 21:35:50 +01:00 (Migrated from github.com)
Review

Done and DRY.

Done and DRY.
if (file.size > mediaTypeLimit) {
skhameneh commented 2019-02-07 04:00:47 +01:00 (Migrated from github.com)
Review

Remove?

Remove?
skhameneh commented 2019-02-07 04:05:09 +01:00 (Migrated from github.com)
Review

Can make an object of { [mediaType]: maxSize }, which would map to:

let mediaTypeLimit = mediaTypeLimits[mediaType] || false;
if (mediaTypeLimit) {
  if (file.size > mediaTypeLimit) {
    throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`);
  }
}
Can make an object of `{ [mediaType]: maxSize }`, which would map to: ``` let mediaTypeLimit = mediaTypeLimits[mediaType] || false; if (mediaTypeLimit) { if (file.size > mediaTypeLimit) { throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`); } } ```
jessopb commented 2019-02-09 21:35:50 +01:00 (Migrated from github.com)
Review

Done and DRY.

Done and DRY.
throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`);
skhameneh commented 2019-02-07 04:00:47 +01:00 (Migrated from github.com)
Review

Remove?

Remove?
skhameneh commented 2019-02-07 04:05:09 +01:00 (Migrated from github.com)
Review

Can make an object of { [mediaType]: maxSize }, which would map to:

let mediaTypeLimit = mediaTypeLimits[mediaType] || false;
if (mediaTypeLimit) {
  if (file.size > mediaTypeLimit) {
    throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`);
  }
}
Can make an object of `{ [mediaType]: maxSize }`, which would map to: ``` let mediaTypeLimit = mediaTypeLimits[mediaType] || false; if (mediaTypeLimit) { if (file.size > mediaTypeLimit) { throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`); } } ```
jessopb commented 2019-02-09 21:35:50 +01:00 (Migrated from github.com)
Review

Done and DRY.

Done and DRY.
}
skhameneh commented 2019-02-07 04:00:47 +01:00 (Migrated from github.com)
Review

Remove?

Remove?
skhameneh commented 2019-02-07 04:05:09 +01:00 (Migrated from github.com)
Review

Can make an object of { [mediaType]: maxSize }, which would map to:

let mediaTypeLimit = mediaTypeLimits[mediaType] || false;
if (mediaTypeLimit) {
  if (file.size > mediaTypeLimit) {
    throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`);
  }
}
Can make an object of `{ [mediaType]: maxSize }`, which would map to: ``` let mediaTypeLimit = mediaTypeLimits[mediaType] || false; if (mediaTypeLimit) { if (file.size > mediaTypeLimit) { throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`); } } ```
jessopb commented 2019-02-09 21:35:50 +01:00 (Migrated from github.com)
Review

Done and DRY.

Done and DRY.
}
skhameneh commented 2019-02-07 04:00:47 +01:00 (Migrated from github.com)
Review

Remove?

Remove?
skhameneh commented 2019-02-07 04:05:09 +01:00 (Migrated from github.com)
Review

Can make an object of { [mediaType]: maxSize }, which would map to:

let mediaTypeLimit = mediaTypeLimits[mediaType] || false;
if (mediaTypeLimit) {
  if (file.size > mediaTypeLimit) {
    throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`);
  }
}
Can make an object of `{ [mediaType]: maxSize }`, which would map to: ``` let mediaTypeLimit = mediaTypeLimits[mediaType] || false; if (mediaTypeLimit) { if (file.size > mediaTypeLimit) { throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`); } } ```
jessopb commented 2019-02-09 21:35:50 +01:00 (Migrated from github.com)
Review

Done and DRY.

Done and DRY.
return file;
skhameneh commented 2019-02-07 04:00:47 +01:00 (Migrated from github.com)
Review

Remove?

Remove?
skhameneh commented 2019-02-07 04:05:09 +01:00 (Migrated from github.com)
Review

Can make an object of { [mediaType]: maxSize }, which would map to:

let mediaTypeLimit = mediaTypeLimits[mediaType] || false;
if (mediaTypeLimit) {
  if (file.size > mediaTypeLimit) {
    throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`);
  }
}
Can make an object of `{ [mediaType]: maxSize }`, which would map to: ``` let mediaTypeLimit = mediaTypeLimits[mediaType] || false; if (mediaTypeLimit) { if (file.size > mediaTypeLimit) { throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`); } } ```
jessopb commented 2019-02-09 21:35:50 +01:00 (Migrated from github.com)
Review

Done and DRY.

Done and DRY.
};
skhameneh commented 2019-02-07 04:00:47 +01:00 (Migrated from github.com)
Review

Remove?

Remove?
skhameneh commented 2019-02-07 04:05:09 +01:00 (Migrated from github.com)
Review

Can make an object of { [mediaType]: maxSize }, which would map to:

let mediaTypeLimit = mediaTypeLimits[mediaType] || false;
if (mediaTypeLimit) {
  if (file.size > mediaTypeLimit) {
    throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`);
  }
}
Can make an object of `{ [mediaType]: maxSize }`, which would map to: ``` let mediaTypeLimit = mediaTypeLimits[mediaType] || false; if (mediaTypeLimit) { if (file.size > mediaTypeLimit) { throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`); } } ```
jessopb commented 2019-02-09 21:35:50 +01:00 (Migrated from github.com)
Review

Done and DRY.

Done and DRY.
skhameneh commented 2019-02-07 04:00:47 +01:00 (Migrated from github.com)
Review

Remove?

Remove?
skhameneh commented 2019-02-07 04:05:09 +01:00 (Migrated from github.com)
Review

Can make an object of { [mediaType]: maxSize }, which would map to:

let mediaTypeLimit = mediaTypeLimits[mediaType] || false;
if (mediaTypeLimit) {
  if (file.size > mediaTypeLimit) {
    throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`);
  }
}
Can make an object of `{ [mediaType]: maxSize }`, which would map to: ``` let mediaTypeLimit = mediaTypeLimits[mediaType] || false; if (mediaTypeLimit) { if (file.size > mediaTypeLimit) { throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`); } } ```
jessopb commented 2019-02-09 21:35:50 +01:00 (Migrated from github.com)
Review

Done and DRY.

Done and DRY.
module.exports = validateFileForPublish;
skhameneh commented 2019-02-07 04:00:47 +01:00 (Migrated from github.com)
Review

Remove?

Remove?
skhameneh commented 2019-02-07 04:05:09 +01:00 (Migrated from github.com)
Review

Can make an object of { [mediaType]: maxSize }, which would map to:

let mediaTypeLimit = mediaTypeLimits[mediaType] || false;
if (mediaTypeLimit) {
  if (file.size > mediaTypeLimit) {
    throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`);
  }
}
Can make an object of `{ [mediaType]: maxSize }`, which would map to: ``` let mediaTypeLimit = mediaTypeLimits[mediaType] || false; if (mediaTypeLimit) { if (file.size > mediaTypeLimit) { throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`); } } ```
jessopb commented 2019-02-09 21:35:50 +01:00 (Migrated from github.com)
Review

Done and DRY.

Done and DRY.

View file

@ -0,0 +1,34 @@
skhameneh commented 2019-02-07 04:06:31 +01:00 (Migrated from github.com)
Review

Much of this is duplicated in the other file I commented.

Much of this is duplicated in the other file I commented.
skhameneh commented 2019-02-07 04:06:31 +01:00 (Migrated from github.com)
Review

Much of this is duplicated in the other file I commented.

Much of this is duplicated in the other file I commented.
import { publishing } from '@config/siteConfig.json';
skhameneh commented 2019-02-07 04:06:31 +01:00 (Migrated from github.com)
Review

Much of this is duplicated in the other file I commented.

Much of this is duplicated in the other file I commented.
skhameneh commented 2019-02-07 04:06:31 +01:00 (Migrated from github.com)
Review

Much of this is duplicated in the other file I commented.

Much of this is duplicated in the other file I commented.
const { fileSizeLimits } = publishing;
skhameneh commented 2019-02-07 04:06:31 +01:00 (Migrated from github.com)
Review

Much of this is duplicated in the other file I commented.

Much of this is duplicated in the other file I commented.
skhameneh commented 2019-02-07 04:06:31 +01:00 (Migrated from github.com)
Review

Much of this is duplicated in the other file I commented.

Much of this is duplicated in the other file I commented.
const SIZE_MB = 1000000;
skhameneh commented 2019-02-07 04:06:31 +01:00 (Migrated from github.com)
Review

Much of this is duplicated in the other file I commented.

Much of this is duplicated in the other file I commented.
skhameneh commented 2019-02-07 04:06:31 +01:00 (Migrated from github.com)
Review

Much of this is duplicated in the other file I commented.

Much of this is duplicated in the other file I commented.
export default function validateFileForPublish(file) {
skhameneh commented 2019-02-07 04:06:31 +01:00 (Migrated from github.com)
Review

Much of this is duplicated in the other file I commented.

Much of this is duplicated in the other file I commented.
let contentType = file.type;
skhameneh commented 2019-02-07 04:06:31 +01:00 (Migrated from github.com)
Review

Much of this is duplicated in the other file I commented.

Much of this is duplicated in the other file I commented.
let mediaType = contentType ? contentType.substr(0, contentType.indexOf('/')) : '';
skhameneh commented 2019-02-07 04:06:31 +01:00 (Migrated from github.com)
Review

Much of this is duplicated in the other file I commented.

Much of this is duplicated in the other file I commented.
let mediaTypeLimit = fileSizeLimits[mediaType] || false;
skhameneh commented 2019-02-07 04:06:31 +01:00 (Migrated from github.com)
Review

Much of this is duplicated in the other file I commented.

Much of this is duplicated in the other file I commented.
let customLimits = fileSizeLimits['customByContentType'];
skhameneh commented 2019-02-07 04:06:31 +01:00 (Migrated from github.com)
Review

Much of this is duplicated in the other file I commented.

Much of this is duplicated in the other file I commented.
skhameneh commented 2019-02-07 04:06:31 +01:00 (Migrated from github.com)
Review

Much of this is duplicated in the other file I commented.

Much of this is duplicated in the other file I commented.
if (!file) {
skhameneh commented 2019-02-07 04:06:31 +01:00 (Migrated from github.com)
Review

Much of this is duplicated in the other file I commented.

Much of this is duplicated in the other file I commented.
throw new Error('no file provided');
skhameneh commented 2019-02-07 04:06:31 +01:00 (Migrated from github.com)
Review

Much of this is duplicated in the other file I commented.

Much of this is duplicated in the other file I commented.
}
skhameneh commented 2019-02-07 04:06:31 +01:00 (Migrated from github.com)
Review

Much of this is duplicated in the other file I commented.

Much of this is duplicated in the other file I commented.
skhameneh commented 2019-02-07 04:06:31 +01:00 (Migrated from github.com)
Review

Much of this is duplicated in the other file I commented.

Much of this is duplicated in the other file I commented.
if (/'/.test(file.name)) {
skhameneh commented 2019-02-07 04:06:31 +01:00 (Migrated from github.com)
Review

Much of this is duplicated in the other file I commented.

Much of this is duplicated in the other file I commented.
throw new Error('apostrophes are not allowed in the file name');
skhameneh commented 2019-02-07 04:06:31 +01:00 (Migrated from github.com)
Review

Much of this is duplicated in the other file I commented.

Much of this is duplicated in the other file I commented.
}
skhameneh commented 2019-02-07 04:06:31 +01:00 (Migrated from github.com)
Review

Much of this is duplicated in the other file I commented.

Much of this is duplicated in the other file I commented.
skhameneh commented 2019-02-07 04:06:31 +01:00 (Migrated from github.com)
Review

Much of this is duplicated in the other file I commented.

Much of this is duplicated in the other file I commented.
if (Object.keys(customLimits).includes(contentType)) {
skhameneh commented 2019-02-07 04:06:31 +01:00 (Migrated from github.com)
Review

Much of this is duplicated in the other file I commented.

Much of this is duplicated in the other file I commented.
if (file.size > customLimits[contentType]) {
skhameneh commented 2019-02-07 04:06:31 +01:00 (Migrated from github.com)
Review

Much of this is duplicated in the other file I commented.

Much of this is duplicated in the other file I commented.
throw new Error(
skhameneh commented 2019-02-07 04:06:31 +01:00 (Migrated from github.com)
Review

Much of this is duplicated in the other file I commented.

Much of this is duplicated in the other file I commented.
`Sorry, type ${contentType} is limited to ${customLimits[contentType] / SIZE_MB} MB.`
skhameneh commented 2019-02-07 04:06:31 +01:00 (Migrated from github.com)
Review

Much of this is duplicated in the other file I commented.

Much of this is duplicated in the other file I commented.
);
skhameneh commented 2019-02-07 04:06:31 +01:00 (Migrated from github.com)
Review

Much of this is duplicated in the other file I commented.

Much of this is duplicated in the other file I commented.
}
skhameneh commented 2019-02-07 04:06:31 +01:00 (Migrated from github.com)
Review

Much of this is duplicated in the other file I commented.

Much of this is duplicated in the other file I commented.
}
skhameneh commented 2019-02-07 04:06:31 +01:00 (Migrated from github.com)
Review

Much of this is duplicated in the other file I commented.

Much of this is duplicated in the other file I commented.
if (mediaTypeLimit) {
skhameneh commented 2019-02-07 04:06:31 +01:00 (Migrated from github.com)
Review

Much of this is duplicated in the other file I commented.

Much of this is duplicated in the other file I commented.
if (file.size > mediaTypeLimit) {
skhameneh commented 2019-02-07 04:06:31 +01:00 (Migrated from github.com)
Review

Much of this is duplicated in the other file I commented.

Much of this is duplicated in the other file I commented.
throw new Error(`Sorry, type ${mediaType} is limited to ${mediaTypeLimit / SIZE_MB} MB.`);
skhameneh commented 2019-02-07 04:06:31 +01:00 (Migrated from github.com)
Review

Much of this is duplicated in the other file I commented.

Much of this is duplicated in the other file I commented.
}
skhameneh commented 2019-02-07 04:06:31 +01:00 (Migrated from github.com)
Review

Much of this is duplicated in the other file I commented.

Much of this is duplicated in the other file I commented.
}
skhameneh commented 2019-02-07 04:06:31 +01:00 (Migrated from github.com)
Review

Much of this is duplicated in the other file I commented.

Much of this is duplicated in the other file I commented.
return file;
skhameneh commented 2019-02-07 04:06:31 +01:00 (Migrated from github.com)
Review

Much of this is duplicated in the other file I commented.

Much of this is duplicated in the other file I commented.
}
skhameneh commented 2019-02-07 04:06:31 +01:00 (Migrated from github.com)
Review

Much of this is duplicated in the other file I commented.

Much of this is duplicated in the other file I commented.