LBRYCommunity/sqlboiler
1
0
Fork 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity

Fix randomization for enums with single value

Browse source 
Hey there,

I hit a bug that panicked the tests with:

    panic: invalid argument to Intn

The problem happened, because I have a Postgres `ENUM` with a single
value, that caused a `rand.Intn(0)` call, which panics on zero.

See: https://golang.org/src/math/rand/rand.go?s=4112:4142#L129
This commit is contained in:
Genadi Samokovarov 2017-06-14 16:53:55 +03:00
parent 17f2ec5108
commit 64206cfe07
2 changed files with 14 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
randomize/randomize.go
View file

@ -627,6 +627,8 @@ func randEnumValue(enum string) (string, error) {
vals := strmangle.ParseEnumVals(enum)
if vals == nil || len(vals) == 0 {
return "", fmt.Errorf("unable to parse enum string: %s", enum)
} else if len(vals) == 1 {
return vals[0], nil
}
return vals[rand.Intn(len(vals)-1)], nil

14
randomize/randomize_test.go
View file

@ -150,6 +150,7 @@ func TestRandEnumValue(t *testing.T) {
enum1 := "enum.workday('monday','tuesday')"
enum2 := "enum('monday','tuesday')"
enum3 := "enum('monday')"
r1, err := randEnumValue(enum1)
if err != nil {
@ -157,7 +158,7 @@ func TestRandEnumValue(t *testing.T) {
}
if r1 != "monday" && r1 != "tuesday" {
t.Errorf("Expected monday or tueday, got: %q", r1)
t.Errorf("Expected monday or tuesday, got: %q", r1)
}
r2, err := randEnumValue(enum2)
@ -166,6 +167,15 @@ func TestRandEnumValue(t *testing.T) {
}
if r2 != "monday" && r2 != "tuesday" {
t.Errorf("Expected monday or tueday, got: %q", r2)
t.Errorf("Expected monday or tuesday, got: %q", r2)
}
r3, err := randEnumValue(enum3)
if err != nil {
t.Error(err)
}
if r3 != "monday" {
t.Errorf("Expected monday got: %q", r3)
}
}