LBRYCommunity/sudo-prompt
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Fix Windows to return PERMISSION_DENIED Error even when Windows' error

Browse source 
messages are internationalized.

Fixes: #96
This commit is contained in:
Joran Dirk Greef 2019-06-01 10:36:22 +02:00
parent dc0c5f5494
commit 8d02007e4b
1 changed files with 7 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
index.js
View file

@ -445,15 +445,13 @@ function WindowsElevate(instance, end) {
command = command.join(' ');
var child = Node.child.exec(command,
function(error, stdout, stderr) {
if (error) {
if (/canceled by the user/i.test(error)) {
end(PERMISSION_DENIED);
} else {
end(error);
}
} else {
end();
}
// We used to return PERMISSION_DENIED only for error messages containing
// the string 'canceled by the user'. However, Windows internationalizes
// error messages (issue 96) so now we must assume all errors here are
// permission errors. This seems reasonable, given that we already run the
// user's command in a subshell.
if (error) return end(new Error(PERMISSION_DENIED));
end();
}
);
child.stdin.end(); // Otherwise PowerShell waits indefinitely on Windows 7.