Commit graph

153 commits

Author SHA1 Message Date
Joran Dirk Greef f677081dba Windows: Fix cd when cwd is on another drive 2018-03-22 08:48:58 +02:00
Joran Dirk Greef 8aef0421fb 8.1.0 2018-01-10 15:26:33 +02:00
Joran Dirk Greef 0ba8cf0b27 Linux: Increase maxBuffer limit to 128 MiB 2018-01-10 15:26:24 +02:00
Joran Dirk Greef ebb21118e6 8.0.0 2017-11-02 12:43:07 +02:00
Joran Dirk Greef 6a0577a387 Breaking: Windows: Set code page of command batch script to UTF-8 2017-11-02 12:43:00 +02:00
Joran Dirk Greef 30cd59a0c5 7.1.1 2017-07-18 15:18:25 +02:00
Joran Dirk Greef 6e9e7b6f84 readme: explicitly mention that no child process is returned 2017-07-18 15:18:16 +02:00
Joran Dirk Greef b88253fee2 7.1.0 2017-06-20 10:04:15 +02:00
Joran Dirk Greef 297b0d17a1 Detect when PowerShell fails to launch command 2017-06-20 10:04:09 +02:00
Joran Dirk Greef a7338f638c Escape ampersand and other characters special to PowerShell 2017-06-20 10:03:07 +02:00
Joran Dirk Greef 394dac03cc 7.0.0 2017-03-15 16:50:38 +02:00
Joran Dirk Greef 810e87f9ba Add status code to error on Windows and macOS 2017-03-15 16:50:30 +02:00
Joran Dirk Greef a9f1a9e58e 6.2.1 2016-12-16 10:52:43 +02:00
Joran Dirk Greef 086f754d58 Add syntax highlighting 2016-12-16 10:52:36 +02:00
Joran Dirk Greef 9f964d4085 6.2.0 2016-08-17 12:51:29 +02:00
Joran Dirk Greef c5a7467764 Rename OS X to macOS 2016-08-17 12:50:57 +02:00
Joran Dirk Greef cdc20f7ae4 6.1.0 2016-08-02 18:06:23 +02:00
Joran Dirk Greef 223d7bbc7a Merge pull request #29 from jviotti/polkit-agent-check
Yield an error if no polkit authentication agent was found
2016-08-02 18:05:10 +02:00
Juan Cruz Viotti 1acf3d4a70 Yield an error if no polkit authentication agent was found
`pkexec` prints an error to `stderr` if no authentication agent was
found, and if we pass the `--disable-internal-agent` option.

Currently, this module doesn't handle this edge case by yielding a
meaningful error, and therefore causes client applications to usually
miss it.

Fixes: https://github.com/jorangreef/sudo-prompt/issues/28
Signed-off-by: Juan Cruz Viotti <jviottidc@gmail.com>
2016-08-02 10:22:48 -04:00
Joran Dirk Greef 201dc8cf4f 6.0.2 2016-07-21 10:38:17 +02:00
Joran Dirk Greef beebd9efee Update explanation of Linux behavior 2016-07-21 10:38:07 +02:00
Joran Dirk Greef 6de1e859b1 6.0.1 2016-07-15 18:27:38 +02:00
Joran Dirk Greef 16bdf15dfc Update keywords 2016-07-15 18:27:29 +02:00
Joran Dirk Greef 1397993ec6 6.0.0 2016-07-15 17:13:29 +02:00
Joran Dirk Greef a57487d444 Add support for Windows 2016-07-15 17:13:03 +02:00
Joran Dirk Greef fd775d735c Add .jshintrc to .gitignore 2016-07-15 17:09:51 +02:00
Joran Dirk Greef a9511da6c2 5.1.0 2016-06-30 18:19:51 +02:00
Joran Dirk Greef 3a0aef7b53 Prefer kdesudo to pkexec for a better prompt 2016-06-30 18:19:21 +02:00
Joran Dirk Greef 2c29ce4890 Merge pull request #26 from jviotti/kdesudo-comment
Pass the `--comment` option to kdesudo to improve dialog
2016-06-29 08:40:22 +02:00
Juan Cruz Viotti 17f45ebef3 Pass the --comment option to kdesudo to improve dialog
Otherwise, `kdesudo` also displays the command as the dialog title,
making it very ugly and unfriendly.

Signed-off-by: Juan Cruz Viotti <jviottidc@gmail.com>
2016-06-28 17:16:27 -04:00
Joran Dirk Greef 4ee9e874be 5.0.3 2016-06-07 18:58:33 +02:00
Joran Dirk Greef 1acae8af6d Merge pull request #25 from jviotti/fix/stop-parsing-command-options-sudo
Don't keep parsing command options in sudo
2016-06-07 18:57:37 +02:00
Juan Cruz Viotti 37996169ed Don't keep parsing command options in sudo
This commit is very similar to 3f6c485. It implements the fix to the
same problem for `sudo` when the module makes an attempt to determine if
the dialog needs to be shown or not.

Signed-off-by: Juan Cruz Viotti <jviottidc@gmail.com>
2016-06-07 12:37:43 -04:00
Joran Dirk Greef b87b985bc3 5.0.2 2016-06-04 13:24:53 +02:00
Joran Dirk Greef 9e63556ad0 Remove comma 2016-06-04 13:24:44 +02:00
Joran Dirk Greef bef88907c7 5.0.1 2016-06-04 13:23:51 +02:00
Joran Dirk Greef 013ec59117 Remove mention of 2016-06-04 13:23:42 +02:00
Joran Dirk Greef d087fb9fd7 5.0.0 2016-06-04 13:17:27 +02:00
Joran Dirk Greef 1e11485bf4 Remove support for gksudo (gksudo breaks when used concurrently) 2016-06-04 13:17:14 +02:00
Joran Dirk Greef 69f6576045 4.0.1 2016-05-21 08:46:05 +02:00
Joran Dirk Greef b02973e8b7 Merge pull request #23 from jviotti/fix/option-params-gksudo
Don't keep parsing command options in gksudo and kdesudo
2016-05-21 08:45:20 +02:00
Juan Cruz Viotti 3f6c485c4d Don't keep parsing command options in gksudo/kdesudo
When `gksudo` is detected, this module executes the following command:

```
"/usr/bin/gksudo" --preserve-env --sudo-mode --description="MyApp" <COMMAND>
```

Consider the following command:

```
/home/jviotti/Projects/etcher/node_modules/electron-prebuilt/dist/electron /home/jviotti/Projects/etcher/lib/src/run-child-writer.js lib/start.js /home/jviotti/Downloads/CorePlus-current.iso --robot --drive /dev/sdb --unmount --check
```

Given that the command I'm running contains option arguments, it seems
like `gksudo` tries to interpret the options to my command as `gksudo`
options, failing with errors like this one:

```
/usr/bin/gksudo: unrecognized option '--robot'
```

To prevent this from happening, we can tell `gksudo` to stop parsing
options with the `--` identifier.

The same error happens with `kdesudo`.

Signed-off-by: Juan Cruz Viotti <jviottidc@gmail.com>
2016-05-20 13:15:38 -04:00
Joran Dirk Greef 41be5f72f0 4.0.0 2016-05-18 12:53:01 +02:00
Joran Dirk Greef e428e0b50a Merge branch 'master' of https://github.com/jorangreef/sudo-prompt 2016-05-18 12:52:04 +02:00
Joran Dirk Greef bd6c099453 Fix applet path to handle spaces 2016-05-18 12:51:54 +02:00
Joran Dirk Greef 5803d0155b Merge pull request #21 from jviotti/feat/preserve-environment
Preserve user environment if possible.
2016-05-18 08:53:56 +02:00
Juan Cruz Viotti 4a5baf5716 Preserve user environment
Some child processes executed with this module might benefit from being
able to read their parent process environment variables.

Fixes: https://github.com/jorangreef/sudo-prompt/issues/20
Signed-off-by: Juan Cruz Viotti <jviottidc@gmail.com>
2016-05-17 13:13:37 -04:00
Joran Dirk Greef d3cb072cff 3.1.0 2016-04-16 12:33:55 +02:00
Joran Dirk Greef 4a118a0c9c Preserve current working directory on OS X
This improves reliability for commands which expect the current working
directory to be preserved. This may not always be the case on Linux as yet.
2016-04-16 12:29:30 +02:00
Joran Dirk Greef 50147f9376 3.0.1 2016-04-15 15:40:00 +02:00