LBRYCommunity/tracker
1
0
Fork 0
Code Issues 1 Pull requests Packages Projects Releases Wiki Activity

explicitly copy values out of Storage

Browse source 
The previously implementation was using `&*` which is now getting
optimized by the Go compiler and no longer making a copy.
This commit is contained in:
Jimmy Zelinskie 2016-01-04 16:22:48 -05:00
parent 35ced4ab80
commit f70be94911
1 changed files with 9 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
tracker/storage.go
View file

@ -87,7 +87,8 @@ func (s *Storage) FindTorrent(infohash string) (*models.Torrent, error) {
return nil, models.ErrTorrentDNE
}
return &*torrent, nil
torrentCopy := *torrent
return &torrentCopy, nil
}
func (s *Storage) PutTorrent(torrent *models.Torrent) {
@ -98,7 +99,9 @@ func (s *Storage) PutTorrent(torrent *models.Torrent) {
if !exists {
atomic.AddInt32(&s.size, 1)
}
shard.torrents[torrent.Infohash] = &*torrent
torrentCopy := *torrent
shard.torrents[torrent.Infohash] = &torrentCopy
}
func (s *Storage) DeleteTorrent(infohash string) {
@ -257,14 +260,16 @@ func (s *Storage) FindUser(passkey string) (*models.User, error) {
return nil, models.ErrUserDNE
}
return &*user, nil
userCopy := *user
return &userCopy, nil
}
func (s *Storage) PutUser(user *models.User) {
s.usersM.Lock()
defer s.usersM.Unlock()
s.users[user.Passkey] = &*user
userCopy := *user
s.users[user.Passkey] = &userCopy
}
func (s *Storage) DeleteUser(passkey string) {