Thread safe, but unsafe

stats/percentile.go

@@ -3,6 +3,8 @@ package stats
 import (
 	"math"
 	"sort"
+	"sync/atomic"
+	"unsafe"
 )
 
 type Percentile struct {
@@ -10,17 +12,23 @@ type Percentile struct {
 
 	samples int64
 	offset  int64
+
 	values []float64
+	value  *unsafe.Pointer
 }
 
 func NewPercentile(percentile float64, sampleWindow int) *Percentile {
+	initial := 0
+	ptr := unsafe.Pointer(&initial)
+
 	return &Percentile{
 		percentile: percentile,
+
 		values: make([]float64, 0, sampleWindow),
+		value:  &ptr,
 	}
 }
 
-// Not thread safe.
 func (p *Percentile) AddSample(sample float64) {
 	p.samples++
 
@@ -55,14 +63,14 @@ func (p *Percentile) AddSample(sample float64) {
 		copy(p.values[idx+1:], p.values[idx:])
 		p.values[idx] = sample
 	}
+
+	value := p.values[p.index()]
+	atomic.SwapPointer(p.value, unsafe.Pointer(&value))
 }
 
 func (p *Percentile) Value() float64 {
-	if len(p.values) == 0 {
+	pointer := atomic.LoadPointer(p.value)
-		return 0
+	return *(*float64)(pointer)
-	}
-
-	return p.values[p.index()]
 }
 
 func (p *Percentile) index() int64 {

stats/stats.go

@@ -106,6 +106,10 @@ func (s *Stats) RecordEvent(event int) {
 	s.events <- event
 }
 
+func (s *Stats) RecordTiming(event int, duration time.Duration) {
+	// s.timingEvents <- event
+}
+
 func (s *Stats) handleEvents() {
 	for event := range s.events {
 		switch event {
@@ -178,7 +182,12 @@ func (s *Stats) handleEvents() {
 	}
 }
 
-// RecordEvent broadcasts an event to the default stats tracking.
+// RecordEvent broadcasts an event to the default stats queue.
 func RecordEvent(event int) {
 	DefaultStats.RecordEvent(event)
 }
+
+// RecordTiming broadcasts a timing event to the default stats queue.
+func RecordTiming(event int, duration time.Duration) {
+	DefaultStats.RecordTiming(event, duration)
+}