Started work on the next version of tipbot #9

Merged
filipnyquist merged 4 commits from next-tipbot into master 2018-07-06 15:52:09 +02:00
4 changed files with 119 additions and 3 deletions
Showing only changes of commit 2f348e2051 - Show all commits

4
.gitignore vendored
View file

@ -73,4 +73,6 @@ typings/
.serverless
# Configurations
default.json
default.json
.idea/*

View file

@ -23,7 +23,11 @@ yarn install
```
node index.js
```
>If you want to move over accounts from the old tipbot format which used usernames as identifier, run move_helper.js:
```
node move_helper.js
```
>It will automatically move over the old accounts to the new id based system.
## Contributing

View file

@ -67,6 +67,10 @@ function checkTweet(tweet, msg) {
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
case "terms":
doTerms(tweet, msg);
break;
case "lbryian":
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
logger.info("Got a command with the old format, handling it...");
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
checkTweet(tweet, msg.splice(1));
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
break;
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
}
}
@ -75,7 +79,7 @@ async function doHelp(tweet, msg) {
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
let post = await T.post("statuses/update", {
status:
`@${tweet.user.screen_name} `+
"All commands should be called with @ + subcommand \n" +
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
`All commands should be called with ${config.get("bot.handle")} + subcommand \n` +
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
"help - Shows this command. \n" +
"balance - Get your balance. \n" +
"deposit - Get address for your deposits. \n" +
@ -92,6 +96,13 @@ async function doHelp(tweet, msg) {
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
}
async function doTerms(tweet, msg){
// ADD terms
await T.post("statuses/update", {
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
status:
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
`@${tweet.user.screen_name} `+
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
"There are no fees to use this bot except the automatic daemon fee. \n"+
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
"In no event shall LBRY Inc be responsible in the event of lost, stolen or misdirected funds.",
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
in_reply_to_status_id: tweet.id_str
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
});
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
}
async function doBalance(tweet, msg) {
try {
@ -162,6 +173,7 @@ async function doTip(tweet, msg) {
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
});
}
const userToTip = tweet.entities.user_mentions.find(u => `@${u.screen_name}` === msg[2]).id_str;
await getAddress(id(userToTip)) // Call this to ensure user has an account.
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
if (userToTip === null) {
return await T.post("statuses/update", {
status: `@${tweet.user.screen_name} I could not find that user...`,
@ -206,6 +218,7 @@ async function getAddress(userId) {
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
logger.error(e);
}
}
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
nikooo777 commented 2018-07-06 12:28:24 +02:00 (Migrated from github.com)
Review

amount = amint.split("lbc")[0]; probably works too without having to worry too much about spaces or anything after "lbc".

Though it would have to be tested

`amount = amint.split("lbc")[0];` probably works too without having to worry too much about spaces or anything after "lbc". Though it would have to be tested
filipnyquist commented 2018-07-06 14:38:07 +02:00 (Migrated from github.com)
Review

Would probably work, want to keep it like this for now, as this function is the same in the discord tipbot :)

Would probably work, want to keep it like this for now, as this function is the same in the discord tipbot :)
function getValidatedAmount(amount) {
amount = amount.trim();
nikooo777 commented 2018-07-06 12:29:15 +02:00 (Migrated from github.com)
Review

if you return null how is that going to impact the originall call? Can it handle a null value? would it be better if it were 0?

if you return `null` how is that going to impact the originall call? Can it handle a null value? would it be better if it were `0`?
nikooo777 commented 2018-07-06 12:30:00 +02:00 (Migrated from github.com)
Review

ah nevermind i just saw the null check. that works too

ah nevermind i just saw the null check. that works too
if (amount.toLowerCase().endsWith("lbc")) {

nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!

97
move_helper.js Normal file
View file

@ -0,0 +1,97 @@
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
// This file helps with moving over accounts from the old username system to the id system.
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
// It uses the same configuration files as index.js
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
// Checks for the old format, gets their id from twitter, creates new acc, moves balance.
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
const Twit = require("twit");
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
const config = require("config");
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
const winston = require("winston");
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
require("winston-daily-rotate-file");
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
const Client = require("bitcoin-core");
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
const lbry = new Client({
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
version: "0.12.0",
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
username: config.get("lbrycrd.username"),
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
password: config.get("lbrycrd.password"),
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
port: config.get("lbrycrd.port")
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
});
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
const logger = winston.createLogger({
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
level: "info",
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
format: winston.format.json(),
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
transports: [
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
new winston.transports.DailyRotateFile({
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
filename: "move-helper-%DATE%.log",
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
dirname: "./logs",
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
datePattern: "YYYY-MM-DD-HH",
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
zippedArchive: true,
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
maxSize: "20m",
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
maxFiles: "14d"
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
}),
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
new winston.transports.Console({
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
format: winston.format.simple(),
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
level: "debug"
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
})
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
]
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
});
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
let notSynced = [];
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
const T = new Twit({
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
consumer_key: config.get("twitter.consumer_key"),
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
consumer_secret: config.get("twitter.consumer_secret"),
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
access_token: config.get("twitter.access_token"),
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
access_token_secret: config.get("twitter.access_token_secret"),
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
timeout_ms: 60 * 1000, // optional HTTP request timeout to apply to all requests.
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
strictSSL: true // optional - requires SSL certificates to be valid.
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
});
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
async function main(){
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
let accs = await getAccounts();
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
logger.info(`Trying to move ${accs.length} accounts...`)
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
for (let i in accs){
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
try {
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
//Get user details from twitter.
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
let data = await T.get('users/show', { screen_name: accs[i] });
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
//Create a account for the user by id.
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
let usr = data.data.id_str;
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
await getAddress(id(usr));
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
//Move over from old account to the new account
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
const balanceFromOld = await lbry.getBalance(`twttr-${accs[i]}`);
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
if (balanceFromOld !== 0) {
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
let res = await lbry.move(
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
`twttr-${accs[i]}`,
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
id(usr),
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
Number(balanceFromOld)
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
);
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
// If move is successful, log it!
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
if (res) logger.info(`Transferred ${balanceFromOld} LBC from twttr-${accs[i]} to ${id(usr)}!`);
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
}
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
}catch(e){
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
logger.info(`Could not sync ${accs[i]}, error occured:`, e.allErrors);
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
notSynced.push({ user: accs[i], error: e.allErrors});
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
logger.info("Could not sync these:"+JSON.stringify(notSynced));
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
}
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
}
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
}
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
// Get a list of all twitter accounts on lbrycrd.
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
async function getAccounts(){
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
let accs = await lbry.listAccounts();
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
accs = Object.entries(accs);
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
let accsArr = [];
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
for (let i in accs){
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
if(accs[i][0].startsWith('twttr-')) accsArr.push(accs[i][0].substring(6));
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
}
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
return accsArr;
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
}
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
async function getAddress(userId) {
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
try {
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
let uAddresses = await lbry.getAddressesByAccount(userId);
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
nikooo777 commented 2018-07-06 12:40:06 +02:00 (Migrated from github.com)
Review

i'm slightly confused. Is this function supposed to generate addresses for users that were tipped but didn't yet have an account to their user?

i'm slightly confused. Is this function supposed to generate addresses for users that were tipped but didn't yet have an account to their user?
filipnyquist commented 2018-07-06 14:33:25 +02:00 (Migrated from github.com)
Review

That function is there to assure that the user has a tipping account in the new format, as the user needs that for the bot to be able to move over from the old account to the new account.(This function follows the new id format instead of username)

That function is there to assure that the user has a tipping account in the new format, as the user needs that for the bot to be able to move over from the old account to the new account.(This function follows the new id format instead of username)
filipnyquist commented 2018-07-06 14:36:46 +02:00 (Migrated from github.com)
Review

So yep, it is there to generate adresses(accounts) for users not having an account already.

So yep, it is there to generate adresses(accounts) for users not having an account already.
if (uAddresses.length > 0) return;
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
await lbry.getNewAddress(userId);
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
return;
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
} catch (e) {
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
logger.error(e);
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
}
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
}
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
function id(usrId){
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
return `t-${usrId}`;
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
}
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
main();
nikooo777 commented 2018-07-06 12:43:17 +02:00 (Migrated from github.com)
Review

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?

you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
filipnyquist commented 2018-07-06 14:35:11 +02:00 (Migrated from github.com)
Review

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account

It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account