Started work on the next version of tipbot #9

Merged
filipnyquist merged 4 commits from next-tipbot into master 2018-07-06 15:52:09 +02:00
4 changed files with 104 additions and 26 deletions
Showing only changes of commit 559478cc40 - Show all commits

15
LICENSE Normal file
View file

@ -0,0 +1,15 @@
The MIT License (MIT)
Copyright (c) 2018 LBRY Inc
Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the
"Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish,
distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the
following conditions:
The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY
CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

42
README.md Normal file
View file

@ -0,0 +1,42 @@
# Twitter tipbot - A twitter tipbot for LBRY
This repo contains the twitter tipbot used by LBRY. This bot allows users to tip each other LBC on twitter.
## Installation
### Prerequisites
* Lbrycrd-daemon
* Node.js v8+
* Yarn
* A twitter application on the tipbot account
>To get started you should clone the git:
```
git clone https://github.com/lbryio/twitter-tipbot
```
>Install all modules with yarn:
```
yarn install
```
>Rename default.example.json to default.json and enter the twitter tokens and daemon settings.
>Run the bot with:
```
node index.js
```
## Contributing
Contributions to this project are welcome, encouraged, and compensated. For more details, see [lbry.io/faq/contributing](https://lbry.io/faq/contributing)
## License
This project is MIT Licensed © [LBRYio](https://github.com/lbryio)
## Security
We take security seriously. Please contact security@lbry.io regarding any security issues.
Our PGP key is [here](https://keybase.io/lbry/key.asc) if you need it.
## Contact
The primary contact for this project is [@filipnyquist](https://github.com/filipnyquist) (filip@lbry.io)

View file

@ -1,4 +1,8 @@
{
"bot":{
"handle": "@devlbctipbot",
"requiredConfirms": 2
},
"twitter": {
"consumer_key": "****",
"consumer_secret": "****",

View file

@ -37,12 +37,13 @@ const T = new Twit({
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
strictSSL: true // optional - requires SSL certificates to be valid.
});
var stream = T.stream("statuses/filter", { track: "@devlbctipbot" });
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
const stream = T.stream("statuses/filter", { track: config.get("bot.handle") });
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
logger.info("Started LBRY twitter tipbot.");
stream.on("tweet", function(tweet) {
if(tweet.user.screen_name === config.get("bot.handle").substring(1)) return;
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
let msg = checkTrunc(tweet);
nikooo777 commented 2018-07-06 12:16:01 +02:00 (Migrated from github.com)
Review

splitting produces an array, however the length of the array is never checked.

splitting produces an array, however the length of the array is never checked.
filipnyquist commented 2018-07-06 14:21:16 +02:00 (Migrated from github.com)
Review

I´ll add a check so that it contains atleast two items, the mention and the trigger word

I´ll add a check so that it contains atleast two items, the mention and the trigger word
msg = msg.slice(msg.indexOf("@devlbctipbot")).split(" ");
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
msg = msg.slice(msg.indexOf(config.get("bot.handle"))).split(" ");
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
checkTweet(tweet, msg);
});
@ -63,6 +64,9 @@ function checkTweet(tweet, msg) {
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
case "tip":
doTip(tweet, msg);
break;
case "terms":
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
doTerms(tweet, msg);
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
break;
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
}
}
@ -70,7 +74,8 @@ async function doHelp(tweet, msg) {
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
try {
let post = await T.post("statuses/update", {
status:
"All commands should be called with @ devlbctipbot \n" +
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
`@${tweet.user.screen_name} `+
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
"All commands should be called with @ + subcommand \n" +
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
"help - Shows this command. \n" +
"balance - Get your balance. \n" +
"deposit - Get address for your deposits. \n" +
@ -85,12 +90,15 @@ async function doHelp(tweet, msg) {
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
logger.error(e);
}
}
async function doTerms(tweet, msg){
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
// ADD terms
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
}
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
async function doBalance(tweet, msg) {
try {
const balance = await lbry.getBalance(tweet.user.id_str, 3);
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
const balance = await lbry.getBalance(id(tweet.user.id_str), config.get("bot.requiredConfirms")); // Amount of confirms before we can use it.
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
const post = await T.post("statuses/update", {
status: `You have ${balance} LBC.`,
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
in_reply_to_status_id: tweet.id_str
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
in_reply_to_status_id: tweet.id_str,
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
status: `@${tweet.user.screen_name} You have ${balance} LBC.`
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
});
logger.info(
`Sent balance command to ${tweet.user.screen_name}, tweet id: ${
@ -104,7 +112,7 @@ async function doBalance(tweet, msg) {
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
async function doDeposit(tweet, msg) {
try {
const post = await T.post("statuses/update", {
status: `Your deposit address is ${await getAddress(tweet.user.id_str)}.`,
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
status: `@${tweet.user.screen_name} Your deposit address is ${await getAddress(id(tweet.user.id_str))}.`,
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
in_reply_to_status_id: tweet.id_str
});
logger.info(
@ -117,18 +125,19 @@ async function doDeposit(tweet, msg) {
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
}
}
nikooo777 commented 2018-07-06 12:25:51 +02:00 (Migrated from github.com)
Review

Just a wild suggestion. Do you think integrating a QR to the tweet could be a cool thing to do? we could use an API like this one: https://api.qrserver.com/v1/create-qr-code/?size=200x200&data=bT7cCPUauRkuFvCNq8Fn1NkmuDMVBL768e (notice the address appended)

Just a wild suggestion. Do you think integrating a QR to the tweet could be a cool thing to do? we could use an API like this one: https://api.qrserver.com/v1/create-qr-code/?size=200x200&data=bT7cCPUauRkuFvCNq8Fn1NkmuDMVBL768e (notice the address appended)
filipnyquist commented 2018-07-06 14:37:39 +02:00 (Migrated from github.com)
Review

Sounds like a cool idea, adding it to an issue

Sounds like a cool idea, adding it to an issue
async function doWithdraw(tweet, msg) {
try {
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
if (msg.length < 4) return doHelp(tweet, msg);
let address = msg[2];
let amount = getValidatedAmount(msg[3]);
if (amount === null) {
return await T.post("statuses/update", {
status: `I don´t know how to withdraw that many credits...`,
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
status: `@${tweet.user.screen_name} I don´t know how to withdraw that many credits...`,
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
in_reply_to_status_id: tweet.id_str
});
}
let txId = await lbry.sendFrom(tweet.user.id_str, address, amount);
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
let txId = await lbry.sendFrom(id(tweet.user.id_str), address, amount);
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
await T.post("statuses/update", {
status: `You withdrew ${amount} LBC to ${address}. \n${txLink(txId)}`,
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
status: `@${tweet.user.screen_name} You withdrew ${amount} LBC to ${address}. \n${txLink(txId)}`,
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
in_reply_to_status_id: tweet.id_str
});
logger.info(
@ -136,7 +145,6 @@ async function doWithdraw(tweet, msg) {
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
tweet.user.screen_name
} withdraw ${amount} LBC to ${address}, tweet id: ${tweet.id_str}`
);
try {
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
} catch (e) {
logger.error(e);
}
@ -149,25 +157,35 @@ async function doTip(tweet, msg) {
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
const amount = getValidatedAmount(msg[3]);
if (amount === null) {
return await T.post("statuses/update", {
status: `I don´t know how to tip that many credits...`,
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
status: `@${tweet.user.screen_name} I don´t know how to tip that many credits...`,
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
in_reply_to_status_id: tweet.id_str
});
}
const userToTip = userToTip(tweet, msg);
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
const userToTipAddress = getAddress(userToTip);
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
const userToTip = tweet.entities.user_mentions.find(u => `@${u.screen_name}` === msg[2]).id_str;
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
if (userToTip === null) {
return await T.post("statuses/update", {
status: `I could not find that user...`,
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
status: `@${tweet.user.screen_name} I could not find that user...`,
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
in_reply_to_status_id: tweet.id_str
});
}
const txId = await lbry.sendFrom(
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
tweet.user.id_str,
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
userToTipAddress,
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
Number(amount),
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
null,
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
null
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
const balanceFromUser = await lbry.getBalance(id(tweet.user.id_str), config.get("bot.requiredConfirms"));
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
if (balanceFromUser < amount) {
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
return await T.post("statuses/update", {
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
status: `@${tweet.user.screen_name} You tried to tip, but you are missing ${amount-balanceFromUser} LBC.`,
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
in_reply_to_status_id: tweet.id_str
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
});
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
}
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
const txId = await lbry.move(
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
id(tweet.user.id_str),
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
id(userToTip),
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
Number(amount)
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
);
await T.post("statuses/update", {
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
status: `@${tweet.user.screen_name} Tipped ${
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
msg[2]
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
} ${amount} LBC! \n See https://lbry.io/faq/tipbot-twitter for more information.`,
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
in_reply_to_status_id: tweet.id_str
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
});
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
logger.info(
`@${tweet.user.screen_name}(${tweet.user.id_str}) tipped ${
msg[2]
@ -188,11 +206,6 @@ async function getAddress(userId) {
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
logger.error(e);
}
}
function userToTip(tweet, msg) {
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
const username = msg[2];
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
const users = tweet.entities.user_mentions;
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
return users.find(u => `@${u.screen_name}` === username).id_str;
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
}
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
function getValidatedAmount(amount) {
amount = amount.trim();
if (amount.toLowerCase().endsWith("lbc")) {
@ -207,3 +220,7 @@ function checkTrunc(tweet) {
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
if (tweet.truncated) return tweet.extended_tweet.full_text;
return tweet.text;
nikooo777 commented 2018-07-06 12:28:24 +02:00 (Migrated from github.com)
Review

amount = amint.split("lbc")[0]; probably works too without having to worry too much about spaces or anything after "lbc".

Though it would have to be tested

`amount = amint.split("lbc")[0];` probably works too without having to worry too much about spaces or anything after "lbc". Though it would have to be tested
filipnyquist commented 2018-07-06 14:38:07 +02:00 (Migrated from github.com)
Review

Would probably work, want to keep it like this for now, as this function is the same in the discord tipbot :)

Would probably work, want to keep it like this for now, as this function is the same in the discord tipbot :)
}
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
nikooo777 commented 2018-07-06 12:29:15 +02:00 (Migrated from github.com)
Review

if you return null how is that going to impact the originall call? Can it handle a null value? would it be better if it were 0?

if you return `null` how is that going to impact the originall call? Can it handle a null value? would it be better if it were `0`?
nikooo777 commented 2018-07-06 12:30:00 +02:00 (Migrated from github.com)
Review

ah nevermind i just saw the null check. that works too

ah nevermind i just saw the null check. that works too
function id(usrId){
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
return `t-${usrId}`;
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
}
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!

nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!
nikooo777 commented 2018-07-02 16:27:41 +02:00 (Migrated from github.com)
Review

don't forget to change or parameterize the track value.
also I'd use let rather than var.

don't forget to change or parameterize the track value. also I'd use `let` rather than var.
nikooo777 commented 2018-07-02 16:31:03 +02:00 (Migrated from github.com)
Review

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.

3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
nikooo777 commented 2018-07-06 12:09:04 +02:00 (Migrated from github.com)
Review

I don't think this is needed, is it?

I don't think this is needed, is it?
nikooo777 commented 2018-07-06 12:16:52 +02:00 (Migrated from github.com)
Review

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.

I would suggest adding a check somewhere in-between.

...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between.
nikooo777 commented 2018-07-06 12:18:35 +02:00 (Migrated from github.com)
Review

terms is missing

`terms` is missing
nikooo777 commented 2018-07-06 12:20:53 +02:00 (Migrated from github.com)
Review

My English isn't exceptional but I think the sentence should be changed to:

Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.

My English isn't exceptional but I think the sentence should be changed to: `Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
nikooo777 commented 2018-07-06 12:35:30 +02:00 (Migrated from github.com)
Review

You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.

`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
nikooo777 commented 2018-07-06 12:36:56 +02:00 (Migrated from github.com)
Review

I think it'd be nice to add a link to the explorer here (short if possible?)

I think it'd be nice to add a link to the explorer here (short if possible?)
filipnyquist commented 2018-07-06 14:20:47 +02:00 (Migrated from github.com)
Review

Correct, as i look through the library i can now see that it is not needed

Correct, as i look through the library i can now see that it is not needed
filipnyquist commented 2018-07-06 14:26:02 +02:00 (Migrated from github.com)
Review

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.

The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
filipnyquist commented 2018-07-06 14:37:08 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:15 +02:00 (Migrated from github.com)
Review

Will fix!

Will fix!
filipnyquist commented 2018-07-06 14:37:19 +02:00 (Migrated from github.com)
Review

Added!

Added!
filipnyquist commented 2018-07-06 14:37:26 +02:00 (Migrated from github.com)
Review

Check added!

Check added!