Started work on the next version of tipbot #9
20
index.js
|
|
@ -4,7 +4,6 @@ const winston = require("winston");
|
|||
I don't think this is needed, is it? I don't think this is needed, is it?
...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between. ...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.
I would suggest adding a check somewhere in-between.
`terms` is missing
My English isn't exceptional but I think the sentence should be changed to:
My English isn't exceptional but I think the sentence should be changed to:
`Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
I think it'd be nice to add a link to the explorer here (short if possible?) I think it'd be nice to add a link to the explorer here (short if possible?)
Correct, as i look through the library i can now see that it is not needed Correct, as i look through the library i can now see that it is not needed
The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet. The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
Will fix! Will fix!
Will fix! Will fix!
Added! Added!
Check added! Check added!
don't forget to change or parameterize the track value. don't forget to change or parameterize the track value.
also I'd use `let` rather than var.
3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read. 3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
I don't think this is needed, is it? I don't think this is needed, is it?
...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between. ...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.
I would suggest adding a check somewhere in-between.
`terms` is missing
My English isn't exceptional but I think the sentence should be changed to:
My English isn't exceptional but I think the sentence should be changed to:
`Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
I think it'd be nice to add a link to the explorer here (short if possible?) I think it'd be nice to add a link to the explorer here (short if possible?)
Correct, as i look through the library i can now see that it is not needed Correct, as i look through the library i can now see that it is not needed
The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet. The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
Will fix! Will fix!
Will fix! Will fix!
Added! Added!
Check added! Check added!
|
||||
require("winston-daily-rotate-file");
|
||||
const Client = require("bitcoin-core");
|
||||
const lbry = new Client({
|
||||
version: "0.12.0",
|
||||
|
don't forget to change or parameterize the track value. don't forget to change or parameterize the track value.
also I'd use `let` rather than var.
3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read. 3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
I don't think this is needed, is it? I don't think this is needed, is it?
...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between. ...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.
I would suggest adding a check somewhere in-between.
`terms` is missing
My English isn't exceptional but I think the sentence should be changed to:
My English isn't exceptional but I think the sentence should be changed to:
`Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
I think it'd be nice to add a link to the explorer here (short if possible?) I think it'd be nice to add a link to the explorer here (short if possible?)
Correct, as i look through the library i can now see that it is not needed Correct, as i look through the library i can now see that it is not needed
The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet. The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
Will fix! Will fix!
Will fix! Will fix!
Added! Added!
Check added! Check added!
|
||||
username: config.get("lbrycrd.username"),
|
||||
password: config.get("lbrycrd.password"),
|
||||
port: config.get("lbrycrd.port")
|
||||
|
|
@ -44,7 +43,7 @@ stream.on("tweet", function(tweet) {
|
|||
|
don't forget to change or parameterize the track value. don't forget to change or parameterize the track value.
also I'd use `let` rather than var.
3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read. 3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
I don't think this is needed, is it? I don't think this is needed, is it?
...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between. ...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.
I would suggest adding a check somewhere in-between.
`terms` is missing
My English isn't exceptional but I think the sentence should be changed to:
My English isn't exceptional but I think the sentence should be changed to:
`Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
I think it'd be nice to add a link to the explorer here (short if possible?) I think it'd be nice to add a link to the explorer here (short if possible?)
Correct, as i look through the library i can now see that it is not needed Correct, as i look through the library i can now see that it is not needed
The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet. The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
Will fix! Will fix!
Will fix! Will fix!
Added! Added!
Check added! Check added!
don't forget to change or parameterize the track value. don't forget to change or parameterize the track value.
also I'd use `let` rather than var.
3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read. 3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
I don't think this is needed, is it? I don't think this is needed, is it?
...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between. ...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.
I would suggest adding a check somewhere in-between.
`terms` is missing
My English isn't exceptional but I think the sentence should be changed to:
My English isn't exceptional but I think the sentence should be changed to:
`Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
I think it'd be nice to add a link to the explorer here (short if possible?) I think it'd be nice to add a link to the explorer here (short if possible?)
Correct, as i look through the library i can now see that it is not needed Correct, as i look through the library i can now see that it is not needed
The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet. The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
Will fix! Will fix!
Will fix! Will fix!
Added! Added!
Check added! Check added!
|
||||
if(tweet.user.screen_name === config.get("bot.handle").substring(1)) return;
|
||||
let msg = checkTrunc(tweet);
|
||||
msg = msg.slice(msg.indexOf(config.get("bot.handle"))).split(" ");
|
||||
|
splitting produces an array, however the length of the array is never checked. splitting produces an array, however the length of the array is never checked.
I´ll add a check so that it contains atleast two items, the mention and the trigger word I´ll add a check so that it contains atleast two items, the mention and the trigger word
|
||||
checkTweet(tweet, msg);
|
||||
|
don't forget to change or parameterize the track value. don't forget to change or parameterize the track value.
also I'd use `let` rather than var.
3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read. 3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
I don't think this is needed, is it? I don't think this is needed, is it?
...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between. ...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.
I would suggest adding a check somewhere in-between.
`terms` is missing
My English isn't exceptional but I think the sentence should be changed to:
My English isn't exceptional but I think the sentence should be changed to:
`Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
I think it'd be nice to add a link to the explorer here (short if possible?) I think it'd be nice to add a link to the explorer here (short if possible?)
Correct, as i look through the library i can now see that it is not needed Correct, as i look through the library i can now see that it is not needed
The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet. The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
Will fix! Will fix!
Will fix! Will fix!
Added! Added!
Check added! Check added!
|
||||
if (msg.length >= 2) checkTweet(tweet, msg);
|
||||
|
don't forget to change or parameterize the track value. don't forget to change or parameterize the track value.
also I'd use `let` rather than var.
3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read. 3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
I don't think this is needed, is it? I don't think this is needed, is it?
...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between. ...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.
I would suggest adding a check somewhere in-between.
`terms` is missing
My English isn't exceptional but I think the sentence should be changed to:
My English isn't exceptional but I think the sentence should be changed to:
`Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
I think it'd be nice to add a link to the explorer here (short if possible?) I think it'd be nice to add a link to the explorer here (short if possible?)
Correct, as i look through the library i can now see that it is not needed Correct, as i look through the library i can now see that it is not needed
The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet. The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
Will fix! Will fix!
Will fix! Will fix!
Added! Added!
Check added! Check added!
|
||||
});
|
||||
|
||||
function checkTweet(tweet, msg) {
|
||||
|
|
@ -84,7 +83,8 @@ async function doHelp(tweet, msg) {
|
|||
|
don't forget to change or parameterize the track value. don't forget to change or parameterize the track value.
also I'd use `let` rather than var.
3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read. 3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
I don't think this is needed, is it? I don't think this is needed, is it?
...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between. ...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.
I would suggest adding a check somewhere in-between.
`terms` is missing
My English isn't exceptional but I think the sentence should be changed to:
My English isn't exceptional but I think the sentence should be changed to:
`Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
I think it'd be nice to add a link to the explorer here (short if possible?) I think it'd be nice to add a link to the explorer here (short if possible?)
Correct, as i look through the library i can now see that it is not needed Correct, as i look through the library i can now see that it is not needed
The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet. The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
Will fix! Will fix!
Will fix! Will fix!
Added! Added!
Check added! Check added!
don't forget to change or parameterize the track value. don't forget to change or parameterize the track value.
also I'd use `let` rather than var.
3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read. 3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
I don't think this is needed, is it? I don't think this is needed, is it?
...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between. ...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.
I would suggest adding a check somewhere in-between.
`terms` is missing
My English isn't exceptional but I think the sentence should be changed to:
My English isn't exceptional but I think the sentence should be changed to:
`Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
I think it'd be nice to add a link to the explorer here (short if possible?) I think it'd be nice to add a link to the explorer here (short if possible?)
Correct, as i look through the library i can now see that it is not needed Correct, as i look through the library i can now see that it is not needed
The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet. The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
Will fix! Will fix!
Will fix! Will fix!
Added! Added!
Check added! Check added!
|
||||
"balance - Get your balance. \n" +
|
||||
"deposit - Get address for your deposits. \n" +
|
||||
"withdraw ADDRESS AMOUNT - Withdraw AMOUNT credits to ADDRESS. \n" +
|
||||
"tip USER AMOUNT - Tip USER AMOUNT.",
|
||||
|
don't forget to change or parameterize the track value. don't forget to change or parameterize the track value.
also I'd use `let` rather than var.
3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read. 3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
I don't think this is needed, is it? I don't think this is needed, is it?
...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between. ...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.
I would suggest adding a check somewhere in-between.
`terms` is missing
My English isn't exceptional but I think the sentence should be changed to:
My English isn't exceptional but I think the sentence should be changed to:
`Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
I think it'd be nice to add a link to the explorer here (short if possible?) I think it'd be nice to add a link to the explorer here (short if possible?)
Correct, as i look through the library i can now see that it is not needed Correct, as i look through the library i can now see that it is not needed
The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet. The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
Will fix! Will fix!
Will fix! Will fix!
Added! Added!
Check added! Check added!
|
||||
"tip USER AMOUNT - Tip USER AMOUNT.\n"+
|
||||
|
don't forget to change or parameterize the track value. don't forget to change or parameterize the track value.
also I'd use `let` rather than var.
3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read. 3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
I don't think this is needed, is it? I don't think this is needed, is it?
...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between. ...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.
I would suggest adding a check somewhere in-between.
`terms` is missing
My English isn't exceptional but I think the sentence should be changed to:
My English isn't exceptional but I think the sentence should be changed to:
`Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
I think it'd be nice to add a link to the explorer here (short if possible?) I think it'd be nice to add a link to the explorer here (short if possible?)
Correct, as i look through the library i can now see that it is not needed Correct, as i look through the library i can now see that it is not needed
The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet. The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
Will fix! Will fix!
Will fix! Will fix!
Added! Added!
Check added! Check added!
|
||||
"terms - Sends you the TOS.",
|
||||
|
don't forget to change or parameterize the track value. don't forget to change or parameterize the track value.
also I'd use `let` rather than var.
3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read. 3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
I don't think this is needed, is it? I don't think this is needed, is it?
...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between. ...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.
I would suggest adding a check somewhere in-between.
`terms` is missing
My English isn't exceptional but I think the sentence should be changed to:
My English isn't exceptional but I think the sentence should be changed to:
`Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
I think it'd be nice to add a link to the explorer here (short if possible?) I think it'd be nice to add a link to the explorer here (short if possible?)
Correct, as i look through the library i can now see that it is not needed Correct, as i look through the library i can now see that it is not needed
The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet. The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
Will fix! Will fix!
Will fix! Will fix!
Added! Added!
Check added! Check added!
|
||||
in_reply_to_status_id: tweet.id_str
|
||||
});
|
||||
logger.info(
|
||||
|
|
@ -100,7 +100,7 @@ async function doTerms(tweet, msg){
|
|||
|
don't forget to change or parameterize the track value. don't forget to change or parameterize the track value.
also I'd use `let` rather than var.
3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read. 3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
I don't think this is needed, is it? I don't think this is needed, is it?
...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between. ...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.
I would suggest adding a check somewhere in-between.
`terms` is missing
My English isn't exceptional but I think the sentence should be changed to:
My English isn't exceptional but I think the sentence should be changed to:
`Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
I think it'd be nice to add a link to the explorer here (short if possible?) I think it'd be nice to add a link to the explorer here (short if possible?)
Correct, as i look through the library i can now see that it is not needed Correct, as i look through the library i can now see that it is not needed
The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet. The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
Will fix! Will fix!
Will fix! Will fix!
Added! Added!
Check added! Check added!
don't forget to change or parameterize the track value. don't forget to change or parameterize the track value.
also I'd use `let` rather than var.
3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read. 3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
I don't think this is needed, is it? I don't think this is needed, is it?
...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between. ...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.
I would suggest adding a check somewhere in-between.
`terms` is missing
My English isn't exceptional but I think the sentence should be changed to:
My English isn't exceptional but I think the sentence should be changed to:
`Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
I think it'd be nice to add a link to the explorer here (short if possible?) I think it'd be nice to add a link to the explorer here (short if possible?)
Correct, as i look through the library i can now see that it is not needed Correct, as i look through the library i can now see that it is not needed
The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet. The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
Will fix! Will fix!
Will fix! Will fix!
Added! Added!
Check added! Check added!
|
||||
status:
|
||||
`@${tweet.user.screen_name} `+
|
||||
"There are no fees to use this bot except the automatic daemon fee. \n"+
|
||||
"In no event shall LBRY Inc be responsible in the event of lost, stolen or misdirected funds.",
|
||||
|
don't forget to change or parameterize the track value. don't forget to change or parameterize the track value.
also I'd use `let` rather than var.
3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read. 3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
I don't think this is needed, is it? I don't think this is needed, is it?
...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between. ...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.
I would suggest adding a check somewhere in-between.
`terms` is missing
My English isn't exceptional but I think the sentence should be changed to:
My English isn't exceptional but I think the sentence should be changed to:
`Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
I think it'd be nice to add a link to the explorer here (short if possible?) I think it'd be nice to add a link to the explorer here (short if possible?)
Correct, as i look through the library i can now see that it is not needed Correct, as i look through the library i can now see that it is not needed
The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet. The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
Will fix! Will fix!
Will fix! Will fix!
Added! Added!
Check added! Check added!
|
||||
"Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.",
|
||||
|
don't forget to change or parameterize the track value. don't forget to change or parameterize the track value.
also I'd use `let` rather than var.
3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read. 3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
I don't think this is needed, is it? I don't think this is needed, is it?
...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between. ...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.
I would suggest adding a check somewhere in-between.
`terms` is missing
My English isn't exceptional but I think the sentence should be changed to:
My English isn't exceptional but I think the sentence should be changed to:
`Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
I think it'd be nice to add a link to the explorer here (short if possible?) I think it'd be nice to add a link to the explorer here (short if possible?)
Correct, as i look through the library i can now see that it is not needed Correct, as i look through the library i can now see that it is not needed
The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet. The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
Will fix! Will fix!
Will fix! Will fix!
Added! Added!
Check added! Check added!
|
||||
in_reply_to_status_id: tweet.id_str
|
||||
});
|
||||
}
|
||||
|
|
@ -173,7 +173,7 @@ async function doTip(tweet, msg) {
|
|||
|
don't forget to change or parameterize the track value. don't forget to change or parameterize the track value.
also I'd use `let` rather than var.
3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read. 3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
I don't think this is needed, is it? I don't think this is needed, is it?
...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between. ...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.
I would suggest adding a check somewhere in-between.
`terms` is missing
My English isn't exceptional but I think the sentence should be changed to:
My English isn't exceptional but I think the sentence should be changed to:
`Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
I think it'd be nice to add a link to the explorer here (short if possible?) I think it'd be nice to add a link to the explorer here (short if possible?)
Correct, as i look through the library i can now see that it is not needed Correct, as i look through the library i can now see that it is not needed
The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet. The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
Will fix! Will fix!
Will fix! Will fix!
Added! Added!
Check added! Check added!
don't forget to change or parameterize the track value. don't forget to change or parameterize the track value.
also I'd use `let` rather than var.
3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read. 3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
I don't think this is needed, is it? I don't think this is needed, is it?
...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between. ...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.
I would suggest adding a check somewhere in-between.
`terms` is missing
My English isn't exceptional but I think the sentence should be changed to:
My English isn't exceptional but I think the sentence should be changed to:
`Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
I think it'd be nice to add a link to the explorer here (short if possible?) I think it'd be nice to add a link to the explorer here (short if possible?)
Correct, as i look through the library i can now see that it is not needed Correct, as i look through the library i can now see that it is not needed
The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet. The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
Will fix! Will fix!
Will fix! Will fix!
Added! Added!
Check added! Check added!
|
||||
});
|
||||
}
|
||||
const userToTip = tweet.entities.user_mentions.find(u => `@${u.screen_name}` === msg[2]).id_str;
|
||||
await getAddress(id(userToTip)) // Call this to ensure user has an account.
|
||||
|
don't forget to change or parameterize the track value. don't forget to change or parameterize the track value.
also I'd use `let` rather than var.
3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read. 3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
I don't think this is needed, is it? I don't think this is needed, is it?
...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between. ...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.
I would suggest adding a check somewhere in-between.
`terms` is missing
My English isn't exceptional but I think the sentence should be changed to:
My English isn't exceptional but I think the sentence should be changed to:
`Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
I think it'd be nice to add a link to the explorer here (short if possible?) I think it'd be nice to add a link to the explorer here (short if possible?)
Correct, as i look through the library i can now see that it is not needed Correct, as i look through the library i can now see that it is not needed
The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet. The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
Will fix! Will fix!
Will fix! Will fix!
Added! Added!
Check added! Check added!
|
||||
let tipToAddress = await getAddress(id(userToTip)) // Call this to ensure user has an account.
|
||||
|
don't forget to change or parameterize the track value. don't forget to change or parameterize the track value.
also I'd use `let` rather than var.
3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read. 3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
I don't think this is needed, is it? I don't think this is needed, is it?
...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between. ...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.
I would suggest adding a check somewhere in-between.
`terms` is missing
My English isn't exceptional but I think the sentence should be changed to:
My English isn't exceptional but I think the sentence should be changed to:
`Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
I think it'd be nice to add a link to the explorer here (short if possible?) I think it'd be nice to add a link to the explorer here (short if possible?)
Correct, as i look through the library i can now see that it is not needed Correct, as i look through the library i can now see that it is not needed
The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet. The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
Will fix! Will fix!
Will fix! Will fix!
Added! Added!
Check added! Check added!
|
||||
if (userToTip === null) {
|
||||
return await T.post("statuses/update", {
|
||||
status: `@${tweet.user.screen_name} I could not find that user...`,
|
||||
|
|
@ -183,19 +183,15 @@ async function doTip(tweet, msg) {
|
|||
|
don't forget to change or parameterize the track value. don't forget to change or parameterize the track value.
also I'd use `let` rather than var.
3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read. 3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
I don't think this is needed, is it? I don't think this is needed, is it?
...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between. ...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.
I would suggest adding a check somewhere in-between.
`terms` is missing
My English isn't exceptional but I think the sentence should be changed to:
My English isn't exceptional but I think the sentence should be changed to:
`Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
I think it'd be nice to add a link to the explorer here (short if possible?) I think it'd be nice to add a link to the explorer here (short if possible?)
Correct, as i look through the library i can now see that it is not needed Correct, as i look through the library i can now see that it is not needed
The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet. The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
Will fix! Will fix!
Will fix! Will fix!
Added! Added!
Check added! Check added!
don't forget to change or parameterize the track value. don't forget to change or parameterize the track value.
also I'd use `let` rather than var.
3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read. 3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
I don't think this is needed, is it? I don't think this is needed, is it?
...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between. ...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.
I would suggest adding a check somewhere in-between.
`terms` is missing
My English isn't exceptional but I think the sentence should be changed to:
My English isn't exceptional but I think the sentence should be changed to:
`Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
I think it'd be nice to add a link to the explorer here (short if possible?) I think it'd be nice to add a link to the explorer here (short if possible?)
Correct, as i look through the library i can now see that it is not needed Correct, as i look through the library i can now see that it is not needed
The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet. The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
Will fix! Will fix!
Will fix! Will fix!
Added! Added!
Check added! Check added!
|
||||
const balanceFromUser = await lbry.getBalance(id(tweet.user.id_str), config.get("bot.requiredConfirms"));
|
||||
if (balanceFromUser < amount) {
|
||||
return await T.post("statuses/update", {
|
||||
status: `@${tweet.user.screen_name} You tried to tip, but you are missing ${amount-balanceFromUser} LBC.`,
|
||||
|
don't forget to change or parameterize the track value. don't forget to change or parameterize the track value.
also I'd use `let` rather than var.
3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read. 3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
I don't think this is needed, is it? I don't think this is needed, is it?
...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between. ...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.
I would suggest adding a check somewhere in-between.
`terms` is missing
My English isn't exceptional but I think the sentence should be changed to:
My English isn't exceptional but I think the sentence should be changed to:
`Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
I think it'd be nice to add a link to the explorer here (short if possible?) I think it'd be nice to add a link to the explorer here (short if possible?)
Correct, as i look through the library i can now see that it is not needed Correct, as i look through the library i can now see that it is not needed
The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet. The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
Will fix! Will fix!
Will fix! Will fix!
Added! Added!
Check added! Check added!
|
||||
status: `@${tweet.user.screen_name} You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`,
|
||||
|
don't forget to change or parameterize the track value. don't forget to change or parameterize the track value.
also I'd use `let` rather than var.
3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read. 3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
I don't think this is needed, is it? I don't think this is needed, is it?
...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between. ...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.
I would suggest adding a check somewhere in-between.
`terms` is missing
My English isn't exceptional but I think the sentence should be changed to:
My English isn't exceptional but I think the sentence should be changed to:
`Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
I think it'd be nice to add a link to the explorer here (short if possible?) I think it'd be nice to add a link to the explorer here (short if possible?)
Correct, as i look through the library i can now see that it is not needed Correct, as i look through the library i can now see that it is not needed
The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet. The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
Will fix! Will fix!
Will fix! Will fix!
Added! Added!
Check added! Check added!
|
||||
in_reply_to_status_id: tweet.id_str
|
||||
});
|
||||
}
|
||||
const txId = await lbry.move(
|
||||
|
don't forget to change or parameterize the track value. don't forget to change or parameterize the track value.
also I'd use `let` rather than var.
3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read. 3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
I don't think this is needed, is it? I don't think this is needed, is it?
...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between. ...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.
I would suggest adding a check somewhere in-between.
`terms` is missing
My English isn't exceptional but I think the sentence should be changed to:
My English isn't exceptional but I think the sentence should be changed to:
`Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
I think it'd be nice to add a link to the explorer here (short if possible?) I think it'd be nice to add a link to the explorer here (short if possible?)
Correct, as i look through the library i can now see that it is not needed Correct, as i look through the library i can now see that it is not needed
The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet. The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
Will fix! Will fix!
Will fix! Will fix!
Added! Added!
Check added! Check added!
|
||||
id(tweet.user.id_str),
|
||||
|
don't forget to change or parameterize the track value. don't forget to change or parameterize the track value.
also I'd use `let` rather than var.
3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read. 3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
I don't think this is needed, is it? I don't think this is needed, is it?
...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between. ...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.
I would suggest adding a check somewhere in-between.
`terms` is missing
My English isn't exceptional but I think the sentence should be changed to:
My English isn't exceptional but I think the sentence should be changed to:
`Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
I think it'd be nice to add a link to the explorer here (short if possible?) I think it'd be nice to add a link to the explorer here (short if possible?)
Correct, as i look through the library i can now see that it is not needed Correct, as i look through the library i can now see that it is not needed
The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet. The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
Will fix! Will fix!
Will fix! Will fix!
Added! Added!
Check added! Check added!
|
||||
id(userToTip),
|
||||
|
don't forget to change or parameterize the track value. don't forget to change or parameterize the track value.
also I'd use `let` rather than var.
3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read. 3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
I don't think this is needed, is it? I don't think this is needed, is it?
...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between. ...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.
I would suggest adding a check somewhere in-between.
`terms` is missing
My English isn't exceptional but I think the sentence should be changed to:
My English isn't exceptional but I think the sentence should be changed to:
`Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
I think it'd be nice to add a link to the explorer here (short if possible?) I think it'd be nice to add a link to the explorer here (short if possible?)
Correct, as i look through the library i can now see that it is not needed Correct, as i look through the library i can now see that it is not needed
The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet. The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
Will fix! Will fix!
Will fix! Will fix!
Added! Added!
Check added! Check added!
|
||||
Number(amount)
|
||||
|
don't forget to change or parameterize the track value. don't forget to change or parameterize the track value.
also I'd use `let` rather than var.
3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read. 3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
I don't think this is needed, is it? I don't think this is needed, is it?
...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between. ...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.
I would suggest adding a check somewhere in-between.
`terms` is missing
My English isn't exceptional but I think the sentence should be changed to:
My English isn't exceptional but I think the sentence should be changed to:
`Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
I think it'd be nice to add a link to the explorer here (short if possible?) I think it'd be nice to add a link to the explorer here (short if possible?)
Correct, as i look through the library i can now see that it is not needed Correct, as i look through the library i can now see that it is not needed
The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet. The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
Will fix! Will fix!
Will fix! Will fix!
Added! Added!
Check added! Check added!
|
||||
);
|
||||
|
don't forget to change or parameterize the track value. don't forget to change or parameterize the track value.
also I'd use `let` rather than var.
3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read. 3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
I don't think this is needed, is it? I don't think this is needed, is it?
...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between. ...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.
I would suggest adding a check somewhere in-between.
`terms` is missing
My English isn't exceptional but I think the sentence should be changed to:
My English isn't exceptional but I think the sentence should be changed to:
`Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
I think it'd be nice to add a link to the explorer here (short if possible?) I think it'd be nice to add a link to the explorer here (short if possible?)
Correct, as i look through the library i can now see that it is not needed Correct, as i look through the library i can now see that it is not needed
The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet. The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
Will fix! Will fix!
Will fix! Will fix!
Added! Added!
Check added! Check added!
|
||||
const txId = await lbry.sendFrom(id(tweet.user.id_str), tipToAddress, Number(amount), 1);
|
||||
|
don't forget to change or parameterize the track value. don't forget to change or parameterize the track value.
also I'd use `let` rather than var.
3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read. 3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
I don't think this is needed, is it? I don't think this is needed, is it?
...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between. ...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.
I would suggest adding a check somewhere in-between.
`terms` is missing
My English isn't exceptional but I think the sentence should be changed to:
My English isn't exceptional but I think the sentence should be changed to:
`Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
I think it'd be nice to add a link to the explorer here (short if possible?) I think it'd be nice to add a link to the explorer here (short if possible?)
Correct, as i look through the library i can now see that it is not needed Correct, as i look through the library i can now see that it is not needed
The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet. The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
Will fix! Will fix!
Will fix! Will fix!
Added! Added!
Check added! Check added!
|
||||
await T.post("statuses/update", {
|
||||
status: `@${tweet.user.screen_name} Tipped ${
|
||||
msg[2]
|
||||
} ${amount} LBC! \n See https://lbry.io/faq/tipbot-twitter for more information.`,
|
||||
|
don't forget to change or parameterize the track value. don't forget to change or parameterize the track value.
also I'd use `let` rather than var.
3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read. 3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
I don't think this is needed, is it? I don't think this is needed, is it?
...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between. ...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.
I would suggest adding a check somewhere in-between.
`terms` is missing
My English isn't exceptional but I think the sentence should be changed to:
My English isn't exceptional but I think the sentence should be changed to:
`Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
I think it'd be nice to add a link to the explorer here (short if possible?) I think it'd be nice to add a link to the explorer here (short if possible?)
Correct, as i look through the library i can now see that it is not needed Correct, as i look through the library i can now see that it is not needed
The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet. The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
Will fix! Will fix!
Will fix! Will fix!
Added! Added!
Check added! Check added!
|
||||
} ${amount} LBC! \nTransaction: ${txLink(txId)} \nSee https://lbry.io/faq/tipbot-twitter for more information.`,
|
||||
|
don't forget to change or parameterize the track value. don't forget to change or parameterize the track value.
also I'd use `let` rather than var.
3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read. 3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
I don't think this is needed, is it? I don't think this is needed, is it?
...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between. ...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.
I would suggest adding a check somewhere in-between.
`terms` is missing
My English isn't exceptional but I think the sentence should be changed to:
My English isn't exceptional but I think the sentence should be changed to:
`Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
I think it'd be nice to add a link to the explorer here (short if possible?) I think it'd be nice to add a link to the explorer here (short if possible?)
Correct, as i look through the library i can now see that it is not needed Correct, as i look through the library i can now see that it is not needed
The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet. The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
Will fix! Will fix!
Will fix! Will fix!
Added! Added!
Check added! Check added!
|
||||
in_reply_to_status_id: tweet.id_str
|
||||
});
|
||||
logger.info(
|
||||
|
|
|
|||
|
don't forget to change or parameterize the track value. don't forget to change or parameterize the track value.
also I'd use `let` rather than var.
3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read. 3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
I don't think this is needed, is it? I don't think this is needed, is it?
...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between. ...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.
I would suggest adding a check somewhere in-between.
`terms` is missing
My English isn't exceptional but I think the sentence should be changed to:
My English isn't exceptional but I think the sentence should be changed to:
`Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
I think it'd be nice to add a link to the explorer here (short if possible?) I think it'd be nice to add a link to the explorer here (short if possible?)
Correct, as i look through the library i can now see that it is not needed Correct, as i look through the library i can now see that it is not needed
The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet. The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
Will fix! Will fix!
Will fix! Will fix!
Added! Added!
Check added! Check added!
don't forget to change or parameterize the track value. don't forget to change or parameterize the track value.
also I'd use `let` rather than var.
3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read. 3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.
I don't think this is needed, is it? I don't think this is needed, is it?
...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries. I would suggest adding a check somewhere in-between. ...thus if the split didn't go right, there is a chance that the bot crashes on this line as the array doesn't have at least 2 entries.
I would suggest adding a check somewhere in-between.
`terms` is missing
My English isn't exceptional but I think the sentence should be changed to:
My English isn't exceptional but I think the sentence should be changed to:
`Under no circumstances shall LBRY Inc. be held responsible for lost, stolen or misdirected funds.`
`You tried tipping more than you have! You are ${amount-balanceFromUser} LBC short.`
I think it'd be nice to add a link to the explorer here (short if possible?) I think it'd be nice to add a link to the explorer here (short if possible?)
Correct, as i look through the library i can now see that it is not needed Correct, as i look through the library i can now see that it is not needed
The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet. The tipping here is internally, which means it just moves the amount between the accounts, this helps us skip fees. So the coins shows up directly in the other persons wallet.
Will fix! Will fix!
Will fix! Will fix!
Added! Added!
Check added! Check added!
|
||||
|
|
@ -85,9 +85,8 @@ async function getAddress(userId) {
|
|||
|
you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere? you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere? you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
|
||||
let uAddresses = await lbry.getAddressesByAccount(userId);
|
||||
|
i'm slightly confused. Is this function supposed to generate addresses for users that were tipped but didn't yet have an account to their user? i'm slightly confused. Is this function supposed to generate addresses for users that were tipped but didn't yet have an account to their user?
That function is there to assure that the user has a tipping account in the new format, as the user needs that for the bot to be able to move over from the old account to the new account.(This function follows the new id format instead of username) That function is there to assure that the user has a tipping account in the new format, as the user needs that for the bot to be able to move over from the old account to the new account.(This function follows the new id format instead of username)
So yep, it is there to generate adresses(accounts) for users not having an account already. So yep, it is there to generate adresses(accounts) for users not having an account already.
|
||||
if (uAddresses.length > 0) return;
|
||||
await lbry.getNewAddress(userId);
|
||||
return;
|
||||
|
you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere? you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
|
||||
} catch (e) {
|
||||
logger.error(e);
|
||||
|
you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere? you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
|
||||
throw("Something went wrong while creating an account for the user: ", e);
|
||||
|
you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere? you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
|
||||
}
|
||||
}
|
||||
|
||||
|
|
|
|||
|
you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere? you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere? you're catching the error here, but what happens if something doesn't go right? Will a tip go through and fail along the process somewhere?
It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account It should probably not be catched there, instead it should throw an error in the main loop, making it impossible to try and send coins over to a non existing account
|
||||
don't forget to change or parameterize the track value.
also I'd use
letrather than var.3 is a magic number here in the sense that I have no clue what it is. I guess that it's not a problem on webstorm if it shows the parameter name, but worth keeping in mind that from outside the IDE it might not be easy to read.