Long answer: lbryschema and currently lbrynet.schema have copies of protobuf files embedded in the repo. It would be a separate task to move all of the protobufs out of lbrynet.schema into types repo and make sure that everything still works.

@nikooo777 has expressed some urgency in needing the claim signatures and thus the "publish date" metadata field added. I figure we can do that first, release it, then go back and refactor things so that we move all of the protobufs currently in lbrynet.schema into types, but i may overestimating amount of work required and this might be a simple transition to do...

@shyba since you're working on this I'll let you decide which order of things makes the most sense, you can 1) move protobuf definitions out of lbrynet.schema and merge them into types repo and then work on claim signatures or 2) do claim signatures first and then move the protobufs. let me know what you decide.

Short answer: Yes. Long answer: `lbryschema` and currently `lbrynet.schema` have copies of protobuf files embedded in the repo. It would be a separate task to move all of the protobufs out of `lbrynet.schema` into `types` repo and make sure that everything still works. @nikooo777 has expressed some urgency in needing the claim signatures and thus the "publish date" metadata field added. I figure we can do that first, release it, then go back and refactor things so that we move all of the protobufs currently in `lbrynet.schema` into `types`, but i may overestimating amount of work required and this might be a simple transition to do... @shyba since you're working on this I'll let you decide which order of things makes the most sense, you can 1) move protobuf definitions out of `lbrynet.schema` and merge them into `types` repo and then work on claim signatures or 2) do claim signatures first and then move the protobufs. let me know what you decide.

kauffj commented

2018-11-05 20:54:33 +01:00

(Migrated from github.com)

I would like to reach a point where changing metadata definitions is simple and can be done independently of the SDK.

I don't feel strongly that we be there before adding releaseTime, but I'd be fine with doing them at the same time if that made sense. @eukreign can you make sure the required changes are filed, at least?

I would like to reach a point where changing metadata definitions is simple and can be done independently of the SDK. I don't feel strongly that we be there before adding `releaseTime`, but I'd be fine with doing them at the same time if that made sense. @eukreign can you make sure the required changes are filed, at least?

eukreign commented

2018-11-06 06:14:55 +01:00

(Migrated from github.com)

As of 588779e3a4 lbrynet.schema.proto can be generated from types repo.

As of https://github.com/lbryio/lbry/commit/588779e3a4c942627545972c25715caa2d708abf `lbrynet.schema.proto` can be generated from `types` repo.

lyoshenka commented

2019-01-31 16:33:59 +01:00

(Migrated from github.com)

this is happening in https://github.com/lbryio/types/pull/17