[WIP] proto3 proposal #17
|
|
@ -4,4 +4,8 @@ package pb;
|
|||
|
||||
message Channel {
|
||||
bytes public_key = 1;
|
||||
string name = 2;
|
||||
yes yes
|
||||
string description = 3;
|
||||
string thumbnail_url = 4; // url or claim ID?
|
||||
string cover_url = 5; // url or claim ID?
|
||||
}
|
||||
|
we may want a short description, limited to a reasonable number of characters and no markup, as well as an unbounded (well, bounded by claim size) field that would be shown on the full profile view we may want a short description, limited to a reasonable number of characters and no markup, as well as an unbounded (well, bounded by claim size) field that would be shown on the full profile view
regarding: https://github.com/lbryio/types/pull/17#issuecomment-463418314 - I think Name could be the channels real name, or whatever they want to nickname their channel...i.e. my channel is @iloveLBRY, but the name would be "I Love LBRY!" How does everyone feel about adding some of my other suggestions from https://github.com/lbryio/types/issues/8 -at least Language (and/or Location? - that's what YT has) and Featured Video (lbry URL/claimid). regarding: https://github.com/lbryio/types/pull/17#issuecomment-463418314 - I think Name could be the channels real name, or whatever they want to nickname their channel...i.e. my channel is @iloveLBRY, but the name would be "I Love LBRY!"
How does everyone feel about adding some of my other suggestions from https://github.com/lbryio/types/issues/8 -at least Language (and/or Location? - that's what YT has) and Featured Video (lbry URL/claimid).
* should `cover` and `thumbnail` be web URLs or LBRY URLs or claim IDs? - I think this should be similar to our current thumbnail system, and if we decide to support LBRY urls/hashes there, then we should here too. For now, http urls / spee.ch links should work fine.
|
||||
|
|
|
|||
|
|
@ -7,9 +7,8 @@ import "channel.proto";
|
|||
|
Do we need this? Do we need this?
Do we need this? Do we need this?
|
||||
|
||||
message Claim {
|
||||
enum Type {
|
||||
UNKNOWN = 0;
|
||||
|
Do we need this? Do we need this?
|
||||
STREAM = 1;
|
||||
|
Do we need this? Do we need this?
|
||||
CHANNEL = 2;
|
||||
|
Do we need this? Do we need this?
|
||||
STREAM = 0;
|
||||
|
Do we need this? Do we need this?
|
||||
CHANNEL = 1;
|
||||
|
Do we need this? Do we need this?
|
||||
}
|
||||
|
||||
Type type = 1; // do we need this?
|
||||
|
|
|
|||
|
Do we need this? Do we need this?
Do we need this? Do we need this?
|
||||
|
|
@ -4,10 +4,9 @@ package pb;
|
|||
|
||||
message Fee {
|
||||
enum Currency {
|
||||
UNKNOWN = 0;
|
||||
LBC = 1;
|
||||
BTC = 2;
|
||||
USD = 3;
|
||||
LBC = 0;
|
||||
BTC = 1;
|
||||
USD = 2;
|
||||
}
|
||||
|
||||
Currency currency = 1;
|
||||
|
|
|
|||
|
|
@ -17,8 +17,7 @@ message Stream {
|
|||
|
This seems very safe to include in the top 15, I think. This seems very safe to include in the top 15, I think.
If this is metadata 2.0 this should be fixed/expanded, or simply moved into a tag. If this is metadata 2.0 this should be fixed/expanded, or simply moved into a tag.
What is this? What is this?
i actually don't know. we have it today i actually don't know. we have it today
This seems very safe to include in the top 15, I think. This seems very safe to include in the top 15, I think.
If this is metadata 2.0 this should be fixed/expanded, or simply moved into a tag. If this is metadata 2.0 this should be fixed/expanded, or simply moved into a tag.
What is this? What is this?
i actually don't know. we have it today i actually don't know. we have it today
|
||||
|
||||
Fee fee = 16;
|
||||
string license_url = 17;
|
||||
string thumbnail = 18;
|
||||
|
This seems very safe to include in the top 15, I think. This seems very safe to include in the top 15, I think.
If this is metadata 2.0 this should be fixed/expanded, or simply moved into a tag. If this is metadata 2.0 this should be fixed/expanded, or simply moved into a tag.
What is this? What is this?
i actually don't know. we have it today i actually don't know. we have it today
|
||||
string preview = 19;
|
||||
|
This seems very safe to include in the top 15, I think. This seems very safe to include in the top 15, I think.
If this is metadata 2.0 this should be fixed/expanded, or simply moved into a tag. If this is metadata 2.0 this should be fixed/expanded, or simply moved into a tag.
What is this? What is this?
i actually don't know. we have it today i actually don't know. we have it today
|
||||
bool nsfw = 20;
|
||||
|
This seems very safe to include in the top 15, I think. This seems very safe to include in the top 15, I think.
If this is metadata 2.0 this should be fixed/expanded, or simply moved into a tag. If this is metadata 2.0 this should be fixed/expanded, or simply moved into a tag.
What is this? What is this?
i actually don't know. we have it today i actually don't know. we have it today
|
||||
uint32 duration = 21;
|
||||
|
This seems very safe to include in the top 15, I think. This seems very safe to include in the top 15, I think.
If this is metadata 2.0 this should be fixed/expanded, or simply moved into a tag. If this is metadata 2.0 this should be fixed/expanded, or simply moved into a tag.
What is this? What is this?
i actually don't know. we have it today i actually don't know. we have it today
|
||||
string thumbnail_url = 18;
|
||||
|
This seems very safe to include in the top 15, I think. This seems very safe to include in the top 15, I think.
If this is metadata 2.0 this should be fixed/expanded, or simply moved into a tag. If this is metadata 2.0 this should be fixed/expanded, or simply moved into a tag.
What is this? What is this?
i actually don't know. we have it today i actually don't know. we have it today
|
||||
uint32 duration = 19;
|
||||
|
This seems very safe to include in the top 15, I think. This seems very safe to include in the top 15, I think.
If this is metadata 2.0 this should be fixed/expanded, or simply moved into a tag. If this is metadata 2.0 this should be fixed/expanded, or simply moved into a tag.
What is this? What is this?
i actually don't know. we have it today i actually don't know. we have it today
|
||||
repeated string tags = 20;
|
||||
|
This seems very safe to include in the top 15, I think. This seems very safe to include in the top 15, I think.
If this is metadata 2.0 this should be fixed/expanded, or simply moved into a tag. If this is metadata 2.0 this should be fixed/expanded, or simply moved into a tag.
What is this? What is this?
i actually don't know. we have it today i actually don't know. we have it today
|
||||
}
|
||||
|
this field should die entirely this field should die entirely
should it be changed to creator? if im publishing public-domain work that i did not create, how do i note that? should it be changed to creator? if im publishing public-domain work that i did not create, how do i note that?
Fair, something like this probably needs to exist. But if we're supporting that kind of thing we'd still want that to be a first-class entity (at some point, we're obviously not too close to that). I'd recommend keeping this out of the 15 because I do not think a single plain text field will be the ultimate solution for how distinguishing authorship. Fair, something like this probably needs to exist. But if we're supporting that kind of thing we'd still want that to be a first-class entity (at some point, we're obviously not too close to that).
I'd recommend keeping this out of the 15 because I do not think a single plain text field will be the ultimate solution for how distinguishing authorship.
|
||||
|
|
|
|||
|
This seems very safe to include in the top 15, I think. This seems very safe to include in the top 15, I think.
If this is metadata 2.0 this should be fixed/expanded, or simply moved into a tag. If this is metadata 2.0 this should be fixed/expanded, or simply moved into a tag.
What is this? What is this?
i actually don't know. we have it today i actually don't know. we have it today
This seems very safe to include in the top 15, I think. This seems very safe to include in the top 15, I think.
If this is metadata 2.0 this should be fixed/expanded, or simply moved into a tag. If this is metadata 2.0 this should be fixed/expanded, or simply moved into a tag.
What is this? What is this?
i actually don't know. we have it today i actually don't know. we have it today
|
||||
this is different from the name used to make the claim? is this like a title?