LBRYCommunity/types
1
0
Fork 0
Code Issues 13 Pull requests Projects Releases Packages Wiki Activity

wallet.proto start #47

Closed
orblivion wants to merge 14 commits from wallet.proto into master
pull from: wallet.proto
merge into: LBRYCommunity:master
Conversation 9 Commits 14 Files changed 3 +4 -4
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 87ab07bae0 - Show all commits

8
v2/proto/wallet.proto
View file

@ -21,13 +21,13 @@ message Wallet {
message Account {
message AddressGenerator {
lyoshenka commented 2022-01-31 23:39:53 +01:00 (Migrated from github.com)
Review
Copy link

@eukreign can this name field contain any name or is it choosing from a fixed set of options?

@eukreign can this name field contain any name or is it choosing from a fixed set of options?
eukreign commented 2022-01-31 23:44:57 +01:00 (Migrated from github.com)
Review
Copy link

just the two listed in the comment

just the two listed in the comment
lyoshenka commented 2022-02-01 18:34:35 +01:00 (Migrated from github.com)
Review
Copy link

@orblivion can you make these oneOfs plz

@orblivion can you make these `oneOf`s plz
orblivion commented 2022-02-01 21:39:23 +01:00 (Migrated from github.com)
Review
Copy link

I thought oneof was for fields (and thus types), not values. The only thing I saw for values was an enum, and that's only integers.

I thought `oneof` was for fields (and thus types), not values. The only thing I saw for values was an enum, and that's only integers.
orblivion commented 2022-02-01 22:00:24 +01:00 (Migrated from github.com)
Review
Copy link

Now, if this is valuable enough that schema changes are on the table, an enum may be the way to go.

enum AddressManagerType {
  single_address = 0;
  deterministic_chain = 1;
}
Now, if this is valuable enough that schema changes are on the table, an enum may be the way to go. ``` enum AddressManagerType { single_address = 0; deterministic_chain = 1; } ```
lyoshenka commented 2022-02-08 15:33:27 +01:00 (Migrated from github.com)
Review
Copy link

you're right, i meant enum

you're right, i meant enum
lyoshenka commented 2022-02-08 15:34:39 +01:00 (Migrated from github.com)
Review
Copy link

if enum doesn't do strings, there are two options. one is to leave it as a string. the other is to have it as an enum but then convert that to a string on save/load.

i think leaving it as a string is fine here

if enum doesn't do strings, there are two options. one is to leave it as a string. the other is to have it as an enum but then convert that to a string on save/load. i think leaving it as a string is fine here
orblivion commented 2022-02-08 21:33:50 +01:00 (Migrated from github.com)
Review
Copy link

If we need to do custom conversion code for the preferences json blob, I could do that here too.

If we need to do custom conversion code for the preferences json blob, I could do that here too.
message Chain { // TODO - good name?
message AddressManager {
uint32 gap = 1; // uint64? not sure how big this might get
uint32 maximum_uses_per_address = 2 [json_name="maximum_uses_per_address"];
}
Chain change = 1;
string name = 2;
Chain receiving = 3;
string name = 1;
AddressManager change = 2;
AddressManager receiving = 3;
}
AddressGenerator address_generator = 1 [json_name="address_generator"];