Think about configs for domain and ports (possibly fan out other issues) #12

New issue

Open

opened 2022-08-13 00:05:47 +02:00 by orblivion · 1 comment

orblivion commented

2022-08-13 00:05:47 +02:00

(Migrated from github.com)

Just some considerations I thought of that I wanted to write down. Nothing urgent here.

Right now, the wallet sync server is on port 8090, and the external port for Caddy is 8091. Not only is the former is currently hard-coded in Go, the latter is as well for the purpose of links in registration emails. This works fine for us and probably most users. There are a few possible issues though:

The signup link in the email has an ugly :8091.
The server admin (not us) might want to run other services locally at :8090.
The server admin (not us) might want to run other services externally at :8091.

One thing we may consider for 1) is to have Caddy route the signup url specifically to port 443. Or maybe just serve the whole thing on port 443.

Though we need port 80 for ACME. The user might have stuff on port 80. I guess at that point it's on them to make their own Caddy config for all of it together.

For 2) we could have the internal port be configurable. We'd probably want it set in ansible since we'd have to set it to be the same in Go and Caddy/systemd configs. Maybe external port as well (for 3)), though there's less justification for that as a way to get around conflicts with other services, since we'll always need port 80 for ACME, and that's already a port they'll be likely having conflicts with.

Just some considerations I thought of that I wanted to write down. Nothing urgent here. Right now, the wallet sync server is on port 8090, and the external port for Caddy is 8091. Not only is the former is currently hard-coded in Go, the latter is as well for the purpose of links in registration emails. This works fine for us and probably most users. There are a few possible issues though: 1) The signup link in the email has an ugly :8091. 2) The server admin (not us) might want to run other services locally at :8090. 3) The server admin (not us) might want to run other services externally at :8091. One thing we may consider for `1)` is to have Caddy route the signup url specifically to port 443. Or maybe just serve the whole thing on port 443. Though we need port 80 for ACME. The user might have stuff on port 80. I guess at that point it's on them to make their own Caddy config for all of it together. For `2)` we could have the internal port be configurable. We'd probably want it set in ansible since we'd have to set it to be the same in Go and Caddy/systemd configs. Maybe external port as well (for `3)`), though there's less justification for that as a way to get around conflicts with other services, since we'll always need port 80 for ACME, and that's already a port they'll be likely having conflicts with.

orblivion commented

2022-08-13 00:12:16 +02:00

(Migrated from github.com)

I think I'll just change plan to the external port to 443 for now. It could make issue 2) worse but that's something we'll worry about if people complain.

I'll add this change as a checkbox on the email issue - #5 - since it's related.

I think I'll just change plan to the external port to 443 for now. It could make issue `2)` worse but that's something we'll worry about if people complain. I'll add this change as a checkbox on the email issue - #5 - since it's related.