Download video to sync to local cache #113

Open
pseudoscalar wants to merge 7 commits from pseudoscalar/issue/112/v1 into local
4 changed files with 481 additions and 201 deletions
Showing only changes of commit 2ba960ae01 - Show all commits

View file

@ -5,12 +5,9 @@ import (
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
"errors"
"fmt"
"io/ioutil"
"time"
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
"os"
"os/exec"
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
"path"
"regexp"
"sort"
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
"strings"
log "github.com/sirupsen/logrus"
@ -20,9 +17,6 @@ import (
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
"github.com/lbryio/ytsync/v5/downloader/ytdl"
"github.com/lbryio/ytsync/v5/namer"
"github.com/lbryio/ytsync/v5/tags_manager"
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
"github.com/lbryio/lbry.go/v2/extras/jsonrpc"
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
"github.com/lbryio/lbry.go/v2/extras/util"
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
)
type SyncContext struct {
@ -80,122 +74,45 @@ func localCmd(cmd *cobra.Command, args []string) {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
fmt.Println(syncContext.LbrynetAddr)
videoID := args[0]
fmt.Println(videoID)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lbrynet := jsonrpc.NewClient(syncContext.LbrynetAddr)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lbrynet.SetRPCTimeout(5 * time.Minute)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
log.Debugf("Running sync for YouTube video ID %s", videoID)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
status, err := lbrynet.Status()
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
var publisher VideoPublisher
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
publisher, err = NewLocalSDKPublisher(syncContext.LbrynetAddr, syncContext.ChannelID, syncContext.PublishBid)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
if err != nil {
log.Error(err)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
log.Errorf("Error setting up publisher: %v", err)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
return
}
if !status.IsRunning {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
log.Error("SDK is not running")
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
var videoSource VideoSource
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
videoSource, err = NewYtdlVideoSource(syncContext.TempDir)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
if err != nil {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-11-05 21:31:22 +01:00 (Migrated from github.com)
Review

prolly need to make sure this exists

prolly need to make sure this exists
pseudoscalar commented 2021-11-08 16:37:40 +01:00 (Migrated from github.com)
Review

This should be guaranteed by cobra.ExactArgs(1), but I can a check and error here too.

This should be guaranteed by `cobra.ExactArgs(1)`, but I can a check and error here too.
lyoshenka commented 2021-11-11 23:09:58 +01:00 (Migrated from github.com)
Review

you're right, i just didnt notice that

you're right, i just didnt notice that
log.Errorf("Error setting up video source: %v", err)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
return
}
// Should check to see if the SDK owns the channel
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
// Should check to see if wallet is unlocked
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
// but jsonrpc.Client doesn't have WalletStatus method
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
// so skip for now
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
// Should check to see if streams are configured to be reflected and warn if not
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
// but jsonrpc.Client doesn't have SettingsGet method to see if streams are reflected
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
// so use File.UploadingToReflector as a proxy for now
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
videoBasePath := path.Join(syncContext.TempDir, videoID)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
videoMetadata, videoMetadataPath, err := getVideoMetadata(videoBasePath, videoID)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
sourceVideo, err := videoSource.GetVideo(videoID)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
if err != nil {
log.Errorf("Error getting video metadata: %v", err)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
log.Errorf("Error getting source video: %v", err)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
return
}
err = downloadVideo(videoBasePath, videoMetadataPath)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
processedVideo, err := processVideoForPublishing(*sourceVideo, syncContext.ChannelID)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
if err != nil {
log.Errorf("Error downloading video: %v", err)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
log.Errorf("Error processing source video for publishing: %v", err)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
return
}
tags, err := tags_manager.SanitizeTags(videoMetadata.Tags, syncContext.ChannelID)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
done, err := publisher.Publish(*processedVideo)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
if err != nil {
log.Errorf("Error sanitizing tags: %v", err)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
log.Errorf("Error publishing video: %v", err)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
return
}
urlsRegex := regexp.MustCompile(`(?m) ?(f|ht)(tp)(s?)(://)(.*)[.|/](.*)`)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
descriptionSample := urlsRegex.ReplaceAllString(videoMetadata.Description, "")
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
info := whatlanggo.Detect(descriptionSample)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
info2 := whatlanggo.Detect(videoMetadata.Title)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
var languages []string = nil
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
if info.IsReliable() && info.Lang.Iso6391() != "" {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
language := info.Lang.Iso6391()
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
languages = []string{language}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
} else if info2.IsReliable() && info2.Lang.Iso6391() != "" {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
language := info2.Lang.Iso6391()
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
languages = []string{language}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
// Thumbnail and ReleaseTime need to be properly determined
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
streamCreateOptions := jsonrpc.StreamCreateOptions {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
ClaimCreateOptions: jsonrpc.ClaimCreateOptions {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
Title: &videoMetadata.Title,
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
Description: util.PtrToString(getAbbrevDescription(videoMetadata)),
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
Languages: languages,
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
//ThumbnailURL: &v.thumbnailURL,
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
Tags: tags,
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
},
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
ReleaseTime: util.PtrToInt64(time.Now().Unix()),
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
ChannelID: &syncContext.ChannelID,
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
License: util.PtrToString("Copyrighted (contact publisher)"),
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
videoPath, err := getVideoDownloadedPath(syncContext.TempDir, videoID)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
err = <-done
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
if err != nil {
log.Errorf("Error determining downloaded video path: %v", err)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
log.Errorf("Error while wating for stream to reflect: %v", err)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
fmt.Println("%s", *streamCreateOptions.ClaimCreateOptions.Title)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
fmt.Println("%s", *streamCreateOptions.ClaimCreateOptions.Description)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
fmt.Println("%v", streamCreateOptions.ClaimCreateOptions.Languages)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
fmt.Println("%v", streamCreateOptions.ClaimCreateOptions.Tags)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
claimName := namer.NewNamer().GetNextName(videoMetadata.Title)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
log.Infof("Publishing stream as %s", claimName)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
txSummary, err := lbrynet.StreamCreate(claimName, videoPath, syncContext.PublishBid, streamCreateOptions)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
if err != nil {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
log.Errorf("Error creating stream: %v", err)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
return
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
for {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
fileListResponse, fileIndex, err := findFileByTxid(lbrynet, txSummary.Txid)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
if err != nil {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
log.Errorf("Error finding file by txid: %v", err)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
return
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
if fileListResponse == nil {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
log.Errorf("Could not find file in list with correct txid")
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
return
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
fileStatus := fileListResponse.Items[fileIndex]
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
if fileStatus.IsFullyReflected {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
log.Info("Stream is fully reflected")
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
break
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
if !fileStatus.UploadingToReflector {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
log.Warn("Stream is not being uploaded to a reflector. Check your lbrynet settings if this is a mistake.")
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
break
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
log.Infof("Stream reflector progress: %d%%", fileStatus.ReflectorProgress)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
time.Sleep(5 * time.Second)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
log.Info("Done")
}
@ -239,88 +156,6 @@ func loadVideoMetadata(path string) (*ytdl.YtdlVideo, error) {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
return videoMetadata, nil
}
func downloadVideoMetadata(basePath, videoID string) error {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
ytdlArgs := []string{
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
"--skip-download",
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
"--write-info-json",
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
"--force-overwrites",
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
fmt.Sprintf("https://www.youtube.com/watch?v=%s", videoID),
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
"--cookies",
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
"cookies.txt",
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
"-o",
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
basePath,
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
ytdlCmd := exec.Command("yt-dlp", ytdlArgs...)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
output, err := runCmd(ytdlCmd)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
log.Debug(output)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
return err
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
func downloadVideo(basePath, metadataPath string) error {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
ytdlArgs := []string{
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
"--no-progress",
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
"-o",
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
basePath,
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
"--merge-output-format",
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
"mp4",
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
"--postprocessor-args",
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
"ffmpeg:-movflags faststart",
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
"--abort-on-unavailable-fragment",
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
"--fragment-retries",
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
"1",
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
"--cookies",
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
"cookies.txt",
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
"--extractor-args",
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
"youtube:player_client=android",
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
"--load-info-json",
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
metadataPath,
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
"-fbestvideo[ext=mp4][vcodec!*=av01][height<=720]+bestaudio[ext!=webm][format_id!=258][format_id!=251][format_id!=256][format_id!=327]",
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
ytdlCmd := exec.Command("yt-dlp", ytdlArgs...)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
output, err := runCmd(ytdlCmd)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
log.Debug(output)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
return err
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
func runCmd(cmd *exec.Cmd) ([]string, error) {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
log.Infof("running cmd: %s", strings.Join(cmd.Args, " "))
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
var err error
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
stderr, err := cmd.StderrPipe()
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
if err != nil {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
return nil, err
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
stdout, err := cmd.StdoutPipe()
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
if err != nil {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
return nil, err
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
err = cmd.Start()
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
if err != nil {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
return nil, err
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
outLog, err := ioutil.ReadAll(stdout)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
if err != nil {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
return nil, err
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
errorLog, err := ioutil.ReadAll(stderr)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
if err != nil {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
return nil, err
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
done := make(chan error, 1)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
go func() {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
done <- cmd.Wait()
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}()
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
select {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
case err := <-done:
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
if err != nil {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
log.Error(string(errorLog))
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
return nil, err
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
return strings.Split(strings.Replace(string(outLog), "\r\n", "\n", -1), "\n"), nil
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
func getVideoDownloadedPath(videoDir, videoID string) (string, error) {
files, err := ioutil.ReadDir(videoDir)
if err != nil {
@ -339,31 +174,100 @@ func getVideoDownloadedPath(videoDir, videoID string) (string, error) {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
func getAbbrevDescription(v *ytdl.YtdlVideo) string {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
func getAbbrevDescription(v SourceVideo) string {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
if v.Description == nil {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
return v.SourceURL
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
maxLength := 2800
description := strings.TrimSpace(v.Description)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
additionalDescription := "\nhttps://www.youtube.com/watch?v=" + v.ID
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
description := strings.TrimSpace(*v.Description)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
additionalDescription := "\n" + v.SourceURL
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
if len(description) > maxLength {
description = description[:maxLength]
}
return description + "\n..." + additionalDescription
}
// if jsonrpc.Client.FileList is extended to match the actual jsonrpc schema, this can be removed
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
func findFileByTxid(client *jsonrpc.Client, txid string) (*jsonrpc.FileListResponse, int, error) {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
response, err := client.FileList(0, 20)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
for {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
if err != nil {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
log.Errorf("Error getting file list page: %v", err)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
return nil, 0, err
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
index := sort.Search(len(response.Items), func (i int) bool { return response.Items[i].Txid == txid })
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
if index < len(response.Items) {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
return response, index, nil
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
if response.Page >= response.TotalPages {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
return nil, 0, nil
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
response, err = client.FileList(response.Page + 1, 20)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
type SourceVideo struct {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
ID string
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
Title *string
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
Description *string
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
SourceURL string
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
Languages []string
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
Tags []string
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
ReleaseTime *int64
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
ThumbnailURL *string
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
FullLocalPath string
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
type PublishableVideo struct {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
ID string
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
ClaimName string
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
Title string
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
Description string
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
SourceURL string
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
Languages []string
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
Tags []string
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
ReleaseTime int64
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
ThumbnailURL string
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
FullLocalPath string
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
func processVideoForPublishing(source SourceVideo, channelID string) (*PublishableVideo, error) {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
tags, err := tags_manager.SanitizeTags(source.Tags, channelID)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
if err != nil {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
log.Errorf("Error sanitizing tags: %v", err)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
return nil, err
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
descriptionSample := ""
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
if source.Description != nil {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
urlsRegex := regexp.MustCompile(`(?m) ?(f|ht)(tp)(s?)(://)(.*)[.|/](.*)`)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
descriptionSample = urlsRegex.ReplaceAllString(*source.Description, "")
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
info := whatlanggo.Detect(descriptionSample)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
title := ""
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
if source.Title != nil {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
title = *source.Title
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
info2 := whatlanggo.Detect(title)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
var languages []string = nil
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
if info.IsReliable() && info.Lang.Iso6391() != "" {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
language := info.Lang.Iso6391()
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
languages = []string{language}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
} else if info2.IsReliable() && info2.Lang.Iso6391() != "" {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
language := info2.Lang.Iso6391()
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
languages = []string{language}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
claimName := namer.NewNamer().GetNextName(title)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
thumbnailURL := ""
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
if source.ThumbnailURL != nil {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
thumbnailURL = *source.ThumbnailURL
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
processed := PublishableVideo {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
ClaimName: claimName,
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
Title: title,
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
Description: getAbbrevDescription(source),
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
Languages: languages,
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
Tags: tags,
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
ReleaseTime: *source.ReleaseTime,
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
ThumbnailURL: thumbnailURL,
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
FullLocalPath: source.FullLocalPath,
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
log.Debugf("Video prepared for publication: %v", processed)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
return &processed, nil
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
type VideoSource interface {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
GetVideo(id string) (*SourceVideo, error)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
type VideoPublisher interface {
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
Publish(video PublishableVideo) (chan error, error)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
}

lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)
lyoshenka commented 2021-10-14 21:42:24 +02:00 (Migrated from github.com)
Review

i recommend os.ReadFile() to read the file in one go

i recommend os.ReadFile() to read the file in one go
lyoshenka commented 2021-11-05 21:32:31 +01:00 (Migrated from github.com)
Review

id call this something other than done to make it clear its a channel that lets you know when the video is done reflecting

id call this something other than `done` to make it clear its a channel that lets you know when the video is done reflecting
lyoshenka commented 2021-11-05 21:37:50 +01:00 (Migrated from github.com)
Review

minor nit, but doesn't this potentially make the description longer than the max length?

minor nit, but doesn't this potentially make the description longer than the max length?
pseudoscalar commented 2021-11-08 16:44:35 +01:00 (Migrated from github.com)
Review

This was mostly ripped from getAbbrevDescription in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.

This was mostly ripped from `getAbbrevDescription` in sources/youtubeVideo.go. I didn't know exactly where the value of 2800 came from, so I just assumed the logic was correct. If it is supposed to be a limit on the total description length, I'll fix this.
lyoshenka commented 2021-11-11 23:12:04 +01:00 (Migrated from github.com)
Review

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

i think that's an estimate of how long the description can get before we hit the max claim size limit. id still fix it so the math is right though :-)

120
local/localSDKPublisher.go Normal file
View file

@ -0,0 +1,120 @@
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
package local
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
import (
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
"errors"
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
"sort"
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
"time"
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
log "github.com/sirupsen/logrus"
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
"github.com/lbryio/lbry.go/v2/extras/jsonrpc"
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
"github.com/lbryio/lbry.go/v2/extras/util"
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
)
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
type LocalSDKPublisher struct {
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
channelID string
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
publishBid float64
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
lbrynet *jsonrpc.Client
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
}
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
func NewLocalSDKPublisher(sdkAddr, channelID string, publishBid float64) (*LocalSDKPublisher, error) {
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
lbrynet := jsonrpc.NewClient(sdkAddr)
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
lbrynet.SetRPCTimeout(5 * time.Minute)
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
status, err := lbrynet.Status()
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
if err != nil {
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
return nil, err
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
}
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
if !status.IsRunning {
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
return nil, errors.New("SDK is not running")
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
}
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
// Should check to see if the SDK owns the channel
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
// Should check to see if wallet is unlocked
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
// but jsonrpc.Client doesn't have WalletStatus method
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
// so skip for now
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
// Should check to see if streams are configured to be reflected and warn if not
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
// but jsonrpc.Client doesn't have SettingsGet method to see if streams are reflected
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
// so use File.UploadingToReflector as a proxy for now
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
publisher := LocalSDKPublisher {
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
channelID: channelID,
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
publishBid: publishBid,
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
lbrynet: lbrynet,
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
}
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
return &publisher, nil
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
}
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
func (p *LocalSDKPublisher) Publish(video PublishableVideo) (chan error, error) {
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
streamCreateOptions := jsonrpc.StreamCreateOptions {
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
ClaimCreateOptions: jsonrpc.ClaimCreateOptions {
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
Title: &video.Title,
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
Description: &video.Description,
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
Languages: video.Languages,
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
ThumbnailURL: &video.ThumbnailURL,
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
Tags: video.Tags,
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
},
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
ReleaseTime: &video.ReleaseTime,
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
ChannelID: &p.channelID,
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
License: util.PtrToString("Copyrighted (contact publisher)"),
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
}
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
txSummary, err := p.lbrynet.StreamCreate(video.ClaimName, video.FullLocalPath, p.publishBid, streamCreateOptions)
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
if err != nil {
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
return nil, err
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
}
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
done := make(chan error, 1)
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
go func() {
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
for {
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
fileListResponse, fileIndex, err := findFileByTxid(p.lbrynet, txSummary.Txid)
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
if err != nil {
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
log.Errorf("Error finding file by txid: %v", err)
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
done <- err
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
return
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
}
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
if fileListResponse == nil {
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
log.Errorf("Could not find file in list with correct txid")
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
done <- err
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
return
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
}
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
fileStatus := fileListResponse.Items[fileIndex]
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
if fileStatus.IsFullyReflected {
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
log.Info("Stream is fully reflected")
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
break
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
}
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
if !fileStatus.UploadingToReflector {
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
log.Warn("Stream is not being uploaded to a reflector. Check your lbrynet settings if this is a mistake.")
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
break
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
}
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
log.Infof("Stream reflector progress: %d%%", fileStatus.ReflectorProgress)
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
time.Sleep(5 * time.Second)
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
}
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
done <- nil
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
}()
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
return done, nil
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
}
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
// if jsonrpc.Client.FileList is extended to match the actual jsonrpc schema, this can be removed
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
func findFileByTxid(client *jsonrpc.Client, txid string) (*jsonrpc.FileListResponse, int, error) {
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
response, err := client.FileList(0, 20)
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
for {
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
if err != nil {
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
log.Errorf("Error getting file list page: %v", err)
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
return nil, 0, err
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
}
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
index := sort.Search(len(response.Items), func (i int) bool { return response.Items[i].Txid == txid })
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
if index < len(response.Items) {
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
return response, index, nil
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
}
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
if response.Page >= response.TotalPages {
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
return nil, 0, nil
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
}
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
response, err = client.FileList(response.Page + 1, 20)
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
}
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work
}
lyoshenka commented 2021-11-05 21:35:00 +01:00 (Migrated from github.com)
Review

if this is an error (or an unexpected thing), it should prolly send an error to done, right?

if this is an error (or an unexpected thing), it should prolly send an error to `done`, right?
pseudoscalar commented 2021-11-08 17:17:49 +01:00 (Migrated from github.com)
Review

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.

The thinking was that this may be intentional since it is driven by lbrynet settings. I could turn this into an error if that case is unlikely. I could also add a command line flag to indicate that streams won't be reflected.
lyoshenka commented 2021-11-11 23:11:09 +01:00 (Migrated from github.com)
Review

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

yea id either make it an option or just assume that all streams will be reflected. option is better but more work

202
local/ytdl.go Normal file
View file

@ -0,0 +1,202 @@
package local
import (
"encoding/json"
"errors"
"fmt"
"io/ioutil"
"os"
"os/exec"
"path"
"strings"
log "github.com/sirupsen/logrus"
"github.com/lbryio/ytsync/v5/downloader/ytdl"
)
type Ytdl struct {
DownloadDir string
}
func NewYtdl(downloadDir string) (*Ytdl, error) {
// TODO validate download dir
y := Ytdl {
DownloadDir: downloadDir,
}
return &y, nil
}
func (y *Ytdl) GetVideoMetadata(videoID string) (*ytdl.YtdlVideo, error) {
metadataPath, err := y.GetVideoMetadataFile(videoID)
if err != nil {
return nil, err
}
metadataBytes, err := os.ReadFile(metadataPath)
if err != nil {
return nil, err
}
var metadata *ytdl.YtdlVideo
err = json.Unmarshal(metadataBytes, &metadata)
if err != nil {
return nil, err
}
return metadata, nil
}
func (y *Ytdl) GetVideoMetadataFile(videoID string) (string, error) {
basePath := path.Join(y.DownloadDir, videoID)
metadataPath := basePath + ".info.json"
_, err := os.Stat(metadataPath)
if err != nil && !os.IsNotExist(err) {
log.Errorf("Error determining if video metadata already exists: %v", err)
return "", err
} else if err != nil {
log.Debugf("Metadata file for video %s does not exist. Downloading now.", videoID)
err = downloadVideoMetadata(basePath, videoID)
if err != nil {
return "", err
}
}
return metadataPath, nil
}
func (y *Ytdl) GetVideoFile(videoID string) (string, error) {
videoPath, err := findDownloadedVideo(y.DownloadDir, videoID)
if err != nil {
return "", err
}
if videoPath != nil {
return *videoPath, nil
}
basePath := path.Join(y.DownloadDir, videoID)
metadataPath, err := y.GetVideoMetadataFile(videoID)
if err != nil {
log.Errorf("Error getting metadata path in preparation for video download: %v", err)
return "", err
}
err = downloadVideo(basePath, metadataPath)
if err != nil {
return "", nil
}
videoPath, err = findDownloadedVideo(y.DownloadDir, videoID)
if err != nil {
log.Errorf("Error from findDownloadedVideo() after already succeeding once: %v", err)
return "", err
}
if videoPath == nil {
return "", errors.New("Could not find a downloaded video after successful download.")
}
return *videoPath, nil
}
func findDownloadedVideo(videoDir, videoID string) (*string, error) {
files, err := ioutil.ReadDir(videoDir)
if err != nil {
return nil, err
}
for _, f := range files {
if f.IsDir() {
continue
}
if path.Ext(f.Name()) == ".mp4" && strings.Contains(f.Name(), videoID) {
videoPath := path.Join(videoDir, f.Name())
return &videoPath, nil
}
}
return nil, nil
}
func downloadVideoMetadata(basePath, videoID string) error {
ytdlArgs := []string{
"--skip-download",
"--write-info-json",
"--force-overwrites",
fmt.Sprintf("https://www.youtube.com/watch?v=%s", videoID),
"--cookies",
"cookies.txt",
"-o",
basePath,
}
ytdlCmd := exec.Command("yt-dlp", ytdlArgs...)
output, err := runCmd(ytdlCmd)
log.Debug(output)
return err
}
func downloadVideo(basePath, metadataPath string) error {
ytdlArgs := []string{
"--no-progress",
"-o",
basePath,
"--merge-output-format",
"mp4",
"--postprocessor-args",
"ffmpeg:-movflags faststart",
"--abort-on-unavailable-fragment",
"--fragment-retries",
"1",
"--cookies",
"cookies.txt",
"--extractor-args",
"youtube:player_client=android",
"--load-info-json",
metadataPath,
"-fbestvideo[ext=mp4][vcodec!*=av01][height<=720]+bestaudio[ext!=webm][format_id!=258][format_id!=251][format_id!=256][format_id!=327]",
}
ytdlCmd := exec.Command("yt-dlp", ytdlArgs...)
output, err := runCmd(ytdlCmd)
log.Debug(output)
return err
}
func runCmd(cmd *exec.Cmd) ([]string, error) {
log.Infof("running cmd: %s", strings.Join(cmd.Args, " "))
var err error
stderr, err := cmd.StderrPipe()
if err != nil {
return nil, err
}
stdout, err := cmd.StdoutPipe()
if err != nil {
return nil, err
}
err = cmd.Start()
if err != nil {
return nil, err
}
outLog, err := ioutil.ReadAll(stdout)
if err != nil {
return nil, err
}
errorLog, err := ioutil.ReadAll(stderr)
if err != nil {
return nil, err
}
done := make(chan error, 1)
go func() {
done <- cmd.Wait()
}()
select {
case err := <-done:
if err != nil {
log.Error(string(errorLog))
return nil, err
}
return strings.Split(strings.Replace(string(outLog), "\r\n", "\n", -1), "\n"), nil
}
}

54
local/ytdlVideoSource.go Normal file
View file

@ -0,0 +1,54 @@
package local
import (
"time"
log "github.com/sirupsen/logrus"
"github.com/lbryio/lbry.go/v2/extras/util"
)
type YtdlVideoSource struct {
downloader Ytdl
}
func NewYtdlVideoSource(downloadDir string) (*YtdlVideoSource, error) {
ytdl, err := NewYtdl(downloadDir)
if err != nil {
return nil, err
}
source := YtdlVideoSource {
downloader: *ytdl,
}
return &source, nil
}
func (s *YtdlVideoSource) GetVideo(id string) (*SourceVideo, error) {
metadata, err := s.downloader.GetVideoMetadata(id)
if err != nil {
return nil, err
}
videoPath, err := s.downloader.GetVideoFile(id)
if err != nil {
return nil, err
}
sourceVideo := SourceVideo {
ID: id,
Title: &metadata.Title,
Description: &metadata.Description,
SourceURL: "\nhttps://www.youtube.com/watch?v=" + id,
Languages: []string{},
Tags: metadata.Tags,
ReleaseTime: util.PtrToInt64(time.Now().Unix()),
ThumbnailURL: nil,
FullLocalPath: videoPath,
}
log.Debugf("Source video retrieved via ytdl: %v", sourceVideo)
return &sourceVideo, nil
}